Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Arend van Spriel <aspriel@gmail.com>
To:     Sean Anderson <sean.anderson@seco.com>,
        <linux-wireless@vger.kernel.org>, Kalle Valo <kvalo@codeaurora.org>
CC:     "Chi-hsien Lin" <chi-hsien.lin@cypress.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Tejun Heo <tj@kernel.org>, <SHA-cyfmac-dev-list@infineon.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Wright Feng <wright.feng@cypress.com>,
        Arend Van Spriel <arend.vanspriel@broadcom.com>,
        <brcm80211-dev-list.pdl@broadcom.com>
Date:   Tue, 17 Aug 2021 19:17:00 +0200
Message-ID: <17b551dc6e0.279b.9696ff82abe5fb6502268bdc3b0467d4@gmail.com>
In-Reply-To: <e6eb89af-b81e-b96e-70a6-c9498eb681fd@seco.com>
References: <20210802170904.3116223-1-sean.anderson@seco.com>
 <e6eb89af-b81e-b96e-70a6-c9498eb681fd@seco.com>
User-Agent: AquaMail/1.30.1-1828 (build: 103001000)
Subject: Re: [PATCH] brcmfmac: Set SDIO workqueue as WQ_HIGHPRI
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="us-ascii"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On August 17, 2021 6:50:50 PM Sean Anderson <sean.anderson@seco.com> wrote:

> ping?

Good idea to ping with a top-level post :-p

>
>
> On 8/2/21 1:09 PM, Sean Anderson wrote:
>> This puts tasks submitted to the SDIO workqueue at the head of the queue
>> and runs them immediately. This gets higher RX throughput with the SDIO
>> bus.
>>
>> This was originally submitted as [1]. The original author Wright Feng
>> reports
>>
>>> throughput result with 43455(11ac) on 1 core 1.6 Ghz platform is
>>> Without WQ_HIGGPRI TX/RX: 293/301 (mbps)
>>> With    WQ_HIGHPRI TX/RX: 293/321 (mbps)
>>
>> I tested this with a 43364(11bgn) on a 1 core 800 MHz platform and got
>> Without WQ_HIGHPRI TX/RX: 16/19 (Mbits/sec)
>> With    WQ_HIGHPRI TX/RX: 24/20 (MBits/sec)
>>
>> [1] 
>> https://lore.kernel.org/linux-wireless/1584604406-15452-4-git-send-email-wright.feng@cypress.com/

While I understand the obvious gain it seems like a wrong move to me. What 
if all workqueues in the kernel would start using this flag? I bet the gain 
above would be negated and all are equal in the eyes of .. the kernel

Regards,
Arend