Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp288051pxb; Wed, 18 Aug 2021 02:20:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8T9Wp66f/r1qKf/tkMBG85ohq2TbPBmN9zWTt+ZpdCFWA/kIDGqugf24yg+kH+KjhlhUr X-Received: by 2002:a05:6e02:d06:: with SMTP id g6mr5547143ilj.153.1629278428216; Wed, 18 Aug 2021 02:20:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629278428; cv=none; d=google.com; s=arc-20160816; b=IvaQEK75+DZ9p/SrSYOOWpJAMBo2GEe02qL5LUIT4wih1/PV8CrWFhTV5fUKLxbPfH U5gEI4tcA1nnEjoHfNlXJdiRQAmIbqnO7pWRCon2sB0h8eFIYfLqvFFpqRE+AGiuH4UR dItzNQ0A2T+R5o1W23T4jukqxBmvy56brgGNwmTGu848+QZadBDi5mduTuwH2uFJDeu7 jaNor6q4zp8po3YLSjVO4gHS86bqdc77DJSVcETE9uCVgf3hVtKeoBR1CQF8fA4nCXew ot7hCqtVkEADwjXDLol8YJObQGwYGVnl+2mI4DdgWxZktG8ivkhEHEtHkqPga/iHAU0C N6vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2N4rMKiX3XUTQu/ceoBbkSWk8Bk3R6p6kvK231HhsQw=; b=TbSJd4Ui+gU+W31ZHXGzOvJPo9ayUf41cMXYp/StACiB8aykcDKXLn4nXzovg9wNn6 r2/xeXkGMK9F1s0kbn2SK5K/G/+BZLCjMipoU+SZkNqb6Sq1HmcYWIUFKtGqn/aepmFc V4R/gLM00XfMce+Yo3NlKlmxYCJQ1ZYkrta+f6/vCmmxvGjZn+HwaPeSbrNSS5VyrqPl 3fx6Nc3hf6alwyAaDu5b1eHd2mj1FvjfRizgLCCEGxL1TgEsXsPXNFLNal/bb2nx618x yqoJ4P7nfHPtn44sxsoDutl20Dbz8reThJzOUJ9oE5cLJ+4a8QIPKAIL+dBsP0oFS79B dXxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LbTzH0gc; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t16si5005616ilh.72.2021.08.18.02.20.15; Wed, 18 Aug 2021 02:20:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LbTzH0gc; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231665AbhHRJTH (ORCPT + 99 others); Wed, 18 Aug 2021 05:19:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:56900 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231660AbhHRJTG (ORCPT ); Wed, 18 Aug 2021 05:19:06 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B2C2461053; Wed, 18 Aug 2021 09:18:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1629278312; bh=friwccb5Ts3sorbhemyaGBt/b1Dkjnx6Ia4rZ7X9Ffc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LbTzH0gcLS+3ThzJSajlXaufNyCRrCdbRW2VdnqSgFAabLVKWpeo3uy4Y1P+iGsvI BmvUNTLQ/0sf9x5YGkgY7PXfU1NaAaeZP98gQ1RL9JPFrZwALkiMohZQ2yf71RB33a QdeI2VV+VX1jNTWlwH0DFP6hpx9FF/tAhr6O4odg= Date: Wed, 18 Aug 2021 11:18:29 +0200 From: Greg KH To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: stable@vger.kernel.org, Sasha Levin , Kalle Valo , linux-wireless@vger.kernel.org Subject: Re: Backporting CVE-2020-3702 ath9k patches to stable Message-ID: References: <20210818084859.vcs4vs3yd6zetmyt@pali> <20210818091027.2mhqrhg5pcq2bagt@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210818091027.2mhqrhg5pcq2bagt@pali> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Aug 18, 2021 at 11:10:27AM +0200, Pali Roh?r wrote: > On Wednesday 18 August 2021 11:02:47 Greg KH wrote: > > On Wed, Aug 18, 2021 at 10:48:59AM +0200, Pali Roh?r wrote: > > > Hello! I would like to request for backporting following ath9k commits > > > which are fixing CVE-2020-3702 issue. > > > > > > 56c5485c9e44 ("ath: Use safer key clearing with key cache entries") > > > 73488cb2fa3b ("ath9k: Clear key cache explicitly on disabling hardware") > > > d2d3e36498dd ("ath: Export ath_hw_keysetmac()") > > > 144cd24dbc36 ("ath: Modify ath_key_delete() to not need full key entry") > > > ca2848022c12 ("ath9k: Postpone key cache entry deletion for TXQ frames reference it") > > > > > > See also: > > > https://lore.kernel.org/linux-wireless/87o8hvlx5g.fsf@codeaurora.org/ > > > > > > This CVE-2020-3702 issue affects ath9k driver in stable kernel versions. > > > And due to this issue Qualcomm suggests to not use open source ath9k > > > driver and instead to use their proprietary driver which do not have > > > this issue. > > > > > > Details about CVE-2020-3702 are described on the ESET blog post: > > > https://www.welivesecurity.com/2020/08/06/beyond-kr00k-even-more-wifi-chips-vulnerable-eavesdropping/ > > > > > > Two months ago ESET tested above mentioned commits applied on top of > > > 4.14 stable tree and confirmed that issue cannot be reproduced anymore > > > with those patches. Commits were applied cleanly on top of 4.14 stable > > > tree without need to do any modification. > > > > What stable tree(s) do you want to see these go into? > > Commits were introduced in 5.12, so it should go to all stable trees << 5.12 > > > And what order are the above commits to be applied in, top-to-bottom or > > bottom-to-top? > > Same order in which were applied in 5.12. So first commit to apply is > 56c5485c9e44, then 73488cb2fa3b and so on... (from top of the email to > the bottom of email). Great, all now queued up. Sad that qcom didn't want to do this themselves :( greg k-h