Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp439609pxb; Wed, 18 Aug 2021 06:03:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHRT1AdZ2E1ees8BuWAQ8LI0JKqz0QYb1M7FAjnR0enbr4Sgil5erEQKzNuJbA4wdF2VTE X-Received: by 2002:a02:a409:: with SMTP id c9mr7745737jal.138.1629291785062; Wed, 18 Aug 2021 06:03:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629291785; cv=none; d=google.com; s=arc-20160816; b=LTBn9Xg4sYdjhOULsJ7Co4mMBT1dtSKzR37AgfAUvEUFlGD4vE3ufCkPOWUt2S1ZAw svroWZY6YqNIHx68mFmYtn4S8Hq8g7YuElMxyAwjK+rsBFOGsyc+7lzPHYUIaWUrneJq HDSvnb60MuwmDNOxMGhiCjdia1PgLZx4OqW8cafoRcup3XvanDaEhVzBSCXraYUb/OHI qzd4dwD1uNTdmmNEUe7CV17gzp8L8KDPwX1QacrllPnJZzNrBz+l9kdlhTEDoCHDoNo4 zzacApGYwbnJmRSaAISkkEpIsVYuc0lAbMSPD9gCYGG/z0MmndLnZrBf2VlSbsydD+Of KOqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=MkYUY8hRWwEu70DXUFF8siW38IO889EQpcP0JG9olHM=; b=wztsaJp6bNUbmimPIZg4t8cI9VblpNjkithvglDz/rCS43sVRb8kFXFSUb+mgRCfGB xiYPlGsQ7z0LiWXAE4OuiFX9JcwlTD2PcZkvWcx/NVhxaal6eVE3azfQV+GPNxMV2K0l UUFB9zA5g/vid6v6z/mTbRHUOhmOhpQ12e7HIC8TNT2iM2dxbzYQZaak6e3ninFZQ7CJ gc9StEvOZxcWEVx5YpeEYbv1oNj+h1SfrLhvXzeqP0yfA7Z7tcMHxcAPehhFlQ9pkHNV 1GtnutgYJ2In4TGy7gbulW4mpSzgj8Cl5P+li6pk3qCUPpTuDppin4tccyja5sFcyzdZ y+Yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=p816tpeN; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h8si6993803iow.45.2021.08.18.06.02.43; Wed, 18 Aug 2021 06:03:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=p816tpeN; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236470AbhHRNDE (ORCPT + 99 others); Wed, 18 Aug 2021 09:03:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235423AbhHRNDD (ORCPT ); Wed, 18 Aug 2021 09:03:03 -0400 Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DF9DC061764; Wed, 18 Aug 2021 06:02:29 -0700 (PDT) Received: by mail-il1-x130.google.com with SMTP id f15so2127287ilk.4; Wed, 18 Aug 2021 06:02:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MkYUY8hRWwEu70DXUFF8siW38IO889EQpcP0JG9olHM=; b=p816tpeNXiyVNrHjM3CLMARaTaQ9Q1DNkBPMF5S/QiTyS8TtyNuS4uSDtOvWYkZ9DD KQs/VrSCx51qbgHOlhlqY+ZKamKhLS30a7nBa0Wn0WLKywG5EDsLvKzBc8Q5yqbovwVx JjTa60sLtZoqpUSmCE3n0/wVzWzMxMTWIHpNstWexLoJOQJ+OxMi+XyB3QXEwvmEN+f/ wXa6Legda4Ugp7uCGvf3V1ZSw2wJsDe8AJmzt4yb1ib7Fzm5YmC5TfAcZFARVI54/XV+ DmeEiBYBUtdGwSDq+flIDrO71sP+aqrSrFvrxjsUFvpe0gY8Pan4eGGNA/tuXNtoplKZ TcWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MkYUY8hRWwEu70DXUFF8siW38IO889EQpcP0JG9olHM=; b=qgyZfoyFiYiTL5aNMFzViUyirAFPjdNqfFHKkBf2bU/EzmJ+wTdpbyu9Bw+i8VKva/ q6TeUZ04Df5USQcNsP2npho0jlnK14yN0B7oYgW5AX9IE3RdEtaU08GFL8607ZVHQ9jb /T1P2sc/WgsxFLOUpyh9hiXoqYQgpXmKo4TpAJxm9xgSoRQft7DePq4SODjn3aZgGkF+ LSnCXL52DPQOr+7zuENVVeevW+yVYj2A4BB1F3ZmYqsdZqp8FseYuhpwtt+GujmZpOBV xQbsiIeP4na7mUt8mIC4fk6mMovDg8N9BMTYwpvKhYF+WpKZBSvJde+Zbf6Th3/YxDB/ YjFA== X-Gm-Message-State: AOAM531yjGirPqgC5Pmy+20FI+k64n1Y2TiZqUuaCOD8E2IjMCINULZu TV+cQofOABemlc0ZqbSBZQLtOVxR9l3het95/us= X-Received: by 2002:a92:b711:: with SMTP id k17mr6012067ili.247.1629291748768; Wed, 18 Aug 2021 06:02:28 -0700 (PDT) MIME-Version: 1.0 References: <20210818060533.3569517-1-keescook@chromium.org> <20210818060533.3569517-26-keescook@chromium.org> In-Reply-To: <20210818060533.3569517-26-keescook@chromium.org> From: Miguel Ojeda Date: Wed, 18 Aug 2021 15:02:17 +0200 Message-ID: Subject: Re: [PATCH v2 25/63] compiler_types.h: Remove __compiletime_object_size() To: Kees Cook Cc: linux-kernel , Nick Desaulniers , Nathan Chancellor , Miguel Ojeda , Sedat Dilek , Will Deacon , Marco Elver , Arvind Sankar , Masahiro Yamada , Luc Van Oostenryck , Andrew Morton , Sami Tolvanen , Thomas Gleixner , Gabriel Krisman Bertazi , Andy Lutomirski , Oleg Nesterov , "Gustavo A. R. Silva" , Greg Kroah-Hartman , linux-wireless , Network Development , dri-devel , linux-staging@lists.linux.dev, linux-block@vger.kernel.org, Linux Kbuild mailing list , clang-built-linux , Rasmus Villemoes , linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Aug 18, 2021 at 8:14 AM Kees Cook wrote: > > Since all compilers support __builtin_object_size(), and there is only > one user of __compiletime_object_size, remove it to avoid the needless > indirection. This lets Clang reason about check_copy_size() correctly. Sounds good to me, the indirection is making things more complex than they need to be. Reviewed-by: Miguel Ojeda Cheers, Miguel