Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp47754pxb; Wed, 18 Aug 2021 15:37:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVAnVsMN1AhTIiITOV4r+Yg4ohTewDKjGn1N18tTPhI7yTY92xz/mc24Wg+5MLcUeDt7Ow X-Received: by 2002:aa7:c58e:: with SMTP id g14mr12737146edq.179.1629326278738; Wed, 18 Aug 2021 15:37:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629326278; cv=none; d=google.com; s=arc-20160816; b=NE0lQos240R5F95VrYDL+WKKoUO4h9TRGiiYfEvyb+yi550lY2zgNb6o9z9bQ5/Xfm rHoz800VvlyZrP1MC7Q5MsKofh4Nv0COgpQJXqzuNTsJyL8quVXRVZP+enzpjeezae3Y RTE9AL9Q7EC1fUvsgKli7Vq68VP9UQ6+0pC2FoRWZPtOhEdyhYomM98bFD7+qXx1LmZy d1pUWRQ6K9D5ZTwOiZUG9kZphUsIIw0P5R/838PbIncEDQJ5GBzCyHJcJUZAoLE559B8 hv30Y+E++VRjhLDgJpS5ao16WGoRvICPslwjai8JUFT28M8z2ovSUAs1dhHP8zgDuww8 QhYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=2sMII5G/YrPb+0dkZspyZPS9+RZRKOtmg2+pJ+lOQh8=; b=TfgauoutKLsXJl8VFDPHyPR7Z9MT5QOJGJ5FKbhPAviEsnb06wouYG5N6HBV717VTh H4WtWErfAntgEZ0CZgB2AcJTz7DLLqUafxvcxgEZDH4ilkt8B9jRLLeSq30kA92giaxm XwO10sfRMrZOfh4pZYTPrw9F/yQlismntboMYKn092aByp5NurqijJ4RnJEY5YC1b64d 2RoCeAJ8IotFFR6tvaurXP+fBqvZpl9rvUvHmX5aAzhgeIvtmMEftzsFUjqp+rhljnO1 ul6MJIDeJ9fEmbErrhhf9YDsC0EV1AgSDSJdQCxUXwFM2+f6AJdjjRxgJCzNH6oNGYqw sW8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=zCeTW3J0; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1432736edm.532.2021.08.18.15.37.35; Wed, 18 Aug 2021 15:37:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=zCeTW3J0; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234796AbhHRWhL (ORCPT + 99 others); Wed, 18 Aug 2021 18:37:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234783AbhHRWhK (ORCPT ); Wed, 18 Aug 2021 18:37:10 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 027D9C0617AD for ; Wed, 18 Aug 2021 15:36:34 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id j187so3648244pfg.4 for ; Wed, 18 Aug 2021 15:36:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2sMII5G/YrPb+0dkZspyZPS9+RZRKOtmg2+pJ+lOQh8=; b=zCeTW3J0K5np3tXoG1IVSEAaPhRTsp6E7FG40JMxEKemO8ZOHARazqIQmpKFIcs6Sd N+GcdWyWkTcutczTnN4sOyyVCxvFWCYptMFPsGfhg09eZke8WGMWE7X323gqAUdPsHGt GJI+Q1n5sJHSiu6jvMoqplSND0vhS0iaBcT4D21x/nhiQ6MHkY+ruWt2EXdQpfM96zjC hi5+qOD40TDeOvrQRR206d0ujvibZUy7wKb/uB+gerRXWqa6ZBPhLTAUkWQOL5fPGNzE UiSjQoQgCCbD822O9dBlOBwzl+Vg8GmLowbUkm3Fma27sj5ipvOpNTGfxjNlZImQucyY 2hBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2sMII5G/YrPb+0dkZspyZPS9+RZRKOtmg2+pJ+lOQh8=; b=VJo5H7+K+ktdJS1Tim1c1w/v47OPrPhHQQUTN4hvhelmFxeGJVuDr/5N0wmUxn5H7r /mnKXqJyPVUQQHFf8o12L/WVNlojYQ6A0avGtHzu0zcJ/QDMYRI4tLNG0q5N2HF9LDJ7 NK7ptG80FBnz5Mg7yat2ieNXi1K7OMqmR7fsfUpaxd2Ozdk2+yMR97xP8rVXGBQVMVia DbmwpPEIO5JgPNA0xG8cD0VHo7mbShOLjzrUMGdXQMoxN6p3j1a4XLu3mpuRBI035uvq XNlfp5+8MwImhlLmMHYHdtKysgKFcmnWaswjB97UQLkFMz+A5BL37T0OLqao4lVrBsGu KDWA== X-Gm-Message-State: AOAM530iUQqic+0rZCQK8ipYk3M3JZpRPuy+omyOorN4q731qRbYA3AO BH/PVPyqR06bOe9LU3xGo8EuPvBM8hQOrpwOKcaauw== X-Received: by 2002:a63:dd0e:: with SMTP id t14mr9405083pgg.279.1629326194463; Wed, 18 Aug 2021 15:36:34 -0700 (PDT) MIME-Version: 1.0 References: <20210818060533.3569517-1-keescook@chromium.org> <20210818060533.3569517-7-keescook@chromium.org> In-Reply-To: <20210818060533.3569517-7-keescook@chromium.org> From: Dan Williams Date: Wed, 18 Aug 2021 15:36:23 -0700 Message-ID: Subject: Re: [PATCH v2 06/63] cxl/core: Replace unions with struct_group() To: Kees Cook Cc: Linux Kernel Mailing List , Alison Schofield , Vishal Verma , Ira Weiny , Ben Widawsky , linux-cxl@vger.kernel.org, "Gustavo A. R. Silva" , Greg Kroah-Hartman , Andrew Morton , Linux Wireless List , Netdev , Maling list - DRI developers , linux-staging@lists.linux.dev, linux-block@vger.kernel.org, Linux Kbuild mailing list , clang-built-linux , Rasmus Villemoes , linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Aug 17, 2021 at 11:06 PM Kees Cook wrote: > > Use the newly introduced struct_group_typed() macro to clean up the > declaration of struct cxl_regs. > > Cc: Alison Schofield > Cc: Vishal Verma > Cc: Ira Weiny > Cc: Ben Widawsky > Cc: linux-cxl@vger.kernel.org > Suggested-by: Dan Williams Looks good and tests ok here: Reviewed-by: Dan Williams