Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp568385pxb; Thu, 19 Aug 2021 06:21:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYKmA/UlIkfRwAtAPDLmFUTgpq2SJu+GcSNamzO2n2HCA9jFXW0AUO0AqDIZy4gCwme0dv X-Received: by 2002:aa7:c548:: with SMTP id s8mr16926408edr.162.1629379275740; Thu, 19 Aug 2021 06:21:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629379275; cv=none; d=google.com; s=arc-20160816; b=ywr6FJlDHeu9gLLFOx/YK56IElK1MTTQ0Wo2ECTTm52ZFO3oWU4ZDUb8lxm5bD/uFT H+dIi+af7ZP42IiO+TPhfVtb/oyOn4X2pta8vBveAhyFNvF6elxV6nDL7jECBw/mjkZn JGLrlMDrlgfYMqWmfDI3PToPbnkC1v257sah5SrguSsfM77JZu70g3Fxjq87COhuyPge 08et1n6E6+1rodg7mYJrZiPMUANQBUSGHiwi7qeEj2HM2eAI+msPZuZmlKAEmxGRR6U0 dMKUdJtGszuEqoQXXAqb1mG7c5BJfm5Lkh6Rr9hmcByRDUTm8I1IJNeTAji752M3FZOZ dMkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=l4dT+tFYjcxU/834O3TlS8Kbm5D9Je72nne0F+3BpO8=; b=Q8xR3N53jMhDp3Ay2WrAbTca6IHc6rMOhmFGDjoMTfpEk06ppBD4fd9rfpF2ylfTAt qoLs12M3CE8mxGS5jiOqz1z5qIsXnnvmi8ufAhPmvT/8+togJsQ2/JwSa9/QCTQRE92y b6GVZvSuTWQ6W0aooktctBGEGkCwk68RbVF3hRIN8xbqOd8kPNoS74BaIAyZarjW/yGZ GmFERz6KLjN/1dDOJxtiF+VTrrm9orRAwLask+vF8l3kYWCK+7ibUXuP+OtONnF6Yrm2 ebbYiG9Sbi18MizGwezvwxWbLECwjzJR+xCjeAARgNFzRtSzoufjlRfvhMDgMxDvkSJQ K2dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=mklUJZu+; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w16si3012765edr.106.2021.08.19.06.20.39; Thu, 19 Aug 2021 06:21:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=mklUJZu+; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238292AbhHSNUy (ORCPT + 99 others); Thu, 19 Aug 2021 09:20:54 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:53719 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239735AbhHSNUx (ORCPT ); Thu, 19 Aug 2021 09:20:53 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1629379217; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=l4dT+tFYjcxU/834O3TlS8Kbm5D9Je72nne0F+3BpO8=; b=mklUJZu+uHT0ftH5+c95NJTPRa2Kk+YlRpBZTpGGohsBE1CBpDw1PmbJpMZ0AN7xrkgZoocz 4uGofvV1wolODOnRaUAlL9q2LYILntrYdL4e5A+EsiD6CksP+Cqf9HC0cqZWYq4yYwaB48oU RI4+BaYBwE9mUeYd+BpS+/U54Z0= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 611e5a76f746c298d95da996 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 19 Aug 2021 13:19:50 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 6E904C4360D; Thu, 19 Aug 2021 13:19:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from tynnyri.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2682CC4338F; Thu, 19 Aug 2021 13:19:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 2682CC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Kalle Valo To: Kees Cook Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, "Gustavo A. R. Silva" , Greg Kroah-Hartman , Andrew Morton , dri-devel@lists.freedesktop.org, linux-staging@lists.linux.dev, linux-block@vger.kernel.org, linux-kbuild@vger.kernel.org, clang-built-linux@googlegroups.com, Rasmus Villemoes , linux-hardening@vger.kernel.org Subject: Re: [PATCH v2 45/63] ath11k: Use memset_startat() for clearing queue descriptors References: <20210818060533.3569517-1-keescook@chromium.org> <20210818060533.3569517-46-keescook@chromium.org> Date: Thu, 19 Aug 2021 16:19:37 +0300 In-Reply-To: <20210818060533.3569517-46-keescook@chromium.org> (Kees Cook's message of "Tue, 17 Aug 2021 23:05:15 -0700") Message-ID: <87eeapbmhi.fsf@tynnyri.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kees Cook writes: > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memset(), avoid intentionally writing across > neighboring fields. > > Use memset_startat() so memset() doesn't get confused about writing > beyond the destination member that is intended to be the starting point > of zeroing through the end of the struct. Additionally split up a later > field-spanning memset() so that memset() can reason about the size. > > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: ath11k@lists.infradead.org > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook To avoid conflicts I prefer taking this via my ath tree. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches