Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org C8584C43460
From:   Kalle Valo <kvalo@codeaurora.org>
To:     greearb@candelatech.com
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH v5 07/11] mt76: mt7915:  add support for tx-overrides
References: <20210804134505.3208-1-greearb@candelatech.com>
        <20210804134505.3208-7-greearb@candelatech.com>
Date:   Thu, 19 Aug 2021 18:08:01 +0300
In-Reply-To: <20210804134505.3208-7-greearb@candelatech.com> (greearb's
        message of "Wed, 4 Aug 2021 06:45:01 -0700")
Message-ID: <875yw1bhgu.fsf@tynnyri.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

greearb@candelatech.com writes:

> From: Ben Greear <greearb@candelatech.com>
>
> Allow setting fix rate on transmit without using full testmode
> logic.

Why?

> txpower, dynbw, retry count is not currently supported.
> And, probably later need additional logic to not apply this
> txo to non-data frames and to smaller frames, to allow
> ARP and such to go through while also forcing test data frames
> to arbitrary tx-rates (rates which very well may not be
> received by peer.)

Please include an example how to use the debugfs file.

IIRC there was a similar rtw88 patch adding a debugfs to force setting
the tx rate. So what's the consensus, are we going to allow each driver
have their own custom interfaces setting tx rates? In my opinion this
should go via a generic nl80211 command, but if people think having
custom tx rate interfaces is ok I guess I need to reconsider.

As this patch needs more discussion, please separate it from rest of the
series so that it can be applied separately.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches