Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1452169pxb; Fri, 20 Aug 2021 06:03:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGKmjviOAi3bag+AOoXOJuEGwi151+7OlMEudExceef2DCSWn2SUaj1OspmSfKgOD4w4DU X-Received: by 2002:a02:cc8e:: with SMTP id s14mr17304300jap.102.1629464608610; Fri, 20 Aug 2021 06:03:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629464608; cv=none; d=google.com; s=arc-20160816; b=ctjrebgm7euHE2Smccva8mkjsNNGqefcjtMnGQ3WomV9E1/kiHqjyeVsVFmB1BqYKj CDDMcJ6u6Gk1QMZVKeoWtbl28CAxN3PUPeca49GOgNavKrAURRLPThQDkm9BTJZS/9zb GKeAbsBj8o2+S1IdPfmIKhyJhg12P5iPDyQSE0+DxyzUW6fPCqH5HrGt/LlrejDmlosi fjcQb1l6C+svEQJaahTh4vLjUOXiC8uwMcRu6NpOI4CMolpk6KuLx07yk3uIG0SlNIX6 QeV+AjdBfmwDGex8rNoidSbEf2PCqxjqgbi4g+z7A+c1Q5xw8lCFnfFdDaiVqGPfy4BR hw0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=SJVV3AKIKDS2kEFqPRBaUFYL5+LDfULPieELhdDLGkc=; b=f1RlGBiZ6n9nr4ltjRlXSU1RIn7ZaOR6B6SIm2OPgpFYVt9PL5twNuV+uGbCUYsxST qFM8u/NS0lt1x8NRzIv4UitIVSd00zh53lEs/lL9HFjYluOg7ZEYIPI97c9SK4i3HOY4 2j1PpErAHNsFGJHZOifI3O4AjJYJM6+h25RGbJUUMqm3qPiEl+PF/ZJs+HqdYwQzraZo OOU4Og1SSIHQdV6mHrKCHLt0p7aO4PoUtrHFT1qMoecawqy6BSbzTwhwk1qqnMhROnjV 0w2djevqWZOp5jgHUq5o/WoQ8BsqfdeKs0QjCFgqzaiN09GQQCTG4rlQqbfPmttDd4n+ aQGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aYMABfEH; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t13si7730806jaj.38.2021.08.20.06.03.11; Fri, 20 Aug 2021 06:03:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aYMABfEH; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240704AbhHTNCr (ORCPT + 99 others); Fri, 20 Aug 2021 09:02:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:42578 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240685AbhHTNCq (ORCPT ); Fri, 20 Aug 2021 09:02:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 60A9660F39; Fri, 20 Aug 2021 13:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629464528; bh=XmK3LL/kczQ8Z+mWS0jnuPNaTKva71BKQybVqIajn2U=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=aYMABfEHFn+7Kxh2/MCRF/AHSGEXnmm1wwYZV/SiISnuS7QAg8vC8A8gHUcJQHHJU jndvWKCbmKREp+Q+csliLWq1xfVo9N1ThE9t9PC3acSXLZUZd8ZV+43etboNIfFSU4 elTORRr93PV1FUprfZYqHAQtChsRVKZLcib11SGIunO2FEuIUTOfXEmOzVFWIIAfpi Gpu4L7iSStDO8sT6ED1OTcs1Qu/7AmVe3IQTNXsGFPhv2pIFnV1eYeNYrTX8r8c+XZ KZt7w4RnLsX1Bh7LiMJY7mFit8tljzKmeylhW39zI5+LMFsGOrnGgg9dGOurKa5wA1 /AbeTWLFaERiQ== Date: Fri, 20 Aug 2021 15:02:03 +0200 (CEST) From: Jiri Kosina To: Kees Cook cc: linux-kernel@vger.kernel.org, Stefan Achatz , Benjamin Tissoires , linux-input@vger.kernel.org, "Gustavo A. R. Silva" , Greg Kroah-Hartman , Andrew Morton , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-staging@lists.linux.dev, linux-block@vger.kernel.org, linux-kbuild@vger.kernel.org, clang-built-linux@googlegroups.com, Rasmus Villemoes , linux-hardening@vger.kernel.org Subject: Re: [PATCH v2 55/63] HID: roccat: Use struct_group() to zero kone_mouse_event In-Reply-To: <20210818060533.3569517-56-keescook@chromium.org> Message-ID: References: <20210818060533.3569517-1-keescook@chromium.org> <20210818060533.3569517-56-keescook@chromium.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 17 Aug 2021, Kees Cook wrote: > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memset(), avoid intentionally writing across > neighboring fields. > > Add struct_group() to mark region of struct kone_mouse_event that should > be initialized to zero. > > Cc: Stefan Achatz > Cc: Jiri Kosina > Cc: Benjamin Tissoires > Cc: linux-input@vger.kernel.org > Signed-off-by: Kees Cook Applied, thank you Kees. -- Jiri Kosina SUSE Labs