Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: question on HE debugfs output
To:     Johannes Berg <johannes@sipsolutions.net>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
References: <578da3a0-f029-4e60-d4e6-34d42def62e8@candelatech.com>
 <2c55dce18c94d778207b3fc452a09e14ee80c032.camel@sipsolutions.net>
From:   Ben Greear <greearb@candelatech.com>
Organization: Candela Technologies
Message-ID: <dd40890b-c8a1-e3c1-d234-672179dc6331@candelatech.com>
Date:   Fri, 20 Aug 2021 08:08:55 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <2c55dce18c94d778207b3fc452a09e14ee80c032.camel@sipsolutions.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-MW
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/20/21 2:17 AM, Johannes Berg wrote:
> Hi Ben,
> 
>> While poking around in things, I noticed that the
>> he_capa debugfs is not showing the least-common-denominator, but rather
>> more specifically the peer's capabilities.
>>
>> This could be bugs in how I'm using this, but thought I'd ask to
>> see if this was on purpose or not.
> 
> It was on purpose. Also, for HE it's different from HT/VHT in that we
> don't do this in the stack any more.
> 
> I'm not really sure _why_ now (or if we should change it), but I seem to
> remember it was just a lot more complex to do in general, but drivers
> didn't really care so much since they tend to have a lot of hard-coded
> assumptions, e.g. they might not care about seeing 2, 3 or more streams
> supported if their code assumes the device always only supports 2 in the
> first place, so all they need is a >= 2 check in this case, for example.
> 
> If you wanted to change that, I wouldn't mind, but it might be complex.

Ok, for now it is a curiosity.  While hacking on things (to disable 160Mhz
support so that a station can be forced to 80Mhz when radio supports 160),
I ended up writing code to take the station HE capabilities from the driver
and then modify them.  Other code in mac80211 is already sort of doing this
here and there.  So, maybe that is a way to start consolidating the
'overrides' logic to build a more proper HE capab in mac80211...

Thanks,
Ben

> 
> johannes
> 


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com