Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1567716pxb; Fri, 20 Aug 2021 08:31:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3R49eMB1qff1jxhrmEqPpnM67806A0TFKtggp92rRx/KxNhzGUIcoja0O5hWy4eBwMN3y X-Received: by 2002:a17:906:25db:: with SMTP id n27mr21877130ejb.108.1629473483027; Fri, 20 Aug 2021 08:31:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629473483; cv=none; d=google.com; s=arc-20160816; b=xFvdKQekLl+KVL1FfUif0yN3KsLcxyu7vDiLXmuEk1uI3ft6kxZxLea/SuPSc5idV7 czEjGrpQwfb9sEBtHbNpAPKMS6Ba7A5LUDwtTazQCVJiF7Bpgc1yjqlCRz9GdLPKBpBL PVUOmpS5ueOIug4eWfZLHZlymGEmbA0LPchPB0QrTTryhWl+66hNEXr5P9mH1slRZDcs tCjTUbCjOJMPz9YlrtBFU0OuozyM2mAVsw5I3lItYA5cz6xtqa70Olu9KunpW8l8diZa 7Fum4EH+V72tisjazXp6U/X/zdZMsiReHS2hDbFh5vuGccaLpugHpJusWNcxPxmuOLrG HYug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=gkKDMktT3eVn0p9aEG+bkUvAjLeEeXeIQpdYpqlVHU8=; b=C7EdauAyJN1siUCMcAGXOKcGuEUZueBfJieZ3Z8CZ/oN+PhhyeqxViQSnwx/OIhu2W 67AzYi6AgQGnEiynWbb29DInFrscOajCRCUCg0ALzN3lihH43HTl8X8jVlV4ESIKifb3 1WrFciZwXqjTR2kHD4l2C8Sdt9f3tTqydbuuiBj7Ti4e30bYezEnVv55e8IcjGhTq2Ij rfwi9wvjHvhcpbycgqjNuO6n+gw+C1TXxlJDQOs315ReJvDyKpT9GWnn78mduT1nJMoR 531RXRRKSdjuB4lyupzkfdhslMPfrFkFu1ChI8BtvpYSaoQ7Dz2d6Ynoc/QikUZPaWvp HMdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hD1bmNxq; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s15si6504934ejc.168.2021.08.20.08.30.42; Fri, 20 Aug 2021 08:31:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hD1bmNxq; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241051AbhHTP2T (ORCPT + 99 others); Fri, 20 Aug 2021 11:28:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:56544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240472AbhHTP2S (ORCPT ); Fri, 20 Aug 2021 11:28:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9331A60F44; Fri, 20 Aug 2021 15:27:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629473260; bh=OwwtgX2M/Z1j8G1sPd2l0muzQPlxYWaQWBaFFSOCB3I=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=hD1bmNxq2pXA6JY0w3JSfU6ec1u4utu+1+zz9abtVNra03vaEswGGJOV+Z2853GXD oWJ5vmjMvcenUtdBVw1+fZ+L5fZOztbObkcT5iIaya9Tcvq/cYGfTGfh6LnoChpBR+ iGroeoSTE1zbRytr6N7HLC8nAHksqo/5ucG0afMSW2Famnb5JgFraG/JaJFaJandAh zToyO+JNLN+2FsSfuo9qIsrx3YbBTwpSaj8JU5ZQwb83Adi++CTjgtUK8mlvC1lY6x 2angoBbLeQxbPm9CmNpz2Vmc9cCVXYEkeNBrRT70CAVatQvZR6NiwmD3WIRrEnz9q1 PGj2wVDAgorvQ== Date: Fri, 20 Aug 2021 17:27:35 +0200 (CEST) From: Jiri Kosina To: Kees Cook cc: LKML , Stefan Achatz , Benjamin Tissoires , linux-input , "Gustavo A. R. Silva" , Greg Kroah-Hartman , Andrew Morton , linux-wireless , Network Development , Maling list - DRI developers , linux-staging@lists.linux.dev, linux-block , linux-kbuild , clang-built-linux , Rasmus Villemoes , linux-hardening@vger.kernel.org Subject: Re: [PATCH v2 55/63] HID: roccat: Use struct_group() to zero kone_mouse_event In-Reply-To: Message-ID: References: <20210818060533.3569517-1-keescook@chromium.org> <20210818060533.3569517-56-keescook@chromium.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 20 Aug 2021, Kees Cook wrote: > > > In preparation for FORTIFY_SOURCE performing compile-time and run-time > > > field bounds checking for memset(), avoid intentionally writing across > > > neighboring fields. > > > > > > Add struct_group() to mark region of struct kone_mouse_event that should > > > be initialized to zero. > > > > > > Cc: Stefan Achatz > > > Cc: Jiri Kosina > > > Cc: Benjamin Tissoires > > > Cc: linux-input@vger.kernel.org > > > Signed-off-by: Kees Cook > > > > Applied, thank you Kees. > > > > Eek! No, this will break the build: struct_group() is not yet in the tree. > I can carry this with an Ack, etc. I was pretty sure I saw struct_group() already in linux-next, but that was apparently a vacation-induced brainfart, sorry. Dropping. -- Jiri Kosina SUSE Labs