Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp556917pxb; Sat, 21 Aug 2021 10:32:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3DOSpQc5baDeE47WZGogOUSv3UYosnfF0juZ/7XWw9rm1I3o7uRThZCwFosHsTpRokkLM X-Received: by 2002:a05:6e02:f44:: with SMTP id y4mr17842253ilj.257.1629567161362; Sat, 21 Aug 2021 10:32:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629567161; cv=none; d=google.com; s=arc-20160816; b=1G92gQXPIv3Oj18+K2No1/RkX5VZerT/FaQ2uO0vltOcZDXSGWZKmQlU1ffvwiyqkI L3flziluDfVZZhCB38KgxLKYJZFA0+4cmBVccWUCbdSlFMRmUNuHHc7pFtE74PrlUmfM QL8MDiCbXsVZLqVWkrzXrrAXjCT325HuDZEj4MYwACurYfL1wbzs9GWZB/FmubP3HZ4Z UEH5eTPTs9fXVV/HWXVn9/W4dFFx6bzCvN3iIh3MK8nxBtAAGYaAAl4bsaMMQ5135Jf3 bVOQWBN2c5Gb5XvVGeLI2hAgQA2hb7mFSRud5ihFTu+OnfQ1nktmNAoX/dWU9DDST6oo jUFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=2BboqZtCczhs7Gj5gmMKaCpliJBrP2gnrnXMEhNrp9U=; b=Ho6yQ12aUo0l4mA9vp/7qkN5TtbbWSxHuINS4/4hrQ5oGYh6zC9fHaK/uErr9dFkaN 3nKX7emhxeoobteGACfjZE9oJaFvtlvdIeK76/KnegO6BvPDm5ewwdZ2igygggXb7c6C 6b29qw6C90czjZFPsTaTbQq/fZdOWOxAY+hpekbSOkfWQkQa44aHJmXuTf2irNfwa2Iu eg3CeBlDDpJvVk9XVaVyW7Bde+/VwJoOdx3zgX1aWbiGcvGcCwlv6/dkvW+lPMKIuqR2 +DLHkVaswQrS7gUJAgE+5Q5GaBWoDziqDh1Rj2lDx6SikEPhKUio8Wk3FmNBPCa0xELl dn7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=EDmmvxaP; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m10si11813050ilu.53.2021.08.21.10.32.29; Sat, 21 Aug 2021 10:32:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=EDmmvxaP; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231424AbhHURdH (ORCPT + 99 others); Sat, 21 Aug 2021 13:33:07 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:39546 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230486AbhHURdG (ORCPT ); Sat, 21 Aug 2021 13:33:06 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1629567147; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=2BboqZtCczhs7Gj5gmMKaCpliJBrP2gnrnXMEhNrp9U=; b=EDmmvxaP72lWkOiUe/gSVk04K+W/4JMvKxZPXA2/bFaFsxRjDtW7DAzCJcgPgobSRdr9OojP 58iBmBQaHMxlgi3ESYd8mzuq0lKCZVsa0R+OukhrG6XMH6cbLgUQorSbm/GmmahPzVAv9yK2 OqqIZLGXRo9JXFezN7Aye212nN8= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 6121388ff588e42af1471067 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 21 Aug 2021 17:31:59 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 7AED7C43616; Sat, 21 Aug 2021 17:31:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id CCD6DC4338F; Sat, 21 Aug 2021 17:31:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org CCD6DC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 3/3] rtlwifi: rtl8192de: fix array size limit in for-loop From: Kalle Valo In-Reply-To: <20210803144949.79433-3-colin.king@canonical.com> References: <20210803144949.79433-3-colin.king@canonical.com> To: Colin King Cc: Ping-Ke Shih , "David S . Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, Joe Perches , linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210821173159.7AED7C43616@smtp.codeaurora.org> Date: Sat, 21 Aug 2021 17:31:59 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Colin King wrote: > From: Colin Ian King > > Currently the size of the entire array is being used in a for-loop > for the element count. While this works since the elements are u8 > sized, it is preferred to use ARRAY_SIZE to get the element count > of the array. > > Kudos to Joe Perches for spotting this issue. > > Signed-off-by: Colin Ian King Dropped per Colin's request. Patch set to Changes Requested. -- https://patchwork.kernel.org/project/linux-wireless/patch/20210803144949.79433-3-colin.king@canonical.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches