Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp610506pxb; Sat, 21 Aug 2021 12:23:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+LsX42yX2i+xicWOBwQ46oneEtnHdZV6AtAfrR+hb00D9JI9b/RiidK5vDkmyz9I0tovo X-Received: by 2002:a17:906:c34c:: with SMTP id ci12mr27849899ejb.247.1629573810378; Sat, 21 Aug 2021 12:23:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629573810; cv=none; d=google.com; s=arc-20160816; b=lqv5woITioJmZPuKfGRJM9glXNhiNAPiPHKFvNsRNuWFu3sltHrcRsWQJKq5iicAH4 xGZRapOFOdOJ+i9FQ3cl2yfpMF8+TNe2jqgqM47sZDSri2LReFCJnXWQTNVnB5E6u97c tg/D19wI3/shsYkzDSioLla+2Vua9y48OfLs8eW16VTwvKma22YnqbhIeM9R96iOt/d5 vwQuL2Ip0+A1Z2z4xZMnfQdc67/Kj1/u4nZNTMhycq8O1FGv8kciycZOtwWFlI1Qv6IW rdUzFsDuDEgX8iPVQ/0twozJBOqgiEtuXMmKD0omrgcD7WGARRys1hQH/xhoQg3fG4bF qObg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=uU3flCSn+iSXZF50k3teJibmCKL3vWrmBnwznoFYZGw=; b=WWHRlL5Or9BiKAXMzyAtuj3ojawi54/geBirReZqcksQ7g5iZwKhtAFmRhGeYurLag SeQy2znt3zHEbWgxagvEUunmvEVsZsx7uBbmRnw16p/j9vAgKrQ1DOMSYvE8QH/EbL5B y1s+qpDtBt5kczHjrJAF19kWCLq98EXU+Ds5zDA7A07RdVB+nNbHKsURfo2TOMtGHc+4 RHd77nPbNrDLGx/Iq7SCVvpbXCBmHdzONWt9ITJtUIIm93Ev6dadRwSlGnb4N0UC966z uZDTO0oSQxdHil6/S51E9+DmZZvd2Gim/6g2oqufpjmH02BsnLTvBawYnVRoDaHT+tBM VVwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=k+K92hLa; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ca15si4045669edb.442.2021.08.21.12.23.06; Sat, 21 Aug 2021 12:23:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=k+K92hLa; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230384AbhHUTV3 (ORCPT + 99 others); Sat, 21 Aug 2021 15:21:29 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:24779 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231130AbhHUTV2 (ORCPT ); Sat, 21 Aug 2021 15:21:28 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1629573649; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=uU3flCSn+iSXZF50k3teJibmCKL3vWrmBnwznoFYZGw=; b=k+K92hLa55GPXMxiVala8Thnx6EqCHaaunbcSmISzMDMTFK9sczL5zsOSKP4ub8avRxVAhIO eWhCsD5Eqes6XHZYmJ8CpFHPviQKQUwY3vIHfWCtUycBw7fHlwerL1puHFTTlWX/PGfZdsfD RU4bztoyTiHbKG8/Z1j2P7rMhEc= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 6121520034bfa7697987cce8 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 21 Aug 2021 19:20:32 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E1BE5C43617; Sat, 21 Aug 2021 19:20:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1A513C4338F; Sat, 21 Aug 2021 19:20:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 1A513C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] brcmsmac: make array addr static const, makes object smaller From: Kalle Valo In-Reply-To: <20210819125552.8888-1-colin.king@canonical.com> References: <20210819125552.8888-1-colin.king@canonical.com> To: Colin King Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , "David S . Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210821192032.E1BE5C43617@smtp.codeaurora.org> Date: Sat, 21 Aug 2021 19:20:32 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Colin King wrote: > From: Colin Ian King > > Don't populate the array addr on the stack but instead it > static const. Makes the object code smaller by 79 bytes: > > Before: > text data bss dec hex filename > 176015 54652 128 230795 3858b .../broadcom/brcm80211/brcmsmac/main.o > > After: > text data bss dec hex filename > 175872 54716 128 230716 3853c .../broadcom/brcm80211/brcmsmac/main.o > > (gcc version 10.3.0) > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 0dc62413c882 brcmsmac: make array addr static const, makes object smaller -- https://patchwork.kernel.org/project/linux-wireless/patch/20210819125552.8888-1-colin.king@canonical.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches