Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <2e0bea3524268f96a39506b3e5ea9f738c6aab27.camel@perches.com>
Subject: Re: [PATCH v1 1/1] ray_cs: use %*ph to print small buffer
From:   Joe Perches <joe@perches.com>
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
Date:   Sun, 22 Aug 2021 00:14:51 -0700
In-Reply-To: <877dgerrqw.fsf@codeaurora.org>
References: <20210712142943.23981-1-andriy.shevchenko@linux.intel.com>
         <20210821171432.B996DC4360C@smtp.codeaurora.org>
         <293b9231af8b36bb9a24a11c689d33c7e89c3c4e.camel@perches.com>
         <877dgerrqw.fsf@codeaurora.org>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.0-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 2021-08-22 at 08:08 +0300, Kalle Valo wrote:
> Joe Perches <joe@perches.com> writes:
> 
> > On Sat, 2021-08-21 at 17:14 +0000, Kalle Valo wrote:
> > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > 
> > > > Use %*ph format to print small buffer as hex string.
> > > > 
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > 
> > > Patch applied to wireless-drivers-next.git, thanks.
> > > 
> > > 502213fd8fca ray_cs: use %*ph to print small buffer
> > > 
> > 
> > There's one more of these in the same file but it's in an #ifdef 0 block...
> 
> I would rather remove the whole ifdef 0 block, patches welcome.
> 

It'd probably take you about 20 seconds if you do it yourself.

$ git grep -P -n '^\s*#\s*if\s+0\b' drivers/net/wireless/ray_cs.c
drivers/net/wireless/ray_cs.c:637:#if 0
drivers/net/wireless/ray_cs.c:2281:#if 0
drivers/net/wireless/ray_cs.c:2341:#if 0

Rather a bit more time if you want to do the whole kernel...

$ git grep -P -n '^\s*#\s*if\s+0\b' | wc -l
1558