Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1535147pxb; Sun, 22 Aug 2021 20:57:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuIWjh9Lqxn+HJnUBFpeMMc2Ez/WBQpJ3p5btzgJY5UYDIOnfQ/c4xjWGqAZNRlyd8TMRM X-Received: by 2002:a92:d1c6:: with SMTP id u6mr21229080ilg.263.1629691025352; Sun, 22 Aug 2021 20:57:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629691025; cv=none; d=google.com; s=arc-20160816; b=its1PAcmK3OZTSR8eCJacQG93lbIK0yB9t/N/9so1dR72JZu233nAdeyPxFSUMw9eu w2QYQjy2Jjcvx3hhneXS0Nr1fIWpw/3R/zmXX10v9gaCh/60miprwxtpiBYrYonvuBlz itCJpgdxvfAUEwlreNk1VX2OiC+XokWR0adO9hmbV6jSzo9FJ1XFf9NeWBV26clb/960 RXKmWjB/VYWmlniIAtleZdj2grdt9wvCU8z+Tr2ccEgNj+ksdlTQftqoEZpUQR72bWDR qQOFWuLrcv0zvD9fqpa7+jTR0rZMjL6alJIcDSUiTmJSmpWOer6uisHdq97ExHLpWDE0 VsBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=1jqpwT3ELmcBTv7KMPyfIjf/NFmDmSwbNgVLqVGGcT4=; b=wp5VEFjLN2gCSRzSOo3aj9BhWrwrqPJZ36T8E93rZJAWQjnyh1BKtfuETAbUSNAWC9 L5vG+/VYaOPoGhTVSNfvl6PNN0VqXJupxjvUQOnoRB9Glg8u/ow+OW/XEXQu7iDfJBGe nPt+vuoCh3NgPOMtJJXcvodfoW5Qpf6byJ/OnIlxv59/1JSof0m27d2yy5kDe55Gk1++ OydYLdlhNBU4qPgZ6h0j+PhK15p7Hcg9teSdDxaCY8yHZIOBX2KdFNNpUNUjD4dkUdOL FMRF9+uNJjAkC5KqERpyPEXAeN0lq1obT9EJd5y9/vadYYiiv0VBHEGDcPX6R5PS5QoJ sc3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b13si13198061ilq.35.2021.08.22.20.56.45; Sun, 22 Aug 2021 20:57:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233206AbhHWD5V (ORCPT + 99 others); Sun, 22 Aug 2021 23:57:21 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:15202 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232866AbhHWD5V (ORCPT ); Sun, 22 Aug 2021 23:57:21 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4GtJLt6YFzz1CZdD; Mon, 23 Aug 2021 11:56:06 +0800 (CST) Received: from dggema764-chm.china.huawei.com (10.1.198.206) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Mon, 23 Aug 2021 11:56:35 +0800 Received: from [10.174.185.179] (10.174.185.179) by dggema764-chm.china.huawei.com (10.1.198.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 23 Aug 2021 11:56:34 +0800 Subject: Re: [PATCH 1/2] bcma: Fix memory leak for internally-handled cores To: Kalle Valo CC: , , , , , References: <20210727025232.663-1-yuzenghui@huawei.com> <20210727025232.663-2-yuzenghui@huawei.com> <8943a493-aee8-3fe5-e63a-f3b61eaead14@huawei.com> <877dgfun7t.fsf@codeaurora.org> From: Zenghui Yu Message-ID: <2b218922-45b2-38cc-2a80-4d339949deed@huawei.com> Date: Mon, 23 Aug 2021 11:56:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <877dgfun7t.fsf@codeaurora.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.185.179] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggema764-chm.china.huawei.com (10.1.198.206) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2021/8/21 18:05, Kalle Valo wrote: > Zenghui Yu writes: > >> On 2021/7/27 10:52, Zenghui Yu wrote: >>> kmemleak reported that dev_name() of internally-handled cores were leaked >>> on driver unbinding. Let's use device_initialize() to take refcounts for >>> them and put_device() to properly free the related stuff. >> >> Could this be picked as a fix for v5.14 (_if_ it does fix something)? > > Why should this go to v5.14? Most probably it's too late for v5.14 > anyway. No worries. It's not urgent and just that I didn't realize we're already at rc7 now. The patch has been on the list for about 4 weeks and I'd appreciate any review comments from maintainers. Zenghui