Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp264908pxb; Wed, 25 Aug 2021 02:39:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxNGdnUGM9r0us2hYttRGBoMjNosFyxf+lOJMXWt/meWlaoYSW0z7SGByJAhvxaNaNhKCfA X-Received: by 2002:a17:906:4dc5:: with SMTP id f5mr5375401ejw.300.1629884397565; Wed, 25 Aug 2021 02:39:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629884397; cv=none; d=google.com; s=arc-20160816; b=fUwnaxoicBorS1jEiD4q0KkG38dddxibaauIw0khtf9auQ3qgZp6un2onO1Rx9KgV8 6gU+1G564oNv83YXIp3tgrg+K6rw+TCh2SqJ4Eic/TGrK3wVKU2KggYdBn53RQCEAQos +KgP12oFJm0yQ3Ht3KKQICln3YbbOmMIQct5IaAAVC0+FHH2inUms5Qv4QpOhO+0z7YQ D3PJqLW1lLxh9R5ezxNWwyxst+MDCj/qLbxWaqLqfw6k11NI5xqO0NQovMtarsk6yitv LYdpNhPB850Z+zSOtZ5hNn95hQWqYrEjLeG9upAwlLUs6Ak7bO0R5ph633a3lVIfhl/8 x/HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dmarc-filter:sender:dkim-signature; bh=LToob2D7NL3uAYpN1p00RN0zE7DkjwZQge5CWp/X5GI=; b=QBP+krsiPa9pMSwDRe9URN40yn+QqQJ2SuyhLghw7XgEYl4r6k3Flkif50Yj3YiYFH JmGOLfP/BAIkzoQEmc+SSbbqraNuoL37T+daa2oWkDZCVxgNZClnFBopbfqADjL8pcyc MrBN9Mn5RONiyuz2UR+vsmfmmzA2fL3YuhQRdrmwMRiHKh9hYSIRUNjueHOO96oaFuw9 KAst6a/8btf0MN6S8ND65rtMoG88K5Yyl+dMDtMpj+TvOl6z/r4jv3ZK+TTefFASMB3h xGVRXukr6zUVQW0cvaBE1loQPT2WdxuZJ+ef4LtIWus4K0dBLb+rLVt8NyXUyLAqK7FD fc2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=te7g8qej; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z19si21659229ejc.248.2021.08.25.02.39.34; Wed, 25 Aug 2021 02:39:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=te7g8qej; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239957AbhHYJkC (ORCPT + 99 others); Wed, 25 Aug 2021 05:40:02 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:29903 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239627AbhHYJj7 (ORCPT ); Wed, 25 Aug 2021 05:39:59 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1629884354; h=References: In-Reply-To: Message-Id: Date: Subject: Cc: To: From: Sender; bh=LToob2D7NL3uAYpN1p00RN0zE7DkjwZQge5CWp/X5GI=; b=te7g8qejMSO+sN0i/Z37+loxRY5G1hVlczNTwCcjSH0WzX81M+2A4ciEO9zjy2eIVTA7xV6j IGlXlVL1rKpCwckThmzoK7gCWWtvjfV+fqBOqLpylnET1tHgD8Uqs55zoyj4E53ainZW5EYE fnGhiRu7caUI2DhFAmbqft3MkoY= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 61260fc0fc1f4cb692330d97 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 25 Aug 2021 09:39:12 GMT Sender: ppranees=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D2B95C4360C; Wed, 25 Aug 2021 09:39:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from ppranees-linux.qualcomm.com (blr-c-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: ppranees) by smtp.codeaurora.org (Postfix) with ESMTPSA id 13624C43460; Wed, 25 Aug 2021 09:39:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 13624C43460 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: P Praneesh To: kvalo@codeaurora.org Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, P Praneesh , Sriram R , Jouni Malinen Subject: [PATCH v2 10/12] ath11k: avoid while loop in ring selection of tx completion interrupt Date: Wed, 25 Aug 2021 15:07:55 +0530 Message-Id: <1629884277-18759-11-git-send-email-ppranees@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1629884277-18759-1-git-send-email-ppranees@codeaurora.org> References: <1629884277-18759-1-git-send-email-ppranees@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Currently while loop is used to find the tx completion ring number and it is not required since the tx ring mask and the group id can be combined to directly fetch the ring number. Hence remove the while loop and directly get the ring number from tx mask and group id. Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-01734-QCAHKSWPL_SILICONZ-1 v2 Co-developed-by: Sriram R Signed-off-by: Sriram R Signed-off-by: Jouni Malinen Signed-off-by: P Praneesh --- drivers/net/wireless/ath/ath11k/dp.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/dp.c b/drivers/net/wireless/ath/ath11k/dp.c index e4fc2ba..a39cbc7 100644 --- a/drivers/net/wireless/ath/ath11k/dp.c +++ b/drivers/net/wireless/ath/ath11k/dp.c @@ -770,13 +770,12 @@ int ath11k_dp_service_srng(struct ath11k_base *ab, struct napi_struct *napi = &irq_grp->napi; int grp_id = irq_grp->grp_id; int work_done = 0; - int i = 0, j; + int i, j; int tot_work_done = 0; - while (ab->hw_params.ring_mask->tx[grp_id] >> i) { - if (ab->hw_params.ring_mask->tx[grp_id] & BIT(i)) - ath11k_dp_tx_completion_handler(ab, i); - i++; + if (ab->hw_params.ring_mask->tx[grp_id]) { + i = __fls(ab->hw_params.ring_mask->tx[grp_id]); + ath11k_dp_tx_completion_handler(ab, i); } if (ab->hw_params.ring_mask->rx_err[grp_id]) { -- 2.7.4