Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp745887pxb; Wed, 25 Aug 2021 14:06:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCK+TpEksx0yB60v1QqA9/D3mVarc3hb8dTcxz7XsupgCbQARfiprZP3oVS1UqbiDZgm3C X-Received: by 2002:a92:1812:: with SMTP id 18mr206113ily.83.1629925606980; Wed, 25 Aug 2021 14:06:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629925606; cv=none; d=google.com; s=arc-20160816; b=L8FAs6o9twwAJqHN9xeKQtJbVGViuvHYCombUVT8FVLO0D8NXXSAaACoVVJ8heJl4J tfXlYcl53BMdOUNchS4iPMKE4s2ldf6afd6JyyR54RvQvz3TcBdO+h7WFFXmEx5QzVdZ mdJDSN+s/NGltoXjN6pw/UgOGVySYeyGz3BBtbHTxa0uXsja1rH5VVWOyAic8+mLpSk7 R8mldgBsRmlayS/f30miIg1Ix6X5ItccoA2L1ALte+4TJSqWTyoBQ9d+6pe6HrhXeM6f EYfHniJEYQohmJxW492V38LyimY3ggrcpMajQzF2x3w7lK2nH6YC/JuATJ7sdSV+5ktm hl5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=MM9TxT9aun9DoTvxLwFQ9t7L9RLMum6d40huNFPUugw=; b=SOC2T+CJ1LveHN36RTb8s2GrA2E1vD8znBqzHjnewvMjSacAIaGdHeEOapm4jkh9Ny G2r8CH2sXv0KWy8q/JotZFPEOeL5KfMt7ToMy0+1TXcbjWTwi+HblOx126NP/g49gK5F 2kX9H+7gKoFFvJFzq+SdG+zw1t119RnCGedLh3CIN20TA37jpT8iSHTo5mGn5MsRD/Bj 6Nxs7k6xdMzmZKswQTRfqCZP4MnUlyj+DowjcUyOXOqkwGMdEUHVFvWSZvbzeuBDPxvB woGOSmjM9VNOKeKHOfUjc/p5KazF4CPUU0WjZ6GCCYLrQxKFRJJvHAIvEvuLxJHX2RE2 e+1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@eero.com header.s=google header.b=YtDBuQZQ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=eero.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z14si836542ilq.148.2021.08.25.14.06.35; Wed, 25 Aug 2021 14:06:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@eero.com header.s=google header.b=YtDBuQZQ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=eero.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241849AbhHYSqq (ORCPT + 99 others); Wed, 25 Aug 2021 14:46:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241704AbhHYSqo (ORCPT ); Wed, 25 Aug 2021 14:46:44 -0400 Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DE18C061757 for ; Wed, 25 Aug 2021 11:45:58 -0700 (PDT) Received: by mail-qk1-x734.google.com with SMTP id b64so614560qkg.0 for ; Wed, 25 Aug 2021 11:45:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eero.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=MM9TxT9aun9DoTvxLwFQ9t7L9RLMum6d40huNFPUugw=; b=YtDBuQZQpIl2+VpA7woAuOMDzBS5iPSCoECtEM+xTD0Bc6+05goxarFy4Z1WMQeKO+ N62fcGSPe6ibgyLLzBkzw9mJ3bDb5l/V6twafYW1CrtHrUZoSpSrXj386RVxebBdfZ0+ TXNJekS3TrnOE95UkySThRss6jxiSZIY3lwWI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=MM9TxT9aun9DoTvxLwFQ9t7L9RLMum6d40huNFPUugw=; b=lJc7GOnzN7rvq69wOtBRWt4vgkml1c0wy9OBrT+3BvnHE6MFARwOS+dgWnUybdASQ1 sFM0Hx4hrnr66rmexQkmBjF358GESg3jhLoCuj/5tlfhzj0ZTTaBQPvvfUn8kBUkJVZf 8qZoyYDgchxc21AKKPoLW0pOTx9DBKA8YMsem/quJL+M5PH2OsA3b2GOGpAItx0SGn6M qDx2zKNRnSZ/TA/8rZGbVughcs5SjcNZZtrxIWHOG5gc6WBvEz82Wwp+kRWiPA9f2bLN 9LwPTvlgVSljFfC50R9Wk4G49yYiE3+W3ixMj1YA1i/dydsLJaw6bxwBhBJhhkgeiubj g3Kg== X-Gm-Message-State: AOAM5318oJv2aBjSbIQChr8YMCcGHosih2D07QfAwVxIjpl11oRnv22r Af9UqxCFV2gMpn/iQmbso9nHDA== X-Received: by 2002:a37:8242:: with SMTP id e63mr32745206qkd.294.1629917157522; Wed, 25 Aug 2021 11:45:57 -0700 (PDT) Received: from ?IPv6:2600:1700:38c5:675f:d171:ff55:3554:62a5? ([2600:1700:38c5:675f:d171:ff55:3554:62a5]) by smtp.gmail.com with ESMTPSA id s69sm594493qka.102.2021.08.25.11.45.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Aug 2021 11:45:56 -0700 (PDT) Subject: Re: [PATCH v2 02/12] ath11k: allocate dst ring descriptors from cacheable memory To: P Praneesh , kvalo@codeaurora.org Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, Pradeep Kumar Chitrapu , Sriram R , Jouni Malinen References: <1629884277-18759-1-git-send-email-ppranees@codeaurora.org> <1629884277-18759-3-git-send-email-ppranees@codeaurora.org> From: Peter Oh Message-ID: Date: Wed, 25 Aug 2021 11:45:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1629884277-18759-3-git-send-email-ppranees@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 8/25/21 2:37 AM, P Praneesh wrote: > @@ -292,6 +315,11 @@ int ath11k_dp_srng_setup(struct ath11k_base *ab, struct dp_srng *ring, > return -EINVAL; > } > > + if (cached && ab->hw_params.alloc_cacheable_memory) { > + params.flags |= HAL_SRNG_FLAGS_CACHED; > + ring->cached = 1; > + } "&& ab->hw_params.alloc_cacheable_memory" is redundant check. Thanks, Peter