Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org D9B0AC43460
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, wcn36xx@lists.infradead.org,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Stephan Gerhold <stephan@gerhold.net>,
        Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
        =?utf-8?B?QW7DrWJhbCBM?= =?utf-8?B?aW3Ds24=?= 
        <anibal.limon@linaro.org>
Subject: Re: [RESEND PATCH] wcn36xx: Allow firmware name to be overridden by DT
References: <20210824171225.686683-1-bjorn.andersson@linaro.org>
Date:   Fri, 27 Aug 2021 15:53:04 +0300
In-Reply-To: <20210824171225.686683-1-bjorn.andersson@linaro.org> (Bjorn
        Andersson's message of "Tue, 24 Aug 2021 10:12:25 -0700")
Message-ID: <87fsuv59sf.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Bjorn Andersson <bjorn.andersson@linaro.org> writes:

> The WLAN NV firmware blob differs between platforms, and possibly
> devices, so add support in the wcn36xx driver for reading the path of
> this file from DT in order to allow these files to live in a generic
> file system (or linux-firmware).
>
> For some reason the parent (wcnss_ctrl) also needs to upload this blob,
> so rather than specifying the same information in both nodes wcn36xx
> reads the string from the parent's of_node.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Tested-by: An=C3=ADbal Lim=C3=B3n <anibal.limon@linaro.org>

[...]

> --- a/drivers/net/wireless/ath/wcn36xx/main.c
> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> @@ -1500,6 +1500,13 @@ static int wcn36xx_probe(struct platform_device *p=
dev)
>  		goto out_wq;
>  	}
>=20=20
> +	wcn->nv_file =3D WLAN_NV_FILE;
> +	ret =3D of_property_read_string(wcn->dev->parent->of_node, "firmware-na=
me", &wcn->nv_file);
> +	if (ret < 0 && ret !=3D -EINVAL) {
> +		wcn36xx_err("failed to read \"firmware-name\" property\n");

I included the value of ret to the error print to ease debugging.
Modified patch is soon in the pending branch, please take a look.

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes