Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org A0348C4338F
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] ath9k: fix sleeping in atomic context
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <1628481916-15030-1-git-send-email-miaoqing@codeaurora.org>
References: <1628481916-15030-1-git-send-email-miaoqing@codeaurora.org>
To:     Miaoqing Pan <miaoqing@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org, ath9k-devel@qca.qualcomm.com,
        dan.carpenter@oracle.com, linux-gpio@vger.kernel.org,
        Miaoqing Pan <miaoqing@codeaurora.org>
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-Id: <20210829071241.B0FA5C43460@smtp.codeaurora.org>
Date:   Sun, 29 Aug 2021 07:12:41 +0000 (UTC)
Precedence: bulk

Miaoqing Pan <miaoqing@codeaurora.org> wrote:

> The problem is that gpio_free() can sleep and the cfg_soc() can be
> called with spinlocks held. One problematic call tree is:
> 
> --> ath_reset_internal() takes &sc->sc_pcu_lock spin lock
>    --> ath9k_hw_reset()
>       --> ath9k_hw_gpio_request_in()
>          --> ath9k_hw_gpio_request()
>             --> ath9k_hw_gpio_cfg_soc()
> 
> Remove gpio_free(), use error message instead, so we should make sure
> there is no GPIO conflict.
> 
> Also remove ath9k_hw_gpio_free() from ath9k_hw_apply_gpio_override(),
> as gpio_mask will never be set for SOC chips.
> 
> Signed-off-by: Miaoqing Pan <miaoqing@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

7c48662b9d56 ath9k: fix sleeping in atomic context

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/1628481916-15030-1-git-send-email-miaoqing@codeaurora.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches