Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp3033353pxb; Sun, 29 Aug 2021 11:05:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMI2cPJzrYrQwU1COCR26ija56188T8juCdR/0IPtb57Jx0e/+tgjja91f/CPFLrhQ1bX5 X-Received: by 2002:a05:6402:2708:: with SMTP id y8mr20549952edd.84.1630260348025; Sun, 29 Aug 2021 11:05:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630260348; cv=none; d=google.com; s=arc-20160816; b=Ncek9pdFIfc/W7cr1pSm2WhDTyoj4I+5H9OWUpAsiXB3RISAazehp6uTUYbTuL5R4W /3D7H2kvSPqyTtNCttVd9tteWOQMziwNpbRhZ+0hOtq+rJGJW2yUW0bxhKFy38cBRSqE F50NqZ+RrlkFrbtQbA3et50hCMrpmTtpltknhBFHXqEnREer+fJ/1ZyLT0MgTbyJz9X5 +yi7FXE09eq+njeyqV8SkERR7FfYUWsHTZQ12IWls7nJniFJ9euIyonDQeTyQ6/OivHh Mmg6BxP+n82A/ZrMtHzlutgXxVh1Bdri0QD/k3vfD9BHIzqe4s90y+8miP2gZNy4DgU8 S7JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=5xRSsNwOwnDTizm0g7YvHUz989lGjI0HmFERSykg4No=; b=dwdKaWDLH6IBn4fFsoZScwBzNHssuDi3ZdLXEGCGvfSlTdd6Z1K22TGWHW+2NaoBta cWu3jVAMn8Bw3NayPK/83KKuEl2cujM8g0et8EYSjZPl/dXx24VJBmJaHFvhSzwru0z1 jtM+eBPXyPMnQlN2Jfk1b5cEnxbkMFBSItPU6AxHzmW9Z1MFSpLOvHcvQ37A06LM63BY 53nSw7VcENexwfkVEmiw6xEmSXO611/NSLL4SKmwxcylNCGwFMkoGosQYhBv8yaOm61P nOBJuNhsUXBsBFQfbwud7mSiCtSa6NI9QJTKBdsU/0yK/av+fSy0Jy8bQjJRDz//Xd09 9ryg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b="icGu6xT/"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e1si5262332edq.486.2021.08.29.11.05.14; Sun, 29 Aug 2021 11:05:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b="icGu6xT/"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235044AbhH2SGD (ORCPT + 99 others); Sun, 29 Aug 2021 14:06:03 -0400 Received: from smtp-relay-canonical-1.canonical.com ([185.125.188.121]:53932 "EHLO smtp-relay-canonical-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230010AbhH2SGA (ORCPT ); Sun, 29 Aug 2021 14:06:00 -0400 Received: from localhost (1.general.cking.uk.vpn [10.172.193.212]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 51ABC3F101; Sun, 29 Aug 2021 18:05:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1630260306; bh=5xRSsNwOwnDTizm0g7YvHUz989lGjI0HmFERSykg4No=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=icGu6xT/3v5EVTU5eqCoiS/SUT+GBzzk8C4C9vrqV61fCfSUuUGGYZnyuqjGXIXAa 4ZRGqPTwazDTaFZy1rGaSRECho8HDeHCu2RuyjgrzI69ai6oME51A+l2rgNUhseVHi rnNgiYgJ/zorLayPh/KZcnBida0W/Sld/xz8xm1qBXNpDYbIFj6em5lEyXmnUHYNY8 ZurntEBcQjn9D/ipmZjUlJ1fV6RXqEzyYuFn+fF7rXoTqpENEun7YCB93e+lRCvs6l g//5nexOWoZXT5YYRQhHU5f5/84ExrlUqsf6J/BH+20dBbGToMErhg7RJKHTSfBsrB irryICpIp5aLQ== From: Colin King To: Ping-Ke Shih , Kalle Valo , "David S . Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] rtlwifi: rtl8192de: Fix uninitialized variable place Date: Sun, 29 Aug 2021 19:05:03 +0100 Message-Id: <20210829180503.533934-1-colin.king@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Colin Ian King In the case where chnl <= 14 variable place is not initialized and the function returns an uninitialized value. This fixes an earlier cleanup where I introduced this bug. My bad. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: 369956ae5720 ("rtlwifi: rtl8192de: Remove redundant variable initializations") Signed-off-by: Colin Ian King --- drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c index 8ae69d914312..b32fa7a75f17 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c @@ -896,7 +896,7 @@ static void _rtl92d_ccxpower_index_check(struct ieee80211_hw *hw, static u8 _rtl92c_phy_get_rightchnlplace(u8 chnl) { - u8 place; + u8 place = chnl; if (chnl > 14) { for (place = 14; place < sizeof(channel5g); place++) { -- 2.32.0