Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] kconfig: forbid symbols that end with '_MODULE'
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Kalle Valo <kvalo@codeaurora.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Luca Coelho <luciano.coelho@intel.com>,
        Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
        ALSA Development Mailing List <alsa-devel@alsa-project.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-wireless@vger.kernel.org, Networking <netdev@vger.kernel.org>
References: <20210825041637.365171-1-masahiroy@kernel.org>
 <9df591f6-53fc-4567-8758-0eb1be4eade5@gmail.com>
 <CAK7LNATDMzR1DnwwAcQFHaKZeGVYDZ1oDKL-QOe_7DaB_yByAA@mail.gmail.com>
From:   =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= <peter.ujfalusi@gmail.com>
Message-ID: <d9e777dc-d274-92ee-4d77-711bfd553611@gmail.com>
Date:   Wed, 1 Sep 2021 10:07:57 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <CAK7LNATDMzR1DnwwAcQFHaKZeGVYDZ1oDKL-QOe_7DaB_yByAA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 26/08/2021 05:28, Masahiro Yamada wrote:
> On Wed, Aug 25, 2021 at 8:59 PM Péter Ujfalusi <peter.ujfalusi@gmail.com> wrote:

...

>>> diff --git a/sound/soc/ti/Kconfig b/sound/soc/ti/Kconfig
>>> index 698d7bc84dcf..c56a5789056f 100644
>>> --- a/sound/soc/ti/Kconfig
>>> +++ b/sound/soc/ti/Kconfig
>>> @@ -211,7 +211,7 @@ config SND_SOC_DM365_VOICE_CODEC
>>>         Say Y if you want to add support for SoC On-chip voice codec
>>>  endchoice
>>>
>>> -config SND_SOC_DM365_VOICE_CODEC_MODULE
>>> +config SND_SOC_DM365_VOICE_CODEC_MODULAR
>>
>> This Kconfig option is only used to select the codecs needed for the
>> voice mode, I think it would be better to use something like
>>
>> SND_SOC_DM365_SELECT_VOICE_CODECS ?
> 
> I do not have a strong opinion.
> I am fine with any name unless it ends with _MODULE.
> 
> 
> The sound subsystem maintainers and Arnd,
> author of 147162f575152db800 are CC'ed.
> 
> If they suggest a better name, I'd be happy to adopt it.
> 

Can you resend (a separate patch would be even better) with
SND_SOC_DM365_SELECT_VOICE_CODECS

for sound/soc/ti/Kconfig ?

Thank you,
Péter