Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] p54: Remove obsolete comment
To:     Wan Jiabing <wanjiabing@vivo.com>,
        Christian Lamparter <chunkeey@googlemail.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net
References: <20210901024744.7013-1-wanjiabing@vivo.com>
From:   Christian Lamparter <chunkeey@gmail.com>
Message-ID: <1ac57e49-30e0-3ca1-c324-3aea2aec598b@gmail.com>
Date:   Wed, 1 Sep 2021 19:40:00 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20210901024744.7013-1-wanjiabing@vivo.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 01/09/2021 04:47, Wan Jiabing wrote:
> In commit d249ff28b1d8 ("intersil: remove obsolete prism54 wireless driver"),
> prism54/isl_oid.h is deleted. The comment here is obsolete.
> 
Instead of removing said "obsolete" comment, why not copy the
excellent comment about that "frameburst technology" from the
prism54/isl_oid.h file there?

Cheers,
Christian


> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>   drivers/net/wireless/intersil/p54/fwio.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/intersil/p54/fwio.c b/drivers/net/wireless/intersil/p54/fwio.c
> index bece14e4ff0d..1fe072de3e63 100644
> --- a/drivers/net/wireless/intersil/p54/fwio.c
> +++ b/drivers/net/wireless/intersil/p54/fwio.c
> @@ -583,7 +583,6 @@ int p54_set_edcf(struct p54_common *priv)
>   	rtd = 3 * priv->coverage_class;
>   	edcf->slottime += rtd;
>   	edcf->round_trip_delay = cpu_to_le16(rtd);
> -	/* (see prism54/isl_oid.h for further details) */
>   	edcf->frameburst = cpu_to_le16(0);
>   	edcf->flags = 0;
>   	memset(edcf->mapping, 0, sizeof(edcf->mapping));
>