Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp82322pxb; Wed, 1 Sep 2021 22:36:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzq3Qeu7kZV5F/wGrCqVrX6NB6zsWCO/qfQ3mbat2i4ZsP+kC45nxGhklKV/Y1j58gx86bA X-Received: by 2002:a92:cb0f:: with SMTP id s15mr1048228ilo.59.1630560966114; Wed, 01 Sep 2021 22:36:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630560966; cv=none; d=google.com; s=arc-20160816; b=f1j8L6NT6pP7Oq5GsdIlwbV1MoZbIDkrRAY0dJZZrlkqWQCBArMZZ+ltM6y+HIiuZK x/tlTja/9P1Sru/LX3Zs3A/xaoy+rXbFT2RlRkzCrg2wOytVKPy6+cWkt8EaMMjr8eov NIqAIkDqHSqbSYEqu8yMz4h9sGZ2cjYdgkRAJIrkWwrl9/Lgwjd7GkRxrZ4JdgOH5PiP H5cPP0K5L1HEtSyX3n3XDlfUw7iOxa1SaMeuDsmzfffEbr+qgTa2PDZkS2Q5vJCRFbo5 +V8o+zE4VHizz1ADCXnB4AO7k0p6DH/UW1YujAh9p49mwp3mcLudFj68kQlPDihYcd1F yjCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dmarc-filter:sender:dkim-signature; bh=T1FfOP3ic/z5mywSoym5oIFae8vGz94xWFL8jTo5154=; b=ERnGlW2ajBVuyprAXea6bxX23a1rQheYhPOdTn2jRQT6VUKH6IJUi5vEnQO4bao3JJ ULBTBXeiTLdRdSqCr5Y6alwYRQGB9U9GOrE0mB6LV/bvPTn66jQm9pWa1xEzuPuUQxkG gyOcKNwB5HIjW2leMh1dHHUhfmj5rFLAwsc8P0mPz3asCpDJyspGNv8c0p1R3cBNmSOr p72Wld1EM3Aa5XIa97VSCe2Owb1MsBZ23Q9wVva9cRvYh81w9k5h87zCO5W3eklEZjMx 0CPWI8CZyXR4AW4hdbtUQoOVrl0Os2ENcjcCF+qrYI05nPztJyS04UU1PGM3I3US0MyG k03w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=Cn2d8FB8; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y8si868249ior.35.2021.09.01.22.35.55; Wed, 01 Sep 2021 22:36:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=Cn2d8FB8; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231420AbhIBFgG (ORCPT + 99 others); Thu, 2 Sep 2021 01:36:06 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:57414 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231756AbhIBFgF (ORCPT ); Thu, 2 Sep 2021 01:36:05 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1630560907; h=References: In-Reply-To: Message-Id: Date: Subject: Cc: To: From: Sender; bh=T1FfOP3ic/z5mywSoym5oIFae8vGz94xWFL8jTo5154=; b=Cn2d8FB8LOGvkd/8u+shdp4GHLwZV1d/UN+PMqVx9jOnSNFF2yHrhne/oXIXeRs/Ni52NE1D NsId8cMJHhSyTwdDrhgWyHKuezt/Gzkjke7YTYrLc/noQDlvJ0Ls2kGWjK9be3YwTuRZaU2i DDffn5rFXXE/hiTkwOtC/6Hi7zE= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 6130628b89cdb620613e62a1 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 02 Sep 2021 05:35:07 GMT Sender: ppranees=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 271E3C4338F; Thu, 2 Sep 2021 05:35:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from ppranees-linux.qualcomm.com (blr-c-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: ppranees) by smtp.codeaurora.org (Postfix) with ESMTPSA id A0901C4361A; Thu, 2 Sep 2021 05:35:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org A0901C4361A Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: P Praneesh To: kvalo@codeaurora.org Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, P Praneesh , Sriram R , Jouni Malinen Subject: [PATCH v3 10/12] ath11k: avoid while loop in ring selection of tx completion interrupt Date: Thu, 2 Sep 2021 11:03:38 +0530 Message-Id: <1630560820-21905-11-git-send-email-ppranees@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1630560820-21905-1-git-send-email-ppranees@codeaurora.org> References: <1630560820-21905-1-git-send-email-ppranees@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Currently while loop is used to find the tx completion ring number and it is not required since the tx ring mask and the group id can be combined to directly fetch the ring number. Hence remove the while loop and directly get the ring number from tx mask and group id. Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-01734-QCAHKSWPL_SILICONZ-1 v2 Co-developed-by: Sriram R Signed-off-by: Sriram R Signed-off-by: Jouni Malinen Signed-off-by: P Praneesh --- drivers/net/wireless/ath/ath11k/dp.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/dp.c b/drivers/net/wireless/ath/ath11k/dp.c index 0278ff6..d553692 100644 --- a/drivers/net/wireless/ath/ath11k/dp.c +++ b/drivers/net/wireless/ath/ath11k/dp.c @@ -770,13 +770,12 @@ int ath11k_dp_service_srng(struct ath11k_base *ab, struct napi_struct *napi = &irq_grp->napi; int grp_id = irq_grp->grp_id; int work_done = 0; - int i = 0, j; + int i, j; int tot_work_done = 0; - while (ab->hw_params.ring_mask->tx[grp_id] >> i) { - if (ab->hw_params.ring_mask->tx[grp_id] & BIT(i)) - ath11k_dp_tx_completion_handler(ab, i); - i++; + if (ab->hw_params.ring_mask->tx[grp_id]) { + i = __fls(ab->hw_params.ring_mask->tx[grp_id]); + ath11k_dp_tx_completion_handler(ab, i); } if (ab->hw_params.ring_mask->rx_err[grp_id]) { -- 2.7.4