Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Peer, Ilan" <ilan.peer@intel.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
CC:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "Coelho, Luciano" <luciano.coelho@intel.com>
Subject: RE: [bug report] iwlwifi: mvm: Explicitly stop session protection
 before unbinding
Thread-Topic: [bug report] iwlwifi: mvm: Explicitly stop session protection
 before unbinding
Thread-Index: AQHXnjvyHBHrb2NRPk2mZQQclafsHauVIzxA
Date:   Sun, 5 Sep 2021 08:28:24 +0000
Message-ID: <BN7PR11MB261058ACB7D2ACD53B69D8DBE9D19@BN7PR11MB2610.namprd11.prod.outlook.com>
References: <20210831074305.GA11178@kili>
In-Reply-To: <20210831074305.GA11178@kili>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6HVKUSefvRTXibrI7RajxkCcgDFIrbXmR/jPIQeNVLj72goAxdWsAULEVH/a?=
 =?us-ascii?Q?97vG4dykdXTieQWo7szXPfcOPs+cYoFLVvdCmU/4i5Y/yDCEJnNbeOyozCn1?=
 =?us-ascii?Q?fmMPJ4NUeGz1QZYN/969s0hx+sKez+y4k/zz5fQt54iMIqXLBHVvn3F7qGxF?=
 =?us-ascii?Q?G5GjEKns6QraqeyjZkiOflU4n/7US/CZseXC8tUZdY06gADFJkibDqrFtENs?=
 =?us-ascii?Q?FIdEZ8l0yABPFCMPe3eHIlws2MYrWAgRfwwXEMQRcRKShs5mVf4FC85fL/U5?=
 =?us-ascii?Q?aqggJVnvhuOL0CdX+JX68y/3Afwz8aB8yiePrLIYu9rav/vGI6jdEXKCOYAf?=
 =?us-ascii?Q?TsQH39oVa+j+BIZEjb8WNkdXM3L9do8ixb+pV4FuPqogZchb3gXj35B15LeC?=
 =?us-ascii?Q?AEMESKI5tZaUzWJZ9t/zNKhMeZ+0y8374LwtAl9EPz5fj3FTgu6ZXRDfuhy9?=
 =?us-ascii?Q?BLr4E/OZbX2QzzPs/H8ydK/CRxkoEdKSk0eUvm1FlFGIVJW8wYeBW5g6get8?=
 =?us-ascii?Q?B0FEDOYjup6DCJ0r86fi4Rva9lCi3VredDubwnn1DOUrC8xdL5CM2XoG7XrW?=
 =?us-ascii?Q?4Z+3fQtd7MKTrWnMi011w2g/kfbAtQYgHKv9H9lQeEsZ2XjHxA8bIl3sSkkA?=
 =?us-ascii?Q?56jOTGDENlYD7HZd76teujoT7t0/W9oBNgNPO+RKVNFdOznsG/sGh1fU007n?=
 =?us-ascii?Q?Ym5AtQNniEpH311hPiaFuoMsjbbKlr5Egg1KzkaknExg3zKJ3U9CDg26vUnm?=
 =?us-ascii?Q?9SiOqR4CVRLSBJjDaUC5j3KjqrgbFsllO8XQLdJOPDnuOuaN4ohoJWw6wD1z?=
 =?us-ascii?Q?8E4ZlNQ94SsMj048NIM8FFVsF8CAEJFjec9s39iNKpEsMShvcIF6gf9KelmV?=
 =?us-ascii?Q?JG4/4RTcrn+9p375uvq2tOhkNHCIWn9RHCNPoCKKzyZRggiqEe24ScYs8wIu?=
 =?us-ascii?Q?op94xfbp36dr8m1eYW9S72hv7AOp/VI8NECE9I1DUkhTsxv2oisPokHV+Opn?=
 =?us-ascii?Q?GQ9fhUyyKnkUx94bAaEBDm6krBPxxTrGdlynStQWzFEq6R4tSPwVl4HjFDgr?=
 =?us-ascii?Q?M6JRGGYnAJSTxNf6u8EBQkyC4IYbj+Sca+wXjyPofWnE83ic13KK8v3/bxGm?=
 =?us-ascii?Q?BQQTzHdvTjVpV8jyZUILVanr8bT8dpomNQHaEpXCACzesY05v6VAmqWEmMM3?=
 =?us-ascii?Q?RJKmYtoxEqmlPzAlrD5hthDZw45NIyqFzwSlg/ngibYVmdGnc5+WPQQ13hxB?=
 =?us-ascii?Q?V6y+IivfD6vV1ORtShx2nwVNQRfbQvqDBeXlB1YSX4BOSMAt7nUd64hLsH3l?=
 =?us-ascii?Q?hiKcyah/WZS8tVGrJX7X5dSZ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN7PR11MB2610.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 29728597-d3e4-4cf2-fc35-08d9704720b9
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2021 08:28:24.2395
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CddyoXn/9T6Ynnx8RtYat8mqChRaJy+POq4mln8wCP5tlImI4gw3WlN68g4Az7wUJ6DhahKI995IX6+fYfzU6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3650
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Hi Dan,

I'll prepare a fix for this.

Thanks,

Ilan.

> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Sent: Tuesday, August 31, 2021 10:43
> To: Peer, Ilan <ilan.peer@intel.com>
> Cc: linux-wireless@vger.kernel.org
> Subject: [bug report] iwlwifi: mvm: Explicitly stop session protection be=
fore
> unbinding
>=20
> Hello Ilan Peer,
>=20
> This is a semi-automatic email about new static checker warnings.
>=20
> The patch 7b3954a1d69a: "iwlwifi: mvm: Explicitly stop session protection
> before unbinding" from Jun 18, 2021, leads to the following Smatch
> complaint:
>=20
>     drivers/net/wireless/intel/iwlwifi/mvm/time-event.c:668
> __iwl_mvm_remove_time_event()
>     warn: variable dereferenced before check 'te_data->vif' (see line 665=
)
>=20
> drivers/net/wireless/intel/iwlwifi/mvm/time-event.c
>    664		u32 id;
>    665		struct iwl_mvm_vif *mvmvif =3D
> iwl_mvm_vif_from_mac80211(te_data->vif);
>                                                                        ^^=
^^^^^^^^^^ This is dereferenced
> inside the function.
>=20
>    666		enum nl80211_iftype iftype;
>    667
>    668		if (!te_data->vif)
>                     ^^^^^^^^^^^^^
> The new patch adds a check for NULL, but I don't think it is required.
> The kernel would have already crashed at this point at any rate so the
> dereference needs to be moved.
>=20
>    669			return false;
>    670
>    671          iftype =3D te_data->vif->type;
>    672
>    673          /*
>    674           * It is possible that by the time we got to this point t=
he time
>    675           * event was already removed.
>=20
>=20
> regards,
> dan carpenter