Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <dbb767a306983d59beb68cb6249cd089805bb5e8.camel@mediatek.com>
Subject: Re: [PATCH v3 8/8] mt76: mt7915: set muru platform type
From:   Ryder Lee <ryder.lee@mediatek.com>
To:     Shayne Chen <shayne.chen@mediatek.com>,
        Felix Fietkau <nbd@nbd.name>
CC:     linux-wireless <linux-wireless@vger.kernel.org>,
        Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        linux-mediatek <linux-mediatek@lists.infradead.org>
Date:   Thu, 9 Sep 2021 02:55:26 +0800
In-Reply-To: <20210908094144.25641-8-shayne.chen@mediatek.com>
References: <20210908094144.25641-1-shayne.chen@mediatek.com>
         <20210908094144.25641-8-shayne.chen@mediatek.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2021-09-08 at 17:41 +0800, Shayne Chen wrote:
> Set muru platform type by mcu cmd to notify fw to init corresponding
> algorithm.
> 
> Suggested-by: Money Wang <money.wang@mediatek.com>
> Reviewed-by: Ryder Lee <ryder.lee@mediatek.com>
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> ---
> v3: - fix endianess
>     - rework muru ctrl function
> ---
>  drivers/net/wireless/mediatek/mt76/mt7915/mcu.c | 17
> +++++++++++++++++
>  drivers/net/wireless/mediatek/mt76/mt7915/mcu.h |  5 +++++
>  .../net/wireless/mediatek/mt76/mt7915/mt7915.h  |  1 +
>  .../wireless/mediatek/mt76/mt7915/testmode.c    | 16 +++++--------
> ---
>  .../wireless/mediatek/mt76/mt7915/testmode.h    |  4 ----
>  5 files changed, 28 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
> b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
> index 229ba3c469d1..afafc47264cd 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
> @@ -2949,6 +2949,21 @@ static int mt7915_mcu_set_mwds(struct
> mt7915_dev *dev, bool enabled)
>  				 sizeof(req), false);
>  }
>  
> +int mt7915_mcu_set_muru_ctrl(struct mt7915_dev *dev, u32 cmd, u8
> *val)
> +{
> +	struct {
> +		__le32 cmd;
> +		u8 val[4];
> +	} __packed req = {
> +		.cmd = cpu_to_le32(cmd),
> +	};
> +
> +	memcpy(req.val, val, sizeof(req.val));

Will this lead to undefined behavior if memcpy size larger than source?
what about passing u32 and using put_unaligned_le32?

Ryder