Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 9 Sep 2021 10:10:16 +0200
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Felix Fietkau <nbd@nbd.name>
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mt76: mt7915: fix WMM index on DBDC cards
Message-ID: <YTnBaNe0jA+rFUV+@lore-desk>
References: <20210908155841.72052-1-nbd@nbd.name>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="fvK8rWg3jjBJdNxY"
Content-Disposition: inline
In-Reply-To: <20210908155841.72052-1-nbd@nbd.name>
Precedence: bulk


--fvK8rWg3jjBJdNxY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> WMM index range needs to be split between both PHYs if a second PHY exist=
s.
> The condition for that was accidentally written as checking if the vif PHY
> is the secondary one

We need to add the following Fixes tag here:

Fixes: e57b7901469fc ("mt76: add mac80211 driver for MT7915 PCIe-based chip=
sets")

Regards,
Lorenzo

>=20
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> ---
>  drivers/net/wireless/mediatek/mt76/mt7915/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/main.c b/drivers/n=
et/wireless/mediatek/mt76/mt7915/main.c
> index 748ea70ea12e..a19e68668c65 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/main.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
> @@ -215,7 +215,7 @@ static int mt7915_add_interface(struct ieee80211_hw *=
hw,
>  	mvif->phy =3D phy;
>  	mvif->band_idx =3D ext_phy;
> =20
> -	if (ext_phy)
> +	if (dev->mt76.phy2)
>  		mvif->wmm_idx =3D ext_phy * (MT7915_MAX_WMM_SETS / 2) +
>  				mvif->idx % (MT7915_MAX_WMM_SETS / 2);
>  	else
> --=20
> 2.30.1
>=20

--fvK8rWg3jjBJdNxY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYTnBZQAKCRA6cBh0uS2t
rIXtAQC9R+bE7bb8rxTT8GHQb9luGsyYm0fDvBsHqe/73+Y+mwEAvbDZZsUuou1c
E4rRIH5tw1M792VZCaHdQGxkYL7sygU=
=Vv4k
-----END PGP SIGNATURE-----

--fvK8rWg3jjBJdNxY--