Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp627177pxb; Thu, 9 Sep 2021 08:30:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzpCjpPKdw4N1yODd7ZC2xyzm/Nm4UnlciU7d28MfWNq73fdEkrQ3/N/rnvHmP2vN7fT2/a X-Received: by 2002:a17:906:d04b:: with SMTP id bo11mr3831012ejb.513.1631201406946; Thu, 09 Sep 2021 08:30:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631201406; cv=none; d=google.com; s=arc-20160816; b=ItowUqrdIc5V2C5afEzrVcWfFavUgTdz8/zI+ZbqCKJT6gQToVwSnUP2N0nheIOa0r 9XbAEt3a4G4QASgh2LlreSfUtTANFTqHpAUdOiNIWS4vQsSTC2qUv9+hgkQmJtHr1fg1 ncr6VeE2OfQTE2QeDlK///wkJSr1hI2PULSwtqX0wX4xPnD1193JXMEFbyuWOJU+lfyQ 0LftPaJoFE/bPwjWFYxuXsj8bt7mmi6oMp8JF/HazOv1CHwfDLSASDO22ChczRNxPaPJ vVKKs6hFZh1nEX4S4KHD9e3KhTLQkFUDlPjyIHe0CplM183hmWZOKcTdu+jiM9aFRNbY PIaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=M9mh1yFONu1+KVZ1hcIpEXDWxwA0zNLhb3EzEa4tpuY=; b=n+qv741/h9EADEadtz+yDHwrWuU03uVGWRxXpwGe8PmJr0uNzEq+7fyMDU98yFCBlI nVihfoqw5ZwXSryh81oaLPz+p82osSeRlo7Cl2lqoRdWKcdqzm/DPRfexJ79xXQqaDje xhs0Z8h79+8tKOd9ZTOA9ltZYwTBI4Vg2A33eAhq64norzWQ6Ds1sx+AFH3vGA2GEAgs trPrcbc6iuldL6h0h9pW5AvhsLQ763c2oHA7vNmOzwOR1SHAxAwC88GnBPRBbKOyuCgT Y6iDWSW8oQYyJqRSrmSg817gdqoGzjbLoHkct1w6oqyjqoMPTu+b8Bm6JqW7NjneLuNs wH4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VAjl3a2N; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s13si2127466edh.555.2021.09.09.08.29.43; Thu, 09 Sep 2021 08:30:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VAjl3a2N; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234162AbhIIPaq (ORCPT + 99 others); Thu, 9 Sep 2021 11:30:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232359AbhIIPap (ORCPT ); Thu, 9 Sep 2021 11:30:45 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1ED67C061574 for ; Thu, 9 Sep 2021 08:29:36 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id m21-20020a17090a859500b00197688449c4so1738617pjn.0 for ; Thu, 09 Sep 2021 08:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M9mh1yFONu1+KVZ1hcIpEXDWxwA0zNLhb3EzEa4tpuY=; b=VAjl3a2NIx0JFixcvIf4Eum9SOuxOmtmTgG/94E0bZlG+P5lHYMmwD5lIptQRTZFVJ 3svcL23YIuCy+JgGVhnScgMacB/xADWhajHZ4pnzgByeRX73KwdA2df8YJodzC26z7ln ZzZyTnvm91b/o2IeI0SkDULEpzI3iDMhSJmksni9Hw8x6+p4OrR3GX0QeM53d64UG2/j LklJT4GOQFnBpz71BZ53j7vGwKl7XctAPTcfJml7bbMD6KMyox5znrntjJRi+rJcX2wr 691qdJtmwyLakOGpfYE1TcbxKgLxWb3Lkov60q0SygbHoLYG3pko72Fzz7YAInuO7mgq pm7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M9mh1yFONu1+KVZ1hcIpEXDWxwA0zNLhb3EzEa4tpuY=; b=sWaNp4VMRlmN2laovqOKTz66NL9pwsxU0/0UVOUGQkuubCjhSqR4Cv9svR2AJZwgRw VjaZPwCJ0MTGKu/X82Lk7F3FPaFaByOjtagJgnNvK+UCsVKZ1ODh/34kFyayt3UAPx6i V9gjeewPJUSAx4A+WH8V3zOLp1IAZW2glUBWM9Q9mnv4Ozbdzzh1APgJ+OiOz+KIYjEN kpA2TbxjxCQcj2wwJ+h+AvPbftKJfBrB1wLKvteXKgHduGSu+qvYikWDzOTi7bnV8UDs OptFoa90pMcgjGXL7l2WOg+DK+gSHxvEVnj9QeSbA4FzLPqZRN4GDQl3oT/tLkpU2jMr xvjw== X-Gm-Message-State: AOAM530Xcl18R/Hk5vnATcHpBLKddaeSMDSMAHqbnZnQngM6Mnxjtg8x 7+IaKH0PDL2Opws0j2GW4bsGetRzxnO/4gLD8ImrVw== X-Received: by 2002:a17:90a:ab86:: with SMTP id n6mr4120227pjq.159.1631201375443; Thu, 09 Sep 2021 08:29:35 -0700 (PDT) MIME-Version: 1.0 References: <20210909144428.2564650-1-bryan.odonoghue@linaro.org> <20210909144428.2564650-3-bryan.odonoghue@linaro.org> In-Reply-To: <20210909144428.2564650-3-bryan.odonoghue@linaro.org> From: Loic Poulain Date: Thu, 9 Sep 2021 17:39:54 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] wcn36xx: Add ability for wcn36xx_smd_dump_cmd_req to pass two's complement To: "Bryan O'Donoghue" Cc: Kalle Valo , linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org, Benjamin Li Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, 9 Sept 2021 at 16:42, Bryan O'Donoghue wrote: > > Qcom documents suggest passing of negative values to the dump command, > however currently we convert from string to u32 not s32, so we cannot pass > a two's complement value to the firmware in this way. > > There is in fact only one parameter which takes a two's complement value > in the antenna diversity switch command. > > Downstream: > iwpriv wlan0 dump 71 3 > > Upstream: > echo "71 3 " > /sys/kernel/debug/ieee80211/phy0/wcn36xx/dump > > Fixes: 8e84c2582169 ("wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware") > Signed-off-by: Bryan O'Donoghue Reviewed-by: Loic Poulain