Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   =?ISO-8859-1?Q?J=E9r=F4me?= Pouiller <jerome.pouiller@silabs.com>
To:     Kari Argillander <kari.argillander@gmail.com>
Cc:     devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kalle Valo <kvalo@codeaurora.org>,
        "David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH 29/31] staging: wfx: remove useless comments after #endif
Date:   Fri, 10 Sep 2021 18:49:30 +0200
Message-ID: <3556920.DX4m0svyV5@pc-42>
Organization: Silicon Labs
In-Reply-To: <20210910162718.tjcwwxtxbr3ugdgf@kari-VirtualBox>
References: <20210910160504.1794332-1-Jerome.Pouiller@silabs.com> <20210910160504.1794332-30-Jerome.Pouiller@silabs.com> <20210910162718.tjcwwxtxbr3ugdgf@kari-VirtualBox>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?pPuP4VoRvVKpG8UsZ6XKfgBW5OdBENlGz86w32m0WV239EZBkyhDh45ZmY?=
 =?iso-8859-1?Q?0A0G0dqYPMg7Tl2wpIQoRPDQlYnjM5PBAZkvFkqHHp2n0CIdYS6DRKMG/z?=
 =?iso-8859-1?Q?GBa6XeJ+KPmjkcTadq8qzqZ1dShhUZOYHBnFBxUJqbLkQuoCrirJ0EFXQx?=
 =?iso-8859-1?Q?KyihFwWm6AP6QmX4XEt40NIWgSOqR9Zh1Js2N/JB+3avlvUsBAcssTiJsb?=
 =?iso-8859-1?Q?Cvg3nY5vr/hknytHV3XeXgtQ5cESszj24ntMg4jWpsJc+q+lcM2Ul/KQz3?=
 =?iso-8859-1?Q?mpZ8L5cRILesbtXEJD5EFKscjfrthgnKbrgDwJjtSpSon8So7gWD22wCjo?=
 =?iso-8859-1?Q?Q9SQbFF457O1HHAwybzmb1ZGX2lk0ojRg7tDME8FA3jJ4mup3fHda3eswf?=
 =?iso-8859-1?Q?IdKwJcudczOx/o8GnWmV5lx1Dx14wMMAotttZSKwXUQ/j3xbEuyQm6A1iv?=
 =?iso-8859-1?Q?ipcn8I+tM+1RjJroYxU8hV6Ierh59REhSZo4Huh1ZkwMrMyyB+vY3pq4oJ?=
 =?iso-8859-1?Q?Ha+pHf21NzxYHcIMG9/6OHBWb8rSWC2NgpHVkmXmSBkEecK4xX/Q0EsNEg?=
 =?iso-8859-1?Q?3ectjYUztO8kko+bv8uEKafUGJVajF0WF1rhFnYpPEQahhKfLK7vvFBZZp?=
 =?iso-8859-1?Q?dCcoQ0G0z6ynvMaUYIaQ0VlLAVGD2/QrRuk+CiCP2sYPTEpHjC3zjvgoUG?=
 =?iso-8859-1?Q?/us+/zpk26OzRJU/C01j2PvE9vOP+U7RrO/dVNTwE2mgRkyAMTSQh7Z8VA?=
 =?iso-8859-1?Q?zC3PSf9rCwoHuOvMR0ZLsbnxVzd7bfNA/eZp0RFX19StQBRWp4l1qmuDTf?=
 =?iso-8859-1?Q?ow7J79hEogFbHh3f4Zx/1P3sB8Pxc3p0hT2+P963QEtCVNv0LkCD+I0fMV?=
 =?iso-8859-1?Q?Zv3bYwrw/pTerxvhyJ0xOT3eZWGSmvqBOltbnWYuwvGv4cd6sQ5Zv8RDy3?=
 =?iso-8859-1?Q?KW9TTFP/cExLg4eXbEVHVjr6LMRUouunsQqRPFw6oKLTFcTulR7G17X8Ao?=
 =?iso-8859-1?Q?CjagB2hOxlUXs7WtMMkizMtWsg/70WalftoTmWBInth+rFpn/J5lT8DsJe?=
 =?iso-8859-1?Q?9yG26NGtdFSX6nvXTNx840frRAxzewBwLg+paGgwZNJ/a20/f+zApKT2s2?=
 =?iso-8859-1?Q?xSvdgDO2kCW7TiECKG1imjZ8bPIcJjkegG2zZm4Ml7sJ8/VZ+hMHYp/Zrd?=
 =?iso-8859-1?Q?zUhQ0UXkkbLVJ61lMpVD2yAQTklfgp92Z47SdLQZo6CYb12/rxSa42MJu+?=
 =?iso-8859-1?Q?gmJVs9IOBFBzvhutFMLeWOFxBNYI0okS9UQLBU0hqgJJZCaDxerh1P2UBU?=
 =?iso-8859-1?Q?QEZYISebpZyCR1kmbn27yGEKQhrlU9Raw2KKY2608YcOsGCmZbsI1KVwbU?=
 =?iso-8859-1?Q?fxUbGt+QD8RTkjAtkCfcQsEDNhUElGaIdL2OP9Q2iXi3r04bys9oo0sqIa?=
 =?iso-8859-1?Q?zLK6zkZWbjA0iWaA?=
X-OriginatorOrg: silabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab70d748-0ad9-4b0d-7da3-08d9747af7e7
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2021 16:49:34.5010
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b9+RsaNI48b7NOUxXmwTldbLXh9T+GzJkqXCuh5KNUYbyZo8hKD+BekdYmFpZnRExCmRzv4CFxD29L3VSI6ctw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5052
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Friday 10 September 2021 18:27:18 CEST Kari Argillander wrote:
> On Fri, Sep 10, 2021 at 06:05:02PM +0200, Jerome Pouiller wrote:
> > From: J=E9r=F4me Pouiller <jerome.pouiller@silabs.com>
> >
> > Comments after the last #endif of header files don't bring any
> > information and are redundant with the name of the file. Drop them.
>=20
> How so? You see right away that this indeed is header guard and not some
> other random thing. Also kernel coding standard says:
>=20
>         At the end of any non-trivial #if or #ifdef block (more than a
>         few line), place a comment after the #endif on the same line,
>         noting the conditional expression used.
>=20
> There is no point dropping them imo. If you think about space saving
> this patch will take more space. Because it will be in version history.
> So nack from me unless some one can trun my head around.

IMHO, the #endif on the last line of an header file terminates a trivial
#ifdef block.

Moreover, they are often out-of-sync with the #ifndef statement, like here:

[...]
> > diff --git a/drivers/staging/wfx/key.h b/drivers/staging/wfx/key.h
> > index dd189788acf1..2d135eff7af2 100644
> > --- a/drivers/staging/wfx/key.h
> > +++ b/drivers/staging/wfx/key.h
> > @@ -17,4 +17,4 @@ int wfx_set_key(struct ieee80211_hw *hw, enum set_key=
_cmd cmd,
> >               struct ieee80211_vif *vif, struct ieee80211_sta *sta,
> >               struct ieee80211_key_conf *key);
> >
> > -#endif /* WFX_STA_H */
> > +#endif
[...]

--=20
J=E9r=F4me Pouiller