Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   =?ISO-8859-1?Q?J=E9r=F4me?= Pouiller <jerome.pouiller@silabs.com>
To:     Kari Argillander <kari.argillander@gmail.com>
Cc:     devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kalle Valo <kvalo@codeaurora.org>,
        "David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH 02/31] staging: wfx: do not send CAB while scanning
Date:   Fri, 10 Sep 2021 18:54:36 +0200
Message-ID: <2897625.p8pCB6X8cM@pc-42>
Organization: Silicon Labs
In-Reply-To: <20210910163100.n6ltzn543f2mnggy@kari-VirtualBox>
References: <20210910160504.1794332-1-Jerome.Pouiller@silabs.com> <20210910160504.1794332-3-Jerome.Pouiller@silabs.com> <20210910163100.n6ltzn543f2mnggy@kari-VirtualBox>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?c+QircM+zrkhdtrPV0ZgXjilISgTHU/PQNDKyM5x78zg/klRpDP7PYp0mt?=
 =?iso-8859-1?Q?JSu+ylYQOH086Bu7KwZcmHkExFUwAUfuMQenC9SvP86hn63tX0r8rrvN1G?=
 =?iso-8859-1?Q?QyVweq8fbjRbm1jslXfkO2WIIKqYvFJRWxU8dj655B0GNBd8M2/fAWyByo?=
 =?iso-8859-1?Q?cyaqTwOQ9Ai1myVp7pEKxF7rTm79VRNYgNBKiBOzK2eDsxICmgCfcA6MAv?=
 =?iso-8859-1?Q?SH+A7Tb1pXNM+CuWnjV7zNI3sotfEtuSo2jME6zm5TyUPPLu+PFL2Uh0ez?=
 =?iso-8859-1?Q?SSg16JiBJrue88NNlf9IZrI+VJZ25ZkIIjhKOXTZvZoD6P4oHo/3NnMx36?=
 =?iso-8859-1?Q?ehfsyxXWJ1/UE5wIYISnJzZx6A51izyQl1RBrW3K/cf3STcTxTc7tIle4y?=
 =?iso-8859-1?Q?IZAT5gvhIrkeL8TY1lAIizTADyPIRG17+hMXAtUa3ZCYoQsE/8+XmlJo6c?=
 =?iso-8859-1?Q?k3YexHbZVSV2ncDIShD4Yd/QYjRcaMjdCh3s3mkgmYuOXkdHyK2Kn2mnZz?=
 =?iso-8859-1?Q?/HWNiKq+ic2Tkad6m9Kcl8YB+zv/mj71jBFILECxj1o4TwAIsyinAT5hfh?=
 =?iso-8859-1?Q?bHI5dZMRXogS2sBxpAVhSyuu2r7wdU8xWkzO5mKUqRinU1TmgZYYamCLLZ?=
 =?iso-8859-1?Q?MwM5f7Zea6vQzbu6Qa+qV1fmSosoMaazurHZXw+PDF/MTLAXf8pFhrQUj1?=
 =?iso-8859-1?Q?CJtnjYkKGutoa9a4CII8sCqp5w+/jcaCj3EzIzsW3joA848k94k7pdzL0j?=
 =?iso-8859-1?Q?xsALgK8x9Fu9om6ml0GjYJnBTQIOVCPjbffeAnWreujMzkFsEIhK0SNc/v?=
 =?iso-8859-1?Q?TYvgoxJVWfUWRXRSZaCSAE/fs3BKDfWg1ZqInUj2m7p8UDWqJrC/gRq+Qq?=
 =?iso-8859-1?Q?m1yMM3zqlCiU189xdppdZtFGh0H+5T2FO6aqJJdPBURazBVVxFTR/4inXD?=
 =?iso-8859-1?Q?m71c9I8MXg6lVOOaZFAItsPYtan1QQsquDz7S9y6DRQAkozX6KueEOyMz8?=
 =?iso-8859-1?Q?/weFQ7P3UdNlnSDEAsq00tTARVmFK0m0uET0QfG6mCgSGOJkTyU9QrbCKw?=
 =?iso-8859-1?Q?Y/XB8rmEQz+IT+RjzOABrW55FVx60YNioaeMbTopkZ3C4VsysT8h4gDZsc?=
 =?iso-8859-1?Q?WSMC+wECKVrim8dbC7e/qhygn65hHxig9U+p6Jh24PRy1v5bPuCSsJb3p3?=
 =?iso-8859-1?Q?fdHn4fEOmK/qO2Os2oTmOnSk2J5oBfRfIUpE96eoTW+vtcaRbCz0KfcezV?=
 =?iso-8859-1?Q?y+7e7uqOYvUNB3ZT18rKvGq1DIhC+l8J6+LMXKHHjF2dHVl0kWq0ZiCrKf?=
 =?iso-8859-1?Q?tXfuhQeEMChW9/6vi2F+udFemeJKhxvXjjpVw6Hn6+7TmIah9FKPh+jXQQ?=
 =?iso-8859-1?Q?K5xSNRaE0vwbMBCyEy1KCt+t1c6Plg2MWIBZFdNooUFGalgPyFJPca/UEW?=
 =?iso-8859-1?Q?o66EamjneiinL77H?=
X-OriginatorOrg: silabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 61433090-76cc-4dcc-227a-08d9747baee0
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2021 16:54:41.4788
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S11Uz6k8sUkkrMjEQHpAfqFjOjxlYd/gbZU7M9wm4oFQmYw1zWgeMu3wFZ+0HMgZksBHQylg7vfo2yWgGeNHhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4703
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Friday 10 September 2021 18:31:00 CEST Kari Argillander wrote:
> CAUTION: This email originated from outside of the organization. Do not c=
lick links or open attachments unless you recognize the sender and know the=
 content is safe.
>=20
>=20
> On Fri, Sep 10, 2021 at 06:04:35PM +0200, Jerome Pouiller wrote:
> > From: J=E9r=F4me Pouiller <jerome.pouiller@silabs.com>
> >
> > During the scan requests, the Tx traffic is suspended. This lock is
> > shared by all the network interfaces. So, a scan request on one
> > interface will block the traffic on a second interface. This causes
> > trouble when the queued traffic contains CAB (Content After DTIM Beacon=
)
> > since this traffic cannot be delayed.
> >
> > It could be possible to make the lock local to each interface. But It
> > would only push the problem further. The device won't be able to send
> > the CAB before the end of the scan.
> >
> > So, this patch just ignore the DTIM indication when a scan is in
> > progress. The firmware will send another indication on the next DTIM an=
d
> > this time the system will be able to send the traffic just behind the
> > beacon.
> >
> > The only drawback of this solution is that the stations connected to
> > the AP will wait for traffic after the DTIM for nothing. But since the
> > case is really rare it is not a big deal.
> >
> > Signed-off-by: J=E9r=F4me Pouiller <jerome.pouiller@silabs.com>
> > ---
> >  drivers/staging/wfx/sta.c | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
> > index a236e5bb6914..d901588237a4 100644
> > --- a/drivers/staging/wfx/sta.c
> > +++ b/drivers/staging/wfx/sta.c
> > @@ -629,8 +629,18 @@ int wfx_set_tim(struct ieee80211_hw *hw, struct ie=
ee80211_sta *sta, bool set)
> >
> >  void wfx_suspend_resume_mc(struct wfx_vif *wvif, enum sta_notify_cmd n=
otify_cmd)
> >  {
> > +     struct wfx_vif *wvif_it;
> > +
> >       if (notify_cmd !=3D STA_NOTIFY_AWAKE)
> >               return;
> > +
> > +     // Device won't be able to honor CAB if a scan is in progress on =
any
> > +     // interface. Prefer to skip this DTIM and wait for the next one.
>=20
> In one patch you drop // comments but you introduce some of your self.

Indeed. When I wrote this patch, I didn't yet care to this issue. Is it
a big deal since it is fixed in patch 27?


--=20
J=E9r=F4me Pouiller