Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 13 Sep 2021 13:06:05 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Jerome Pouiller <Jerome.Pouiller@silabs.com>
Cc:     devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "David S . Miller" <davem@davemloft.net>,
        Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [PATCH v2 13/33] staging: wfx: update with the firmware API 3.8
Message-ID: <20210913100605.GJ7203@kadam>
References: <20210913083045.1881321-1-Jerome.Pouiller@silabs.com>
 <20210913083045.1881321-14-Jerome.Pouiller@silabs.com>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210913083045.1881321-14-Jerome.Pouiller@silabs.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?MncH1JAvrJy/6GPO3z8KC1BoGDeaF9OLQfjr9cmk0a3/X7d+k6GX+MLvzl?=
 =?iso-8859-1?Q?j9sikZ+V8kRCMOBoFKF5DR93c+jaDehtl4CXeBNby8NwnBu20YsQr5Z3bk?=
 =?iso-8859-1?Q?LW+bW5nCd93gHoEA/nZC4y6MgJWxpfraFOATpzxWn7/fak27FdlxdId2Ga?=
 =?iso-8859-1?Q?KBR54gdyra2/Dv1mb7XVIzV2lZmWu/n6k4elgQLYdEHVXKClJ4wqsJzXTc?=
 =?iso-8859-1?Q?cG15eSSO1PrZ8AEc+crWqjLhdGBNCBd5K0FOtIX5MJ4Qc3Mk1bQmU0NGKJ?=
 =?iso-8859-1?Q?aEWlZz7HztDqjlR4v2vSXf95C9xYC8gFIVvkCSYYkU3GBYc/X2abAEzrdZ?=
 =?iso-8859-1?Q?HBhbTS6ypdQuy2jlpzuhw9T9s93coYGtJZ11oVkyfYXWl75tjDvzPoJ72E?=
 =?iso-8859-1?Q?33DynV+Q6vLV/z0x6nlSjIqCiPrjG6SDkN3yOZ3DQZugGhB/G/wGdWs4E+?=
 =?iso-8859-1?Q?8gfTwEDbnfXSwPXKmySjmQF7dp8P77/xMhiu+L6dq9zLLfZaN5rI5Vhs9U?=
 =?iso-8859-1?Q?WqzHxpxXA2hXOPsPN94Ggk5jz5vaNEClgkw0UvoVVop4eLUotTeFZsTOtd?=
 =?iso-8859-1?Q?WyYy0MEt7KcMQw7Apptzn7wL5c5a6sMR4PTV5M6JdLit0wKyfllcx0Yvx6?=
 =?iso-8859-1?Q?K2seWR82e1jBGLZTuV+47atdp/3iUUd6XCrjlQxakuv3qAhftdhbX4/0me?=
 =?iso-8859-1?Q?5oLUqT/dwEbHxv09mU1C2UA4yK696pJgmClYRpuwNdkbH9tqYgh3Pta3Tm?=
 =?iso-8859-1?Q?TN7PjC/CC47lpscZnMIOjFG3KF9U6AxqYtzq7AhPZYrLWyfkkl/xxgcl71?=
 =?iso-8859-1?Q?ioDIDCED3LwGiStLcis65X0lyDwSxx4ps2JZLakx9W4GtvW8a/yLuFxo7f?=
 =?iso-8859-1?Q?TZheEqGiubAkEj61d/vgK+TuBuPEpftCzPeRJdFDNAmY+lTrFDG3XZdS5I?=
 =?iso-8859-1?Q?WK3/4aIa8MAtsm8LKsUjr6+yASJ6XuJuU4vy0VWfotz0/57f3G2aXuDm3L?=
 =?iso-8859-1?Q?Yf8xNYXGz2CdwnCoDafSkQC7W9Up/dp7q9zq9DP6DMF3aS/BU+jn11hdOA?=
 =?iso-8859-1?Q?DpztG1B2UeSXgQkmlqIpxalUoOGKPahEfIZxi3SW7MY2rVOimuYpucVRVp?=
 =?iso-8859-1?Q?KQy6EY7r0uAPjkgBz3XDMZcWYUMGanarfBrMwdOgN7xbQV5MB0fr3D4wRr?=
 =?iso-8859-1?Q?M18M20wW2wNkcnCIuvv6Rhv4yoLVjbHoZZyLyWaS48xtFFXqu9E0kBxjVw?=
 =?iso-8859-1?Q?Dgk0asO9eX2rbPilDbBjO11OXAVCMBoeWAO93S75B+tGRFcGu6h3YU4zge?=
 =?iso-8859-1?Q?/Gu+mGKDjtswvr756XLRc0SHrn0NJMjLidtix5H5AinrMYsp0Lyr2gs4ce?=
 =?iso-8859-1?Q?gkxqf0hnUY?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f29729d0-17ac-4228-0616-08d9769e2417
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2021 10:06:23.6322
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W28+cYnxAQ/oCrfuRT+hBoxCy9VqGOum/R/nstJ/hKuI8gCmZO1u/RTEC+LCT/QQQ5QQDcKmLJd8l5UCrBGQWx6K0I2KnDF3GZi2UJJexJU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2253
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10105 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 suspectscore=0
 phishscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001
 definitions=main-2109130067
X-Proofpoint-ORIG-GUID: My0R8JSbQgnKb625IUhddbrYW1mUqIsU
X-Proofpoint-GUID: My0R8JSbQgnKb625IUhddbrYW1mUqIsU
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Mon, Sep 13, 2021 at 10:30:25AM +0200, Jerome Pouiller wrote:
> From: J?r?me Pouiller <jerome.pouiller@silabs.com>
> 
> The firmware API 3.8 introduces new statistic counters. These changes
> are backward compatible.
> 
> Signed-off-by: J?r?me Pouiller <jerome.pouiller@silabs.com>
> ---
>  drivers/staging/wfx/debug.c       | 3 +++
>  drivers/staging/wfx/hif_api_mib.h | 5 ++++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wfx/debug.c b/drivers/staging/wfx/debug.c
> index eedada78c25f..e67ca0d818ba 100644
> --- a/drivers/staging/wfx/debug.c
> +++ b/drivers/staging/wfx/debug.c
> @@ -109,6 +109,9 @@ static int wfx_counters_show(struct seq_file *seq, void *v)
>  
>  	PUT_COUNTER(rx_beacon);
>  	PUT_COUNTER(miss_beacon);
> +	PUT_COUNTER(rx_dtim);
> +	PUT_COUNTER(rx_dtim_aid0_clr);
> +	PUT_COUNTER(rx_dtim_aid0_set);
>  
>  #undef PUT_COUNTER

Not related to the patch but the PUT_COUNTER macro should be called
something like PRINT_COUNTER.  It's not a get/put API.

regards,
dan carpenter