Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp836239pxb; Tue, 14 Sep 2021 09:43:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw7SGMjuywBiEOepYmoBhhTx2TFJALHWBuJtW8IAoVNppYN1X/JupO1axYvjd7MRNgmriEg X-Received: by 2002:a02:8189:: with SMTP id n9mr15342205jag.107.1631637807125; Tue, 14 Sep 2021 09:43:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631637807; cv=none; d=google.com; s=arc-20160816; b=k660KrB3zOOchbtAZVhyLnBLsoxObnKDXuTnT2t9mrLgFys1PEfsEKaEyOoH2Gkpv5 P+tU3gk4mDq9x4ZFFx5JSr47h5s0VxkqueGUX2Lb/iQ2sZjoRWL2+KXN844RlVnoxKHP dNGheVAinWKk1z4WkJb6E1USkajlwntO/jplmWMmbGltfdLm+Fvf2kd9NQmVz2ml6v7X bXFpHZSvIsyLxMvk2A06UytuR19LJGnpdLbTwKpyJzejTFUk3iMQNuMI0KOVxZxSeVcC L7vxN4oy6WQE4g5mkQnlF6TGGtfzjXzPSbtR1j2gRoxaJ+ZzeuXrpSQfNdiiKmaIbCqO 7XrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=9GTkSFqWLDB9TUuE1JdS3Yf2hIc4B7LFMjM7aXHs6YU=; b=yCPdNO3Vv1v9PnpufFchVRJzSNHDNJBrAhovDjqNxWz9/RGlWjRullZiczBtsW/rro rc0+A9f0FIhQWR8JWTKhWUYOMGBdcsOiG6cHDr4WvxhNUH9/g2EKNj2z6wdllZFFLiBs J/TZrgoUUsALr1hIj3lHnkDlCab4nZxZyUnoX6W+LDBUaMEEEt9izYKujeMng0RSHQMW LfI9/0r8e88Tgv818DUJE5neYzYMIJN1nbVXiqNOqoN4hYP8pzHKnoIF5ub/3hgB6ft6 /9H4+38lMhrKshtQK11VpaZqrA1lKiK3dpRg0XmdrJi2Xa/kopziMeigOolWtQ3yH89d hV1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=V+kUaNHq; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k12si11239058jac.101.2021.09.14.09.43.13; Tue, 14 Sep 2021 09:43:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=V+kUaNHq; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229903AbhINQoX (ORCPT + 99 others); Tue, 14 Sep 2021 12:44:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:47548 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230288AbhINQoW (ORCPT ); Tue, 14 Sep 2021 12:44:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 657D260FD7; Tue, 14 Sep 2021 16:43:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631637784; bh=lWvDjlvmEl4yBD0aljtG/+BcG4nHwNUOy7Klw8GehW0=; h=From:To:Cc:Subject:Date:From; b=V+kUaNHqfVbwjX3YQVeb3LVttxBnkMCVKMns8MWGqONvz/YJqemuCWvL2clC5xdIh R+g+c07G8VMLDgjYMw7IKov9YsEHPU41Kglx0JRGuZ81CBapOrooKWE1sDhXLrOMwe AqnX4Rr888VouGTG3q/BbJmSq6W5LwLe0o4vqkN04EJ5KoS4RnS0x+ikilhGG6TuKk fSgTzyguBihWTHaJ2uQ2alXhJdtM87xNBgRZOG80ypKM7MYe9dCtkzdoYKx8GeypPo XpZqa76toOznRkxU8dtFWq/5IzvAg/pYHEmgipU5iMWubcfEUDgzh4VyYdLjJQpwxA ewC0xBlPLgiXQ== From: Lorenzo Bianconi To: nbd@nbd.name Cc: linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com, ryder.lee@mediatek.com Subject: [PATCH] mt76: mt7915: fix possible infinite loop release semaphore Date: Tue, 14 Sep 2021 18:42:51 +0200 Message-Id: <1e170ef07c19a4df305004aeac3da237ef085de2.1631637656.git.lorenzo@kernel.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fix possible infinite loop in mt7915_load_patch if mt7915_mcu_patch_sem_ctrl always returns an error. Fixes: e57b7901469fc ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets") Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt7915/mcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c index 263a99d0b723..cd2d7629714b 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c @@ -2712,7 +2712,7 @@ static int mt7915_load_patch(struct mt7915_dev *dev) default: ret = -EAGAIN; dev_err(dev->mt76.dev, "Failed to release patch semaphore\n"); - goto out; + break; } release_firmware(fw); -- 2.31.1