Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp886695pxb; Tue, 14 Sep 2021 10:48:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQzzj9tdQNmYg5F0m+i6Le4c+69vI2ytzyK4t49L504pVvBY68fYEAMDi49iDq+6T3Sfl2 X-Received: by 2002:a05:651c:1126:: with SMTP id e6mr16624226ljo.28.1631641718748; Tue, 14 Sep 2021 10:48:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631641718; cv=none; d=google.com; s=arc-20160816; b=HfFgqrh6PGExPXJWpeDjxgECwMOwuK8xfnn4h4ijrZB+2dzJSdBK7dWCTsxQMRMtkj qyzkWAjn/w0h1Tn+zqP2SLIGzgMLbqNJ57N32X7DLwX94Y9M0hx4uAdsDzoMV2SiHwNh LPY+9Ku1cchuhV56fFvDOPo4SwxBxQ/wjtgfYX6XVdhjQ365N12dMQDhvfBlv9Mep3CN 81OpryByKGD0haMOd3Wc6s0CFTa0tGNFB6EQscOf5W9bbwWmybj/+NA17OW7BDQcKnB8 RsZAHvOq+2QOn/SiUHMV7LleCnv2rCFCzXnk34k0jlV/LSNaKZSd+/ETQ2soB9X9F3gG BVSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=EfHEolyqizp80U3UwdqfInfJzN5d8cwv+TMXFuNjLMU=; b=D5RntS6fRBxnpC3KLhW3cYIS0zlQqOX7c7iHBHhh7t8kRtzHlNGS4Byus+JMjhnUGV S70wzFHZhJtdqxTEU5kSpx5tyFSKp6wmDDbAglbmG3cG4HrQMYxO8XjD08KqB7NcUmLV HLm4SGA3ofV7+hC89+XfgqqT/X25YEr4qoF0xT5W3PJY0O+GdpSfrkigq4Q51Y1qfJ+z gUfL6bO2N0SiSKJ4VXMbg+ZJHQLOk8iCTMnKhtX1NFolnywmquRxENUIpVc19jAbkpDd 2Q9ja+QdcbM7pm1vq0rvA6woC7Wp7De2XU1ZtIuPX7QHxjuh2ipqMtKmUy8iADh4B879 yTPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KSv+RtTp; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d25si177957lfv.339.2021.09.14.10.48.08; Tue, 14 Sep 2021 10:48:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KSv+RtTp; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231438AbhINRtC (ORCPT + 99 others); Tue, 14 Sep 2021 13:49:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:44562 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231723AbhINRtB (ORCPT ); Tue, 14 Sep 2021 13:49:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CF44660EE7; Tue, 14 Sep 2021 17:47:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631641663; bh=XwFlKQprbS5Xsut4+KVkQ9rCehkueeb5Va+IvjAKMe4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KSv+RtTpPHB8oKm9pr3uJGiIUDjyo2a5hOdIoMlnQ+P24YDigyFarSm+jspCdwnaF 78wzNARuX57eydl869SJQaHVt0n+G1NmLKKEHCwNPgxa6qAD3uhsKdlKXTwojUKZ7H e7udUMegacreRABX8g+Klx5kSDDa8xPkubf2ga8jzzyOtSw/eAwSGSkqgPnkSsnnfs DJLgqqWkeSW2lf1sKx3nerYD0NvR/aGS0vURmuOHsA4rK3TLz3D+S8yshF0EsjYWLd EFkngxWr8o95rvJkavLuM9rA/6eGaHB/RYfqc4goNJ0MsM6pB+TnxV2cG/eGWX4zkF xaDCKjKF8Ujdw== Date: Tue, 14 Sep 2021 10:47:41 -0700 From: Jakub Kicinski To: Julian Wiedmann Cc: Yufeng Mo , davem@davemloft.net, netdev@vger.kernel.org, shenjian15@huawei.com, lipeng321@huawei.com, yisen.zhuang@huawei.com, linyunsheng@huawei.com, huangguangbin2@huawei.com, chenhao288@hisilicon.com, salil.mehta@huawei.com, linuxarm@huawei.com, linuxarm@openeuler.org, dledford@redhat.com, jgg@ziepe.ca, netanel@amazon.com, akiyano@amazon.com, thomas.lendacky@amd.com, irusskikh@marvell.com, michael.chan@broadcom.com, edwin.peer@broadcom.com, rohitm@chelsio.com, jacob.e.keller@intel.com, ioana.ciornei@nxp.com, vladimir.oltean@nxp.com, sgoutham@marvell.com, sbhatta@marvell.com, saeedm@nvidia.com, ecree.xilinx@gmail.com, grygorii.strashko@ti.com, merez@codeaurora.org, kvalo@codeaurora.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH V3 net-next 2/4] ethtool: extend coalesce setting uAPI with CQE mode Message-ID: <20210914104741.78b21e72@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <1629444920-25437-1-git-send-email-moyufeng@huawei.com> <1629444920-25437-3-git-send-email-moyufeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 14 Sep 2021 20:31:29 +0300 Julian Wiedmann wrote: > > - if (!dev->ethtool_ops->set_coalesce) > > + if (!dev->ethtool_ops->set_coalesce && !dev->ethtool_ops->get_coalesce) > > return -EOPNOTSUPP; > > > > This needs to be > > if (!set_coalesce || !get_coalesce) > return -EOPNOTSUPP; > > Otherwise you end up calling a NULL pointer below if just _one_ of the > callbacks is available. Good catch, care to send a fix?