Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp303780pxb; Wed, 15 Sep 2021 02:24:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAKNKFyzzbsIUpyIkaD0dDnW/luuVG/QZQ47/TTGvFl8UQSll+hGXNHXYzqwDnmtKNk0rh X-Received: by 2002:a2e:9450:: with SMTP id o16mr19056927ljh.80.1631697864861; Wed, 15 Sep 2021 02:24:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631697864; cv=none; d=google.com; s=arc-20160816; b=PoF9asvMbwGDgcTmO8IOsKqHDt80UkVg1z25Doeeh/Tf6jpCJuQFjGJMEsYtkazTle YHFnSbbJYBYT61J7QxHS/W/uTBhEvkP0Pb10bIt9TuEGuDQQzrEd19J6hoLOoXeAwoh/ 4nuE3PwJUaSXwEXQjGcbzx7EqJ3+6Xfq13GdOGDPUOArDmD7z1oKC+h2Kq5QZ3XRBDs0 ThaIQRhF3eq6DXzbRWDfPmfNXIE26Zv2L5+0F1w3QFbCTfL+K+pWmSs7KTu8MVyD4CmO A23ujB3P27mE8x8NcyA0stg78SQaViR6iO8svGV9B+eTXbl0dLgKZiXDa8He3ZFdfaR3 2xVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=5CqL41oittmf6P0DZlhj+f3LbuMZBDYH4Z5bHe/RafY=; b=AQF+jXhZvSkjkzCdo0lInfGV4J1IATGDxdyXIXxJKnIqfxKnvNdZbZupWd7apg/ayc wLnXBv/5RePJtsSlvU81NpVvoQV/OEjbC7cLd1mREKL0oZG7CMaVRcdbAYRi4R80dXyQ LePbCZ7+Z2SOOAC4rz5mj/RukuXgP1YAP5IBT2sn9fNf6OLVck8lotJ14hWCMrm8ox7y +52rLnf6/UTZhYKTCtDOyMXohDUoP1eekH8LpSKpUjs6st5HiJcKsN0iZsUN1OLFPCTl TPOBMoXjL1QVoTkMxac4A60/BcLYKf3OUdLTMNz5guLo5YnJ8V4qrAYSDfzk3He6vgFc 8X/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b12si22390159lfb.270.2021.09.15.02.23.56; Wed, 15 Sep 2021 02:24:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231974AbhIOJZM (ORCPT + 99 others); Wed, 15 Sep 2021 05:25:12 -0400 Received: from mail.aperture-lab.de ([116.203.183.178]:57710 "EHLO mail.aperture-lab.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229785AbhIOJZM (ORCPT ); Wed, 15 Sep 2021 05:25:12 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id DA9C93EA68; Wed, 15 Sep 2021 11:23:45 +0200 (CEST) Date: Wed, 15 Sep 2021 11:23:43 +0200 From: Linus =?utf-8?Q?L=C3=BCssing?= To: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Cc: Kalle Valo , Felix Fietkau , Sujith Manoharan , ath9k-devel@qca.qualcomm.com, linux-wireless@vger.kernel.org, "David S . Miller" , Jakub Kicinski , "John W . Linville" , Felix Fietkau , Simon Wunderlich , Sven Eckelmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] ath9k: interrupt fixes on queue reset Message-ID: References: <20210914192515.9273-1-linus.luessing@c0d3.blue> <87a6kf6iip.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87a6kf6iip.fsf@toke.dk> X-Last-TLS-Session-Version: TLSv1.3 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi Toke, On Tue, Sep 14, 2021 at 09:53:34PM +0200, Toke Høiland-Jørgensen wrote: > Linus Lüssing writes: > > > Hi, > > > > The following are two patches for ath9k to fix a potential interrupt > > storm (PATCH 2/3) and to fix potentially resetting the wifi chip while > > its interrupts were accidentally reenabled (PATCH 3/3). > > Uhh, interesting - nice debugging work! What's the user-level symptom of > this? I.e., when this triggers does the device just appear to hang, or > does it cause reboots, or? > > -Toke > For PATCH 2/3 the user-level symptom was that the system would hang for a few seconds and would then silently reboot without any notice on the serial console. And after disabling CONFIG_ATH79_WDT the system would "hang" indefinitely without any notice on the console without a reboot (while JTAG/gdb showed that it was entering ath_isr() again and again and wasn't doing anything else). For PATCH 3/3 I don't have a specific user-level symptom. But from looking at the git history it seemed to me that the ath9k hw interrupts (AR_IER, AR_INTR_ASYNC_ENABLE and AR_INTR_ASYNC_ENABLE off) should be disabled during a reset: 4668cce527ac ath9k: disable the tasklet before taking the PCU lock eaf04a691566 ath9k: Disable beacon tasklet during reset 872b5d814f99 ath9k: do not access hardware on IRQs during reset e3f31175a3ee ath9k: fix race condition in irq processing during hardware reset Maybe someone else on these lists might know what issues this can cause exactly? Regards, Linus