Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 15 Sep 2021 15:31:34 +0200
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     sean.wang@mediatek.com
Cc:     nbd@nbd.name, Soul.Huang@mediatek.com, YN.Chen@mediatek.com,
        Leon.Yen@mediatek.com, Eric-SY.Chang@mediatek.com,
        Deren.Wu@mediatek.com, km.lin@mediatek.com,
        robin.chiu@mediatek.com, Eddie.Chen@mediatek.com,
        ch.yeh@mediatek.com, posh.sun@mediatek.com, ted.huang@mediatek.com,
        Eric.Liang@mediatek.com, Stella.Chang@mediatek.com,
        steve.lee@mediatek.com, jemele@google.com, shawnku@google.com,
        linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v1 09/16] mt76: mt7921: make all event parser resuable
 between mt7921s and mt7921e
Message-ID: <YUH1tvJA0EUQzLaA@lore-desk>
References: <cover.1631667941.git.objelf@gmail.com>
 <764759a9a2befe09000863f04676287665675555.1631667941.git.objelf@gmail.com>
 <YUHz/gbfzmFszods@lore-desk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="pTOOomLTkB8wTJhp"
Content-Disposition: inline
In-Reply-To: <YUHz/gbfzmFszods@lore-desk>
Precedence: bulk


--pTOOomLTkB8wTJhp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> > From: Sean Wang <sean.wang@mediatek.com>
> >=20
> > The longer event such as the event for mcu_get_nic_capability would hold
> > the data in paged fragment skb for the SDIO device so we turn the skb to
> > be linearized skb before accessing it to reuse the same event parser
> > betweem mt7921s and mt7921e.
> >=20
> > Tested-by: Deren Wu <deren.wu@mediatek.com>
> > Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> > ---
> >  drivers/net/wireless/mediatek/mt76/mt7921/mcu.c | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c b/drivers/=
net/wireless/mediatek/mt76/mt7921/mcu.c
> > index f5a8f7fa4244..8e49df20a8cb 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> > @@ -458,7 +458,14 @@ mt7921_mcu_rx_unsolicited_event(struct mt7921_dev =
*dev, struct sk_buff *skb)
> > =20
> >  void mt7921_mcu_rx_event(struct mt7921_dev *dev, struct sk_buff *skb)
> >  {
> > -	struct mt7921_mcu_rxd *rxd =3D (struct mt7921_mcu_rxd *)skb->data;
> > +	struct mt7921_mcu_rxd *rxd;
> > +	int ret;
> > +
> > +	ret =3D skb_linearize(skb);
>=20
> is it true for sdio only? if so what about doing something like:
>=20
> if (mt76_is_sdio() && skb_linearize(skb))
> 	return;

please ignore this comment, it is already in skb_linearize()

>=20
> > +	if (ret)
> > +		return;
> > +
> > +	rxd =3D (struct mt7921_mcu_rxd *)skb->data;
> > =20
> >  	if (rxd->eid =3D=3D 0x6) {
> >  		mt76_mcu_rx_event(&dev->mt76, skb);
> > --=20
> > 2.25.1
> >=20


--pTOOomLTkB8wTJhp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYUH1tAAKCRA6cBh0uS2t
rMkyAQDUa3R2Xm/43qa/WcpdImu0zoJb2NOBQIPNJicSkJYLFQEAx99u7hzZHeFi
rHHCgQlXtyx6c+rtwKLoXbvCzLAlYgg=
=BEBo
-----END PGP SIGNATURE-----

--pTOOomLTkB8wTJhp--