Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: i+9UVPTFwUfV6rohwad8OZ9wlNfkG0v59OKc80FGq7yVWst9goGzsZ3Ow3YirifxoJCEruPbvA
 bH9aEEy1FHasKwZsHuNPVxhHS78Mv2yhAfp03FpfZb9fTAU6qErC49i3EzlId81BwMTZSt+r1q
 /ZBSyxVsvcyhv+jfsiA+0QMFju7VWV6jhQQwizs1I0g0nDg8cWi9ahLlvpAZ3Kqbhf8yQlbg6U
 g6WqnMplxOFRBSFRXUvY5jkewYw1aXrrAa6hMc/CdTtCXdx1JBdmCNIk3ZfQ5+YJmAprGsq7aw
 KrG1qmWc9DBvHJB++vX6w6Lm
From:   <Ajay.Kathat@microchip.com>
To:     <linux-wireless@vger.kernel.org>
CC:     <Claudiu.Beznea@microchip.com>, <Ajay.Kathat@microchip.com>
Subject: [PATCH v2 09/11] wilc1000: add 'initialized' flag check before adding
 an element to TX queue
Thread-Topic: [PATCH v2 09/11] wilc1000: add 'initialized' flag check before
 adding an element to TX queue
Thread-Index: AQHXqxrM213mtmxsUU2Uht1acpP20Q==
Date:   Thu, 16 Sep 2021 16:49:21 +0000
Message-ID: <20210916164902.74629-10-ajay.kathat@microchip.com>
References: <20210916164902.74629-1-ajay.kathat@microchip.com>
In-Reply-To: <20210916164902.74629-1-ajay.kathat@microchip.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?zwm0Ry8tM3P2Ewd2aCiUk4PKNc9AInFPc/Cf757VVnHWIELZimk5fKhT8h?=
 =?iso-8859-1?Q?+XieOLZhsfGMNtAh0REHcgeM9AcipOcG9OD6HIT6P0BEjCeso4VeeiikAI?=
 =?iso-8859-1?Q?GjsNOOZr3tzCaZt+QRkqeok9v9SBxykxyfA7wteKrlNsH0KlZtwrjhiF+m?=
 =?iso-8859-1?Q?AePBUYZ93rV0dWkH8HGlwsIvV6qE8mk0BT4WG2Y9hR/snKx4ztKYoG2x1g?=
 =?iso-8859-1?Q?TOZDMjwZBoCHElRyC/SR/zswTazwxoFiaetpCTKb/jfNsDiEGaT2YlZ1Zq?=
 =?iso-8859-1?Q?a7+GI9CakH97ITqzlszmLWrkE8X0UA3GB/b9Ge5sfLmv1GwJLFuKFzx/GC?=
 =?iso-8859-1?Q?2pWLP7zpIe88hWQMOH0/YQ7+YPETXhNodr8grNw19okXI3na6CzeZD6/Hn?=
 =?iso-8859-1?Q?MQSB+IO3b6m6lOM4xGJ0CvQbIji44eeEYQHv1LypiAFBhAyo1AjFlCtnF7?=
 =?iso-8859-1?Q?2mdNPaZD/ZxRKJPn36rRtwelK7SNIQeY9TzGGZQGteWIzL/v5TUgyR8pmK?=
 =?iso-8859-1?Q?LlGsorWdQjRY2/DZB4dBplEbhooqaMsQotSQgOtuUFE0HBPCvI35m8XzBh?=
 =?iso-8859-1?Q?ov6UVTK8xjKbC6wXxk3vX133ZX/6ekg1ISFo4ZaVCZu14Ks1n1VSBioiqV?=
 =?iso-8859-1?Q?xdEtW5x6+rSA7H8jLT/bB+Subwz8v4SpMYA8jRWjDdOUdDLlE6re6obNbb?=
 =?iso-8859-1?Q?7OVbpdmnZtbEYJMhZkH6+QKbYYt5q/SdBIrqkqzjEr10j70YttGWpjo8cs?=
 =?iso-8859-1?Q?GojIUcrijNege5ZfOaHk2b5CfBmPTT3Acx1F911Ckwv5G0k/zsAr06EJ0O?=
 =?iso-8859-1?Q?g1TRxbLGfOzGBIXp8xCkW906VTD2KVT7roXz0BzuURFM8aFlrEk3XfTD1f?=
 =?iso-8859-1?Q?W8YCMRfsz+lh3RVqsyUr8s4yK027rgE9h8eCLv/mvZU7CYFeXPoSt944Tq?=
 =?iso-8859-1?Q?vPY+9JHv7k0IJJfPJZXsBUqzdyQDW6HyF4an0nWOBs8KFXIoWe4K1Dj6ct?=
 =?iso-8859-1?Q?ZSSG49+8IurGeHeV3eJkrCfv99UUufwZBD+l7tTrTZHmL/pjI+ogc7jloU?=
 =?iso-8859-1?Q?jk6JIqTJldozaBsGUNlRpGod6cIMmnub9UDomd9KXhUft8aQuaMRnlixVB?=
 =?iso-8859-1?Q?t7usnUZTSlHuh14p5abH0e0ahbrhqUKX8jI3xNZH+GemQ5L9bmXSJgqk/c?=
 =?iso-8859-1?Q?/orX1xe2nifBxjZ++vuUMprxIetMU2KbFLopztMvumMzsOwWz9DH4Uqxva?=
 =?iso-8859-1?Q?EGZ598K/FfFHxHQhI70JUOYvOprAEzC/6gKKbUi5zrKVrhaPSKogAjFjin?=
 =?iso-8859-1?Q?gQcINPIHRl8eRPsGiw7D7OCrMrQ2aqV446vmv7uADgu3IEhW8WTgZl+ydW?=
 =?iso-8859-1?Q?BdESyVq4cp?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB4943.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f1dddd1-a4ed-42a9-265b-08d97931ef16
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2021 16:49:21.9557
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 54blTtq1upL9KWuK/OAsaUNAvuW/e3QGPOqd9VvEXBkqKpmG7J9dEvR/03heeYjTWy4n8Qe3EvkvTJR0M+YjqLJj8scQZviSHyda5VxNdXc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3990
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

From: Ajay Singh <ajay.kathat@microchip.com>

Add 'initialized' variable check before adding net/mgmt packet to TX queue
as safety check before passing the commands to the firmware.

Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
---
 drivers/net/wireless/microchip/wilc1000/cfg80211.c | 4 ++++
 drivers/net/wireless/microchip/wilc1000/wlan.c     | 9 +++++++++
 2 files changed, 13 insertions(+)

diff --git a/drivers/net/wireless/microchip/wilc1000/cfg80211.c b/drivers/n=
et/wireless/microchip/wilc1000/cfg80211.c
index 91a471f3b1c8..dc4bfe7be378 100644
--- a/drivers/net/wireless/microchip/wilc1000/cfg80211.c
+++ b/drivers/net/wireless/microchip/wilc1000/cfg80211.c
@@ -728,6 +728,7 @@ static int get_station(struct wiphy *wiphy, struct net_=
device *dev,
 {
 	struct wilc_vif *vif =3D netdev_priv(dev);
 	struct wilc_priv *priv =3D &vif->priv;
+	struct wilc *wilc =3D vif->wilc;
 	u32 i =3D 0;
 	u32 associatedsta =3D ~0;
 	u32 inactive_time =3D 0;
@@ -754,6 +755,9 @@ static int get_station(struct wiphy *wiphy, struct net_=
device *dev,
 	} else if (vif->iftype =3D=3D WILC_STATION_MODE) {
 		struct rf_info stats;
=20
+		if (!wilc->initialized)
+			return -EBUSY;
+
 		wilc_get_statistics(vif, &stats);
=20
 		sinfo->filled |=3D BIT_ULL(NL80211_STA_INFO_SIGNAL) |
diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.c b/drivers/net/w=
ireless/microchip/wilc1000/wlan.c
index de5287cd8652..ea81ef120fd1 100644
--- a/drivers/net/wireless/microchip/wilc1000/wlan.c
+++ b/drivers/net/wireless/microchip/wilc1000/wlan.c
@@ -427,6 +427,11 @@ int wilc_wlan_txq_add_net_pkt(struct net_device *dev,
 		return 0;
 	}
=20
+	if (!wilc->initialized) {
+		tx_complete_fn(tx_data, 0);
+		return 0;
+	}
+
 	tqe =3D kmalloc(sizeof(*tqe), GFP_ATOMIC);
=20
 	if (!tqe) {
@@ -476,6 +481,10 @@ int wilc_wlan_txq_add_mgmt_pkt(struct net_device *dev,=
 void *priv, u8 *buffer,
 		return 0;
 	}
=20
+	if (!wilc->initialized) {
+		tx_complete_fn(priv, 0);
+		return 0;
+	}
 	tqe =3D kmalloc(sizeof(*tqe), GFP_ATOMIC);
=20
 	if (!tqe) {
--=20
2.25.1