Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1574695pxb; Thu, 16 Sep 2021 10:11:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGSPq3ynCxFUCxM6DE6YedYI2vafRL27X0mM7LDyJi8xj5EjlRWXSeWSx+7aAnSxc45wNQ X-Received: by 2002:a17:906:a3d9:: with SMTP id ca25mr7326749ejb.306.1631812318625; Thu, 16 Sep 2021 10:11:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631812318; cv=none; d=google.com; s=arc-20160816; b=W2EAb68QWARVqqSJM3PJ9VJkq4L6WQkd5+TOhdQ035+eRhsG3yN23OEPGVB5tGrxbY 3Xfz3CCmwqURj8tYdULwVPBDRqQHFWgVkPQbV6hmjEaoS0mGoc3c5Kyoe+eZ8GnKKj8p XPMnkhSZDAe1Y6R3u6nx0y3fRcV0adKWCKytQl2PYqoG9UYmzTl2wyPEypLxDR2A3G4H bK7K3WuPu8h4VaLQX61WJHSyolFJ0bJxv64UsTlm4X/kjS9kJtBx2yNLZnIW+k899nr3 wct9pKPvcX9E1nX3488l/13THOOmSqiJeUtoN5Gt+8lYRVQTB6FwOmezodXMnpiYfKah Tzzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=DmiPM4+DKVgRQ+kqBq5DPFD0G7lXMNZyxKHvSLKf5RQ=; b=gx3sr2evwtMIHTBqX5VzCBuAAd+Y9UWj0mgol3jA+WLtmvsS0e4W1pU2U+dIRGd/fH oqzO+ZqFx23tvG9Y+hGOkHRqYOZqWzSsjQ6Y5a3OJo9I2+nnPMUQK42eAfRMwmGBWDFI kVB4e97MfCLF4gQ+fmVFjCQAk7op11r77gRPuHvy0RWWKZlik5MR9BkFbC0Ecg2lGZpA eYQbUkYza7w7i3QSr2fWeFAHtYHdBUzFTSFBOMWeUDA6SgdKeMLI5jl55vnDtXK5WKRX 4yuCoVKVcrFbmvFOlz9lyBOwb10UXPRuAY8u8wSDuXcG11xyThUCBEIxqEe0pktTTyQU TJNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=b19GzF2U; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cw22si1399541ejc.284.2021.09.16.10.11.35; Thu, 16 Sep 2021 10:11:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=b19GzF2U; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345080AbhIPRIw (ORCPT + 79 others); Thu, 16 Sep 2021 13:08:52 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:23684 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345336AbhIPRGu (ORCPT ); Thu, 16 Sep 2021 13:06:50 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1631811930; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=DmiPM4+DKVgRQ+kqBq5DPFD0G7lXMNZyxKHvSLKf5RQ=; b=b19GzF2Uh5Z/gaNiM8z8vtgqcVhbIdLy6u/1Gw16DL7YuPL13w9zbw/doJGoTRKSvJvDWm/9 kJuzlh1NwyF4RLoypdckYTXnLpF5Xi9EC91Zyv5ONOlwTTmutuXS5tGloCBguORb9lezM5Bq 3NYosxMwng26jhfDa3qgl4siATk= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 61437957e0f78151d65a15c5 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 16 Sep 2021 17:05:27 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 77DCEC359F8; Thu, 16 Sep 2021 17:05:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id D06CCC359F4; Thu, 16 Sep 2021 17:05:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org D06CCC359F4 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Kalle Valo To: Dan Carpenter Cc: Luca Coelho , Johannes Berg , Emmanuel Grumbach , Mordechay Goodstein , Sara Sharon , Naftali Goldstein , Dan Halperin , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/2] iwlwifi: mvm: d3: Fix off by ones in iwl_mvm_wowlan_get_rsc_v5_data() References: <20210831081802.GA9846@kili> Date: Thu, 16 Sep 2021 20:05:19 +0300 In-Reply-To: <20210831081802.GA9846@kili> (Dan Carpenter's message of "Tue, 31 Aug 2021 11:18:02 +0300") Message-ID: <87bl4sxxgw.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dan Carpenter writes: > These should be >= ARRAY_SIZE() instead of > ARRAY_SIZE() to prevent an > out of bounds write on the next line. > > Fixes: 79e561f0f05a ("iwlwifi: mvm: d3: implement RSC command version 5") > Signed-off-by: Dan Carpenter I think I should take both patches to v5.15. Luca, do you agree? Ack? I assigned these to me on patchwork. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches