Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH V2] ath10k: don't fail if IRAM write fails
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     ojab // <ojab@ojab.ru>, "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, ath10k@lists.infradead.org,
        Linux Wireless <linux-wireless@vger.kernel.org>,
        netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
References: <20210722193459.7474-1-ojab@ojab.ru>
 <CAKzrAgRt0jRFyFNjF-uq=feG-9nhCx=tTztCgCEitj1cpMk_Xg@mail.gmail.com>
 <CAKzrAgQgsN6=Cu4SvjSSFoJOqAkU2t8cjt7sgEsJdNhvM8f7jg@mail.gmail.com>
 <CAKzrAgSEiq-qOgetzryaE3JyBUe3URYjr=Fn0kz9sF7ZryQ5pA@mail.gmail.com>
 <538825a2-82f0-6102-01da-6e0385e53cf5@gmx.de> <87wnnav129.fsf@codeaurora.org>
From:   "sparks71@gmx.de" <sparks71@gmx.de>
Message-ID: <4656706a-a87d-1bf6-d125-b66af57157ca@gmx.de>
Date:   Tue, 21 Sep 2021 09:50:29 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <87wnnav129.fsf@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
Precedence: bulk

Am 21.09.21 um 09:29 schrieb Kalle Valo:
> "sparks71@gmx.de" <sparks71@gmx.de> writes:
>
>> Have you seen the new patch?
>>
>> https://www.mail-archive.com/ath10k@lists.infradead.org/msg13784.html
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=
=3Dmaster-pending&id=3D973de582639a1e45276e4e3e2f3c2d82a04ad0a6
>>
>>
>> could probably have been communicated better
> Yeah, apparently there are two different fixes now. I'll review both of
> them and try to choose which one to take.
>
I have tested both fixes (x86_64 2x QCA9984)

For me both of them work.

[PATCH V2] ath10k: don't fail if IRAM write fails:


[18245.610112] ath10k_pci 0000:03:00.0: pci irq msi oper_irq_mode 2
irq_mode 0 reset_mode 0
[18245.674800] ath10k_pci 0000:04:00.0: pci irq msi oper_irq_mode 2
irq_mode 0 reset_mode 0
[18245.731606] ath10k_pci 0000:03:00.0: qca9984/qca9994 hw1.0 target
0x01000000 chip_id 0x00000000 sub 168c:cafe
[18245.731620] ath10k_pci 0000:03:00.0: kconfig debug 0 debugfs 1
tracing 1 dfs 0 testmode 0
[18245.733172] ath10k_pci 0000:03:00.0: firmware ver 10.4-3.9.0.2-00152
api 5 features
no-p2p,mfp,peer-flow-ctrl,btcoex-param,allows-mesh-bcast,no-ps,peer-fixed-=
rate,iram-recovery
crc32 723f9771
[18245.790380] ath10k_pci 0000:04:00.0: qca9984/qca9994 hw1.0 target
0x01000000 chip_id 0x00000000 sub 168c:cafe
[18245.790383] ath10k_pci 0000:04:00.0: kconfig debug 0 debugfs 1
tracing 1 dfs 0 testmode 0
[18245.790703] ath10k_pci 0000:04:00.0: firmware ver 10.4-3.9.0.2-00152
api 5 features
no-p2p,mfp,peer-flow-ctrl,btcoex-param,allows-mesh-bcast,no-ps,peer-fixed-=
rate,iram-recovery
crc32 723f9771
[18246.963760] ath10k_pci 0000:03:00.0: board_file api 2 bmi_id 0:1
crc32 85498734
[18247.019699] ath10k_pci 0000:04:00.0: board_file api 2 bmi_id 0:2
crc32 85498734
[18249.514054] ath10k_pci 0000:03:00.0: No hardware memory
[18249.514057] ath10k_pci 0000:03:00.0: failed to copy target iram
contents: -12
[18249.570423] ath10k_pci 0000:04:00.0: No hardware memory
[18249.570426] ath10k_pci 0000:04:00.0: failed to copy target iram
contents: -12
[18249.620637] ath10k_pci 0000:03:00.0: htt-ver 2.2 wmi-op 6 htt-op 4
cal otp max-sta 512 raw 0 hwcrypto 1
[18249.678035] ath10k_pci 0000:04:00.0: htt-ver 2.2 wmi-op 6 htt-op 4
cal otp max-sta 512 raw 0 hwcrypto 1


ath10k: Fix device boot error:

[=C2=A0=C2=A0=C2=A0 3.318932] ath10k_pci 0000:03:00.0: pci irq msi oper_ir=
q_mode 2
irq_mode 0 reset_mode 0
[=C2=A0=C2=A0=C2=A0 3.377071] ath10k_pci 0000:04:00.0: pci irq msi oper_ir=
q_mode 2
irq_mode 0 reset_mode 0
[=C2=A0=C2=A0=C2=A0 3.434051] ath10k_pci 0000:03:00.0: qca9984/qca9994 hw1=
.0 target
0x01000000 chip_id 0x00000000 sub 168c:cafe
[=C2=A0=C2=A0=C2=A0 3.434054] ath10k_pci 0000:03:00.0: kconfig debug 0 deb=
ugfs 1
tracing 1 dfs 0 testmode 0
[=C2=A0=C2=A0=C2=A0 3.434412] ath10k_pci 0000:03:00.0: firmware ver 10.4-3=
.9.0.2-00152
api 5 features
no-p2p,mfp,peer-flow-ctrl,btcoex-param,allows-mesh-bcast,no-ps,peer-fixed-=
rate,iram-recovery
crc32 723f9771
[=C2=A0=C2=A0=C2=A0 3.487225] ath10k_pci 0000:04:00.0: qca9984/qca9994 hw1=
.0 target
0x01000000 chip_id 0x00000000 sub 168c:cafe
[=C2=A0=C2=A0=C2=A0 3.487229] ath10k_pci 0000:04:00.0: kconfig debug 0 deb=
ugfs 1
tracing 1 dfs 0 testmode 0
[=C2=A0=C2=A0=C2=A0 3.487568] ath10k_pci 0000:04:00.0: firmware ver 10.4-3=
.9.0.2-00152
api 5 features
no-p2p,mfp,peer-flow-ctrl,btcoex-param,allows-mesh-bcast,no-ps,peer-fixed-=
rate,iram-recovery
crc32 723f9771
[=C2=A0=C2=A0=C2=A0 4.665772] ath10k_pci 0000:03:00.0: board_file api 2 bm=
i_id 0:1
crc32 85498734
[=C2=A0=C2=A0=C2=A0 4.716549] ath10k_pci 0000:04:00.0: board_file api 2 bm=
i_id 0:2
crc32 85498734
[=C2=A0=C2=A0=C2=A0 7.423192] ath10k_pci 0000:04:00.0: htt-ver 2.2 wmi-op =
6 htt-op 4
cal otp max-sta 512 raw 0 hwcrypto 1
[=C2=A0=C2=A0=C2=A0 7.443109] ath10k_pci 0000:03:00.0: htt-ver 2.2 wmi-op =
6 htt-op 4
cal otp max-sta 512 raw 0 hwcrypto 1

the second fixes the error message completely and "IRAM recovery" seems
to work

best regards