Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp2734816pxb; Tue, 21 Sep 2021 06:36:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxVy3PprGjoEIMSwdIiD+IDnrah1wum7sY/e/cVdIHlCECY7hdUPKjzjOT83RX23/Krs49A X-Received: by 2002:a6b:5d0b:: with SMTP id r11mr10359iob.92.1632231384056; Tue, 21 Sep 2021 06:36:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632231384; cv=none; d=google.com; s=arc-20160816; b=h8OLbx7tU/bjuFYUhL3Epyx9cs+mEkLlECmWXxcflxIjmxDkmT2iXWPmT+j8/3pXZN MVhRYEHV9ehm/mDB3/kqLRuFbRb3q9aI9sVkuEe6ZaGxWXtqsm5IVVLdlsvfalofccqz IkKrO4KGNA2bUDT8hThZoN4LhPWaIvFEtNZMiLCpe5uqHemTTsjaq/18D6OGP1s6sRAN BqeQnS2LJNJywuUii/uH6Sy1g7/Ov9XsXSsTUGGodSkf9wUc5nKyMISRvJVZ/0y3Lki0 XvAa2cMRov5mVz2FH0KdsjO8N/PqukK3IQTrmQ8MH/dbVrRprTkpKE4dk7q3Bl0dmGq3 yqkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=rMsvCffFJ3+0N+6wyxdzibJjqJY2iTTL7lbHAhYm9rI=; b=t5QR60mmkwzK6Aj+04+PX5IEh1jfYipbVXfmF0VDm4siny8RBXZQBSg9jFhlvzAZH/ x5CPUTCaLmYHC8fPoqqKu5IcN8wlfVH7lbUU6rPFTudbSKsNDp4QiXUOFmMLcBIxJaWN bzV0UDWjF/vxC9Gv57lJ4+4lSwZBIdNv1SJCzaGizxtVwHnB3WAb9il+eM5Iv+I/TUef Oq36dNZATnxN02EcAHtlfYC/fWFUuoDSnea63bWI6UsNDtOMWe0RoGRekLjPXaYnJKIu NGBMS6+vnajXcs0nl7n8e496IId1LXN3IK9rtSJW0mOS9Kx3QfGO/jvyA/tAyqpFKb5m S0Qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=EfLUJprF; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ay23si16695223iob.33.2021.09.21.06.36.14; Tue, 21 Sep 2021 06:36:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=EfLUJprF; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233089AbhIUNgX (ORCPT + 77 others); Tue, 21 Sep 2021 09:36:23 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:33387 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233033AbhIUNgW (ORCPT ); Tue, 21 Sep 2021 09:36:22 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1632231294; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=rMsvCffFJ3+0N+6wyxdzibJjqJY2iTTL7lbHAhYm9rI=; b=EfLUJprFpIz/V9RxE4fJdMTLIkgz8Ytfp+EdVVhzZPo8JX1+ge/iHEP1g+eGJjMTM8PyWZlE 38cLnv9JedTzCZT3MJzoVRaAbESSIVyGKbpBe3nhSEywKE7XPM5wJhLhcoFfOn2+i04Bp/73 sSUIPJhosGEhoaJLV1BAwu0Gt80= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 6149df748b04ef8589697cad (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 21 Sep 2021 13:34:44 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id A7D1EC43616; Tue, 21 Sep 2021 13:34:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 97F55C4338F; Tue, 21 Sep 2021 13:34:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 97F55C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wcn36xx: Implement Idle Mode Power Save From: Kalle Valo In-Reply-To: <20210909153320.2624649-1-bryan.odonoghue@linaro.org> References: <20210909153320.2624649-1-bryan.odonoghue@linaro.org> To: Bryan O'Donoghue Cc: linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org, loic.poulain@linaro.org, benl@squareup.com, bryan.odonoghue@linaro.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210921133444.A7D1EC43616@smtp.codeaurora.org> Date: Tue, 21 Sep 2021 13:34:44 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Bryan O'Donoghue wrote: > Idle Mode Power Save (IMPS) is a power saving mechanism which when called > by wcn36xx will cause the radio hardware to enter power collapse. > > This particular call maps nicely to a simple conjunction/disjunction around > IEEE80211_CONF_CHANGE_IDLE and IEEE80211_CONF_IDLE. > > Here we enter idle when we are not associated with an AP. The kernel will > incrementally toggle idle on/off in the process of trying to establish a > connection, thus saving power until we are connected to the AP again, at > which point we give way to BMPS if power_save is on. > > We've validated that with IMPS an apq8039 device which has the wcn36xx > module loaded but, has not authenticated with an AP will get to VMIN on > suspend and will not without IMPS. > > Signed-off-by: Bryan O'Donoghue > Tested-by: Benjamin Li > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 0e159d2c0834 wcn36xx: Implement Idle Mode Power Save -- https://patchwork.kernel.org/project/linux-wireless/patch/20210909153320.2624649-1-bryan.odonoghue@linaro.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches