Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 49491C4360D
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Pkshih <pkshih@realtek.com>
Cc:     "tony0620emma\@gmail.com" <tony0620emma@gmail.com>,
        "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        Timlee <timlee@realtek.com>, Kevin Yang <kevin_yang@realtek.com>
Subject: Re: [PATCH 3/4] rtw88: support adaptivity for ETSI/JP DFS region
References: <20210802063140.25670-1-pkshih@realtek.com>
        <20210802063140.25670-4-pkshih@realtek.com>
        <87ilzo4gyr.fsf@codeaurora.org>
        <61a242c186bf453d80820d81e1c48464@realtek.com>
Date:   Tue, 21 Sep 2021 17:47:48 +0300
In-Reply-To: <61a242c186bf453d80820d81e1c48464@realtek.com> (Pkshih's message
        of "Mon, 30 Aug 2021 06:46:57 +0000")
Message-ID: <87y27qt27f.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Pkshih <pkshih@realtek.com> writes:

>> > --- a/drivers/net/wireless/realtek/rtw88/main.c
>> > +++ b/drivers/net/wireless/realtek/rtw88/main.c
>> > @@ -23,6 +23,7 @@ EXPORT_SYMBOL(rtw_disable_lps_deep_mode);
>> >  bool rtw_bf_support = true;
>> >  unsigned int rtw_debug_mask;
>> >  EXPORT_SYMBOL(rtw_debug_mask);
>> > +bool rtw_edcca_enabled = true;
>> 
>> You are making rtw_edcca_enabled per driver, should it instead be per
>> device? If something is changed via debugfs the assumption is that the
>> value is per device.
>> 
>> For example, let's say you have two rtw88 devices attached on the same
>> system, device A and B. If a user changes edcca via debugfs on device A
>> it will also change the state in device B. Is that the desired
>> functionality? If yes, I think you should add a comment to
>> rtw_edcca_enabled explaining that.
>> 
>
> As mentioned in commit message, the debugfs is expected to be used when debugging
> in noisy environment. In that case, we think all rtw88 devices will probably
> be affected. Besides, we believe that turning EDCCA off is a temporary state under
> debugging.
>
> Based on the two points, it seems no need to maintain rtw_edcca_enabled by device,
> so a comment will be added to explain this.

Ok, fair enough.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches