Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp2804974pxb; Tue, 21 Sep 2021 08:03:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYcxsWtE8jwWC7xS/JkzkEjNy6dcxMPho8/WIVMWRPP/Mdq79U7qQN1Ca2fUYCr4gbejOY X-Received: by 2002:a05:6602:2bd4:: with SMTP id s20mr358397iov.63.1632236637342; Tue, 21 Sep 2021 08:03:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632236637; cv=none; d=google.com; s=arc-20160816; b=qRa+PPayGeiIBKYz4Zl3/4r9IPdi7r518JWE/0y3Xd4a+YGSGge8WYkZfD9f5s6/n0 jQ77atU4RDfV/j5bztFKXMBn7e6/TMwRZG941LLM5sX/px07zbVPqPW2XYgzuK8f44DZ AIQvIr6O33hKpHFMbNQERUui+FLGgIjvvH1LV0FGd9/6FCGYX049sQW5TZ+NZeMSXfld JB5exJ/J3vjEHqEaBLZ7wKjWsxw4l0fO9fZB/7h0G0+B+ln8FMtJAe3fDTnJIbFOb9iu /lGot9D0RnO5YNQE6NDUIjtdEQjUdhY27X39CaecCxP15VGG1I75i0Mo74rwZee7CQva 2uXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=bsSyjO77usODxPNl9U4WuLitIVjcU7QWauyIkVpnW1I=; b=tUdym/zYRw6RvhbfDd3Jddeh71Nkmf7NkoVZoD+kfNGmRSIlBT6qxxHEqd03hxBWWP Poe6C6h9JFbH5k1hDRzTfIEod7NNpwiWFJp2roKyZjhkcBQT2cFZahqcOH4yn+bBO/yW UpQNJMv841C3bqNVUJ+BH+v2HRhuaDoUFjgjY3SPtmX5GGKN9hgN+4zBRP0a1dzt6VQT IMaUlyL/cmB12t7aXv24J1yciY7QBc6r4JLwB6T82sosjkGb0qGBlRPyEET+Kzy28Twl tXcgJ0yhYlA/Bfa/fkCpCtAOYKHg1mrjiGurheIJ+1dK3AgOKaJm0AjOKOH0M1yE0Rue kTlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=FyVRE3v7; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 3si238332jaj.119.2021.09.21.08.03.45; Tue, 21 Sep 2021 08:03:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=FyVRE3v7; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233826AbhIUPEu (ORCPT + 77 others); Tue, 21 Sep 2021 11:04:50 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:30249 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231874AbhIUPEu (ORCPT ); Tue, 21 Sep 2021 11:04:50 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1632236601; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=bsSyjO77usODxPNl9U4WuLitIVjcU7QWauyIkVpnW1I=; b=FyVRE3v7+vQvxSqTmTFIqyxUB2GgKNC5+Q8OSs6I5ENKOa07H2p5OGkiTCKcZNgSv1+++S/d 5LvrWYN/3tvtxaRrOw/ossGWNot5eO2gqLdvzP21aLrpYHmXUaO4hgqtkfmgoYpOopd2gYqK Thh4Sf7z+zBZY98H3X4WP4c9mQI= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 6149f41fbd6681d8edec436e (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 21 Sep 2021 15:02:55 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E59F6C4361B; Tue, 21 Sep 2021 15:02:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8888AC4338F; Tue, 21 Sep 2021 15:02:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 8888AC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH 1/9] mwifiex: Small cleanup for handling virtual interface type changes From: Kalle Valo In-Reply-To: <20210914195909.36035-2-verdre@v0yd.nl> References: <20210914195909.36035-2-verdre@v0yd.nl> To: =?utf-8?q?Jonas_Dre=C3=9Fler?= Cc: Amitkumar Karwar , Ganapathi Bhat , Sharvari Harisangam , Xinming Hu , "David S. Miller" , Jakub Kicinski , =?utf-8?q?Jonas_Dre=C3=9Fler?= , Tsuchiya Yuto , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Maximilian Luz , Andy Shevchenko , =?utf-8?q?Pali_Roh?= =?utf-8?q?=C3=A1r?= User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210921150254.E59F6C4361B@smtp.codeaurora.org> Date: Tue, 21 Sep 2021 15:02:54 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Jonas Dreßler wrote: > Handle the obvious invalid virtual interface type changes with a general > check instead of looking at the individual change. > > For type changes from P2P_CLIENT to P2P_GO and the other way round, this > changes the behavior slightly: We now still do nothing, but return > -EOPNOTSUPP instead of 0. Now that behavior was incorrect before and > still is, because type changes between these two types are actually > possible and supported, which we'll fix in a following commit. > > Signed-off-by: Jonas Dreßler 9 patches applied to wireless-drivers-next.git, thanks. babe2a332dc4 mwifiex: Small cleanup for handling virtual interface type changes abe3a2c9ead8 mwifiex: Use function to check whether interface type change is allowed c2e9666cdffd mwifiex: Run SET_BSS_MODE when changing from P2P to STATION vif-type 54350dac4e6a mwifiex: Use helper function for counting interface types fae2aac8c740 mwifiex: Update virtual interface counters right after setting bss_type 25bbec30a2c7 mwifiex: Allow switching interface type from P2P_CLIENT to P2P_GO 5e2e1a4bf4a1 mwifiex: Handle interface type changes from AP to STATION c606008b7062 mwifiex: Properly initialize private structure on interface type changes 72e717500f99 mwifiex: Fix copy-paste mistake when creating virtual interface -- https://patchwork.kernel.org/project/linux-wireless/patch/20210914195909.36035-2-verdre@v0yd.nl/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches