Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] dt: bindings: net: mt76: add eeprom-data property
To:     Daniel Golle <daniel@makrotopia.org>,
        linux-mediatek@lists.infradead.org, linux-wireless@vger.kernel.org,
        devicetree@vger.kernel.org
Cc:     Ryder Lee <ryder.lee@mediatek.com>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>
References: <YSWdv7ZKz7SBtF+v@makrotopia.org>
From:   Felix Fietkau <nbd@nbd.name>
Message-ID: <de40bcd3-d730-4d6b-27d0-50492fe18404@nbd.name>
Date:   Fri, 24 Sep 2021 19:14:47 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <YSWdv7ZKz7SBtF+v@makrotopia.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2021-08-25 03:33, Daniel Golle wrote:
> EEPROM data for mt76 can be embedded into device-tree as an array.
> 
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
>  .../devicetree/bindings/net/wireless/mediatek,mt76.yaml      | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> index 3e2c2e43175e5..1489d3c1cd6ec 100644
> --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> @@ -47,6 +47,11 @@ properties:
>  
>    ieee80211-freq-limit: true
>  
> +  mediatek,eeprom-data:
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
Given that the driver patch simply uses memcpy on the data, shouldn't we
use an uint8-array here?

- Felix