Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 27 Sep 2021 08:08:29 +0800
From:   Shawn Guo <shawn.guo@linaro.org>
To:     Soeren Moch <smoch@web.de>
Cc:     Kalle Valo <kvalo@codeaurora.org>, stable@vger.kernel.org,
        Arend van Spriel <aspriel@gmail.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Chi-hsien Lin <chi-hsien.lin@infineon.com>,
        Wright Feng <wright.feng@infineon.com>,
        Chung-hsien Hsu <chung-hsien.hsu@infineon.com>,
        linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "brcmfmac: use ISO3166 country code and 0 rev as
 fallback"
Message-ID: <20210927000828.GE9901@dragon>
References: <20210926201905.211605-1-smoch@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210926201905.211605-1-smoch@web.de>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Sun, Sep 26, 2021 at 10:19:05PM +0200, Soeren Moch wrote:
> This reverts commit b0b524f079a23e440dd22b04e369368dde847533.
> 
> Commit b0b524f079a2 ("brcmfmac: use ISO3166 country code and 0 rev
> as fallback") changes country setup to directly use ISO3166 country
> codes if no more specific code is configured. This was done under
> the assumption that brcmfmac firmwares can handle such simple
> direct mapping from country codes to firmware ccode values.
> 
> Unfortunately this is not true for all chipset/firmware combinations.
> E.g. BCM4359/9 devices stop working as access point with this change,
> so revert the offending commit to avoid the regression.
> 
> Signed-off-by: Soeren Moch <smoch@web.de>
> Cc: stable@vger.kernel.org  # 5.14.x

Acked-by: Shawn Guo <shawn.guo@linaro.org>