Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp3970661pxb; Mon, 27 Sep 2021 06:46:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvIFWnom++n1ql9EizhFwFeYy2RGTKsza/sSjiLcw4LFtrDVZPPlGWL4P7/PIRrOT5Fetu X-Received: by 2002:a17:902:b102:b0:134:a329:c2f8 with SMTP id q2-20020a170902b10200b00134a329c2f8mr68586plr.71.1632750391904; Mon, 27 Sep 2021 06:46:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632750391; cv=none; d=google.com; s=arc-20160816; b=ccUw9Wqta35WSyb5Z9KgNP5a0qTWtR7Gcu1RwwehvFPrRNjark4/9+2xMfjJI99Wan cCqiRyeAit8X+36C8XPIYG0e0WM53e06Ai1i5rdTnb2qHMyspuSXv7XUGIwaSCvoGvxN 3R2ApefH7fKJfFJJw8ErtiVDqr1yCSuY88FV6lRmP1tS0Mpx+UY0B6dgYmB8blcUAld4 jkCHCdpqF3tMBtKkzDVc7XyTqJU5d0xLcDDwyY3oBp8scg2aIV9sMFESXifSvvuwoKz/ NvBmiVTEx2YCM9VqNiGhFtBTMeAHnejxhsS6k13Fx1ZqrPZBzl7ECTxlA1EPlAa3kiP3 2mmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=3HB/k/I8QIn61ekO+bGy12NdBrVnuuc7rW3xgyTXOkM=; b=HbAXImCAPlj3tO0nuBg/OrawO3bi28DYhtU6ilvWxzgyB2J9wK9ZMF829+5wiRiKQv 4abnHa2tt9bAf6VOaWj/mtdGkEEp3dxotKbXUSOQVebCYOz/BxJpEWG8S58bHlpW2i3V VXnsyPqIUP+fvmN3frNvHEi/Vnm41gS/EcXKXpvrotHMjJsU39bvImtCKlSIpvso7QgF jkTXHkdqqo6rTALU1U25uMv/4MkYXrea/sgQISJj54mfLwAnqrWixH+hDhK5zcrSh5uz 8rjP17YP8l3ooP02aM1fO7ARbAKqG2CEaMIgEi59t5w09tCF3hF8gIpRDyXZTjHswwIv sVQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VMdzJOTM; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c9si13399674plg.106.2021.09.27.06.46.09; Mon, 27 Sep 2021 06:46:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VMdzJOTM; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234584AbhI0No7 (ORCPT + 78 others); Mon, 27 Sep 2021 09:44:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234114AbhI0No6 (ORCPT ); Mon, 27 Sep 2021 09:44:58 -0400 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2C4EC061575; Mon, 27 Sep 2021 06:43:20 -0700 (PDT) Received: by mail-ot1-x32a.google.com with SMTP id 67-20020a9d0449000000b00546e5a8062aso24441007otc.9; Mon, 27 Sep 2021 06:43:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3HB/k/I8QIn61ekO+bGy12NdBrVnuuc7rW3xgyTXOkM=; b=VMdzJOTMPuyYImQkcriovhY8uaX/CTuVP3a+mcriuHSJ/BHIWtMTaPiE5si3BJy54W apvKBtQ0p1nmPcVZaLZOx2Te6rW5sPSsK9YnFyyegNnUKR5zF9/cD2hm35NhhzHF8/nd RVymoZR/pWlVnxH/jOJVEXwsEgO9eVf6Ll233WFVu/QPdDsfDTFaiCRcioRdD88Yrzu9 0D0nTwp+MBlHsjsgOS6lNpi69emqPr/jJs1ff762IY3EK94sjzx7RoEXf5CyCQ87BC1A 9FpvEtllJifTeaxQOazInhBtqM6ahAe3UFTZmPkm3ifta2LTuM1db2N1WWzHcPs1Pn// 1UrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3HB/k/I8QIn61ekO+bGy12NdBrVnuuc7rW3xgyTXOkM=; b=ZHCzuene99ZElMqnfM3Hdx85K9VAZkc/qd3V5C4oc5KmbVQnTcKNWZhrMSMamWZ/FB Rd/QWL/TpK0TaJuSfNnQO9/UrzsfioYCEbMQv3oCdGzonkAiFxwzbid9WwjAtYjtzDI9 bxczwDRzcb3VLIJqIPNhFRmkZAJdyXt6xBWS0DZ2YkFhdUBZ9zS/EF0+vzdEZnjT+SSm G3UM7VGMf0hjXvULhccMYXaqy23RL19mE/rYfGqACpxyg+gScJwthsppgQ1HVA9Biq+U HXLK1/YzdDjDnDhacMdLvfZfWFzUEn5hRf7vR+MGZWia+pyD2QR9kQaQRlASr1bNkZlw czcA== X-Gm-Message-State: AOAM5319VCNynaXmLGzb0WGLhm0EP9w0EsSN9P1xPFWhs8j0JpjdyHoV LzHq/isiYdZzTIsFBAcBln2XrO/iFcOcEQ== X-Received: by 2002:a05:6830:793:: with SMTP id w19mr76512ots.23.1632750199971; Mon, 27 Sep 2021 06:43:19 -0700 (PDT) Received: from Davids-MacBook-Pro.local ([8.48.134.30]) by smtp.googlemail.com with ESMTPSA id p9sm3728198ots.66.2021.09.27.06.43.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Sep 2021 06:43:19 -0700 (PDT) Subject: Re: [PATCH net-next v4 2/3] net: ipv6: check return value of rhashtable_init To: MichelleJin , davem@davemloft.net, kuba@kernel.org, yoshfuji@linux-ipv6.org, dsahern@kernel.org, johannes@sipsolutions.net Cc: saeedm@nvidia.com, leon@kernel.org, roid@nvidia.com, paulb@nvidia.com, ozsh@nvidia.com, lariel@nvidia.com, cmi@nvidia.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org References: <20210927033457.1020967-1-shjy180909@gmail.com> <20210927033457.1020967-3-shjy180909@gmail.com> From: David Ahern Message-ID: Date: Mon, 27 Sep 2021 07:43:17 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210927033457.1020967-3-shjy180909@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 9/26/21 9:34 PM, MichelleJin wrote: > When rhashtable_init() fails, it returns -EINVAL. > However, since error return value of rhashtable_init is not checked, > it can cause use of uninitialized pointers. > So, fix unhandled errors of rhashtable_init. > > Signed-off-by: MichelleJin > --- Reviewed-by: David Ahern