Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <f300c9d2aae4b9b0e654f8a1e26c6e64beef7132.camel@sipsolutions.net>
Subject: Re: [PATCH] mac80211: fix incorrect nss config
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Thiraviyam Mariyappan <tmariyap@codeaurora.org>,
        ath11k@lists.infradead.org
Cc:     linux-wireless@vger.kernel.org
Date:   Mon, 27 Sep 2021 17:01:32 +0200
In-Reply-To: <1632750104-1722-1-git-send-email-tmariyap@codeaurora.org>
References: <1632750104-1722-1-git-send-email-tmariyap@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 2021-09-27 at 19:11 +0530, Thiraviyam Mariyappan wrote:
> In HE capabilities, HE-MCS Rx map field filled with value 0x3 for all eight
> spatial streams if txrx chains configured as incorrect value.
> This patch changes configure at least single spatial stream for HE-MCS
> 0 to 7 in all supported channel widths if nss configured as incorrect
> value.
> 
> Signed-off-by: Thiraviyam Mariyappan <tmariyap@codeaurora.org>
> ---
>  net/mac80211/he.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/net/mac80211/he.c b/net/mac80211/he.c
> index c05af70..ee113ff5 100644
> --- a/net/mac80211/he.c
> +++ b/net/mac80211/he.c
> @@ -151,6 +151,13 @@ ieee80211_he_cap_ie_to_sta_he_cap(struct ieee80211_sub_if_data *sdata,
>  		       &he_cap_ie[sizeof(he_cap->he_cap_elem) + mcs_nss_size],
>  		       he_ppe_size);
>  
> 
> +	if (he_cap->he_mcs_nss_supp.rx_mcs_80 == cpu_to_le16(0xFFFF)) {
> +		he_cap->has_he = false;
> +		sdata_info(sdata, "Ignoring HE IE from %pM due to incorrect rx_mcs_80\n",
> +			   sta->addr);
> +		return;
> +	}

Like so many other workarounds, this should probably come with a comment
as to _why_ we're doing this, ideally including the model/firmware
version ...

johannes