Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4630421pxb; Mon, 27 Sep 2021 23:44:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFAwLT0GeWCtZ+Mx1xQNZb+zdcwLU5uibhcCN+U0ySv0JCJDT4KnWZMh5+E3IkEc/4cv+B X-Received: by 2002:a17:902:e88a:b0:13c:9ca3:f724 with SMTP id w10-20020a170902e88a00b0013c9ca3f724mr3819704plg.10.1632811465350; Mon, 27 Sep 2021 23:44:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632811465; cv=none; d=google.com; s=arc-20160816; b=D+oNZAlaUxnJhcV/nyoK5EgM62vv7zkoEPfz8SUX8UCfbiEJ2YMVvCsdc5za4rMK18 fHrPmF+AwpNHPMzyVhul5URh5CNtaSs+uytl76s2SShqgJXCtGQ+IwefzFrqLEYvue/7 dnkebu3PL87r4V6ldFUj7ITV6NGQWjyCTkug7Rkg5dzzoerfFmof1pKu+4fksR0+qpCa grCaeDqpC5ZV4VN407ebTplpBjsGoymc0Ty8nWw/bJs7MlPQRCIPBytc8Vn1xeRKGu4R xMnjx7WTznfcPiBMiM+Oak0wDIKMUfaR8FRBDrshqZXf+sBgRgy8yARix9Nj5WvdAF04 LUcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=x8KORn26l3Mm682yXCu4AC83A+TMlzb+xY8KDLZycGs=; b=nxABWUG6bRu+/Pqu3LrqjSrsd1DHysYE2ELuMJ31j1gf36MdijSLrY3fuSrn8DARao j+LBWNGqu53SPN4lEP7Zfuo71JLrrsjuXFY5BQy7IQ4frqhZisfLBcbz60WIP2agUmKY pM4FSCx8BGaujAzmf1/gvHRN28cKdAKlE+MGpdHmBwMkTyWuHs911QBmQ2zw4gO+O2eV 16nzGxY/uK9fHcGhM9XDRu7RobhmA+WjDD8QjTAX9j2Jue0qYdT0kOxRUgBAGfIh70HF 3IhTpSBv43G6gJNNPEMT2E74JPVLqY9A4JIDDUKKr17TKgNjQXAvVNF9RrtSyR3jq7Kj ZG9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="wAl4vX/B"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t71si21351227pgd.272.2021.09.27.23.44.08; Mon, 27 Sep 2021 23:44:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="wAl4vX/B"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239000AbhI1GpW (ORCPT + 78 others); Tue, 28 Sep 2021 02:45:22 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:52525 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238924AbhI1GpV (ORCPT ); Tue, 28 Sep 2021 02:45:21 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1632811423; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=x8KORn26l3Mm682yXCu4AC83A+TMlzb+xY8KDLZycGs=; b=wAl4vX/Byu9gRtRuBn3usxdAQt92vGFokTjCxJ+C/FI96C6OmcbLyluS9t8lGRnM86xSEE/s xPG0+Gul6pB+/uSubwGKPNxfoFrm8zcAOqfF8Rtm0Xl0rGqFGo1KP1pug6G6k7ntRBPDCgYJ 4Axc95FsX1Alkx03HJcYhIaVJuA= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 6152b99c8578ef11edda797a (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 28 Sep 2021 06:43:40 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 4ED82C43617; Tue, 28 Sep 2021 06:43:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 71802C4338F; Tue, 28 Sep 2021 06:43:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 71802C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Kalle Valo To: Arnd Bergmann Cc: Amitkumar Karwar , Ganapathi Bhat , Sharvari Harisangam , Xinming Hu , Arnd Bergmann , "David S. Miller" , Jakub Kicinski , Nathan Chancellor , Nick Desaulniers , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] mwifiex: avoid null-pointer-subtraction warning References: <20210927121656.940304-1-arnd@kernel.org> Date: Tue, 28 Sep 2021 09:43:32 +0300 In-Reply-To: <20210927121656.940304-1-arnd@kernel.org> (Arnd Bergmann's message of "Mon, 27 Sep 2021 14:16:35 +0200") Message-ID: <87wnn1qjxn.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Arnd Bergmann writes: > From: Arnd Bergmann > > clang complains about some NULL pointer arithmetic in this driver: > > drivers/net/wireless/marvell/mwifiex/sta_tx.c:65:59: error: performing pointer subtraction with a null pointer has undefined behavior [-Werror,-Wnull-pointer-subtraction] > pad = ((void *)skb->data - (sizeof(*local_tx_pd) + hroom)- > ^ > drivers/net/wireless/marvell/mwifiex/uap_txrx.c:478:53: error: performing pointer subtraction with a null pointer has undefined behavior [-Werror,-Wnull-pointer-subtraction] > pad = ((void *)skb->data - (sizeof(*txpd) + hroom) - NULL) & > > Rework that expression to do the same thing using a uintptr_t. > > Signed-off-by: Arnd Bergmann I'll queue this to v5.15. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches