Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: wgong=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date:   Tue, 28 Sep 2021 17:05:16 +0800
From:   Wen Gong <wgong@codeaurora.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v4 4/6] cfg80211: save power spectral density(psd) of
 regulatory rule
In-Reply-To: <a4e56dbbe88771456bcf3051a0891d66d5e34fd4.camel@sipsolutions.net>
References: <20210924100052.32029-1-wgong@codeaurora.org>
 <20210924100052.32029-5-wgong@codeaurora.org>
 <a4e56dbbe88771456bcf3051a0891d66d5e34fd4.camel@sipsolutions.net>
Message-ID: <5b40dee9ca9d91bb0ca6aaa82deae370@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-09-27 19:27, Johannes Berg wrote:
> On Fri, 2021-09-24 at 06:00 -0400, Wen Gong wrote:
>> The power spectral density(psd) of regulatory rule should be take
>> effect to the channels. This patch is to save the values to the
>> channel which has psd value.
>> 
>> Signed-off-by: Wen Gong <wgong@codeaurora.org>
>> ---
>>  net/wireless/reg.c | 17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
>> 
>> diff --git a/net/wireless/reg.c b/net/wireless/reg.c
>> index df87c7f3a049..8f765befb9bc 100644
>> --- a/net/wireless/reg.c
>> +++ b/net/wireless/reg.c
>> @@ -1590,6 +1590,8 @@ static u32 map_regdom_flags(u32 rd_flags)
>>  		channel_flags |= IEEE80211_CHAN_NO_160MHZ;
>>  	if (rd_flags & NL80211_RRF_NO_HE)
>>  		channel_flags |= IEEE80211_CHAN_NO_HE;
>> +	if (rd_flags & NL80211_RRF_PSD)
>> +		channel_flags |= IEEE80211_CHAN_PSD;
> 
> I went to go squash this with patch 3 and took a closer look, and then 
> I
> realized you're doing this weird.
> 
> Please when you resend also squash this - it's a bit weird to read in
> two patches.
> 
> However, I think this is missing a lot of things - we already talked
> about the regulatory database, and while that'd be nice, I guess I
> conceded that you don't really have to do it now.
> 
> However, for visibility reasons, I *really* think you need to add
> nl80211 attributes for all of this data - when the regdomain is dumped
> in nl80211_put_regdom() you would have the flag now (it dumps the value
> of reg_rule->flags in NL80211_ATTR_REG_RULE_FLAGS), but you didn't add
> the value of reg_rule->psd which you've added.
> 
> Similarly, you're not adding the PSD flag nor the PSD value for the
> *channel* in nl80211_msg_put_channel(), both of which I think you 
> should
> have for visibility into what's going on in the kernel/driver.
> 
> I've applied all the other patches, so please just resend 3 and 4,
> squashed into a single patch, with the fixes.
> 

Thanks

I have sent "[PATCH v5] cfg80211: save power spectral density(psd) of 
regulatory rule"
for this.

> johannes