Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <90a894c9b8e38faaf5f324bd7ed390bb1abaf9c5.camel@sipsolutions.net>
Subject: Re: [PATCH v12 4/4] mac80211: MBSSID channel switch
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Aloka Dixit <alokad@codeaurora.org>, linux-wireless@vger.kernel.org
Date:   Tue, 28 Sep 2021 11:49:10 +0200
In-Reply-To: <20210916025437.29138-5-alokad@codeaurora.org>
References: <20210916025437.29138-1-alokad@codeaurora.org>
         <20210916025437.29138-5-alokad@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 2021-09-15 at 19:54 -0700, Aloka Dixit wrote:
> 
> diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
> index 23fa0bb49be2..88fbed46e1bc 100644
> --- a/net/mac80211/cfg.c
> +++ b/net/mac80211/cfg.c
> @@ -3271,8 +3271,19 @@ void ieee80211_csa_finish(struct ieee80211_vif *vif)
>  {
>  	struct ieee80211_sub_if_data *sdata = vif_to_sdata(vif);
>  
> 
> 
> 
> -	ieee80211_queue_work(&sdata->local->hw,
> -			     &sdata->csa_finalize_work);
> +	if (vif->mbssid_tx_vif == vif) {
> +		struct ieee80211_sub_if_data *child, *tmp;
> +
> +		list_for_each_entry_safe(child, tmp,
> +					 &sdata->local->interfaces, list)

I don't see any reason to believe that this list iteration should be
safe?

johannes