Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 17DB7C4338F
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] ath10k: sdio: Add missing BH locking around
 napi_schdule()
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <20210824144339.2796122-1-festevam@denx.de>
References: <20210824144339.2796122-1-festevam@denx.de>
To:     Fabio Estevam <festevam@denx.de>
Cc:     kuba@kernel.org, ath10k@lists.infradead.org,
        linux-wireless@vger.kernel.org, paulmck@kernel.org, marex@denx.de,
        wgong@codeaurora.org, alagusankar@silex-india.com,
        erik.stromdahl@gmail.com, Fabio Estevam <festevam@denx.de>
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-Id: <20210928143611.183D7C4360C@smtp.codeaurora.org>
Date:   Tue, 28 Sep 2021 14:36:11 +0000 (UTC)
Precedence: bulk

Fabio Estevam <festevam@denx.de> wrote:

> On a i.MX-based board with a QCA9377 Wifi chip, the following errors
> are seen after launching the 'hostapd' application:
> 
> hostapd /etc/wifi.conf
> Configuration file: /etc/wifi.conf
> wlan0: interface state UNINITIALIZED->COUNTRY_UPDATE
> NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #08!!!
> Using interface wlan0 with hwaddr 00:1f:7b:31:04:a0 and ssid "thessid"
> IPv6: ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
> wlan0: interface state COUNTRY_UPDATE->ENABLED
> wlan0: AP-ENABLED
> NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #08!!!
> NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #08!!!
> NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #08!!!
> NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #08!!!
> ...
> 
> Fix this problem by adding the BH locking around napi-schedule(),
> in the same way it was done in commit e63052a5dd3c ("mlx5e: add
> add missing BH locking around napi_schdule()").
> 
> Its commit log provides the following explanation:
> 
> "It's not correct to call napi_schedule() in pure process
> context. Because we use __raise_softirq_irqoff() we require
> callers to be in a context which will eventually lead to
> softirq handling (hardirq, bh disabled, etc.).
> 
> With code as is users will see:
> 
> NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #08!!!
> "
> 
> Fixes: cfee8793a74d ("ath10k: enable napi on RX path for sdio")
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

019edd01d174 ath10k: sdio: Add missing BH locking around napi_schdule()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210824144339.2796122-1-festevam@denx.de/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches