Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: vnaralas=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 29 Sep 2021 22:16:32 +0530
From:   Venkateswara Naralasetty <vnaralas@codeaurora.org>
To:     Wen Gong <wgong@codeaurora.org>
Cc:     johannes@sipsolutions.net, ath11k@lists.infradead.org,
        linux-wireless@vger.kernel.org, wgong=codeaurora.org@codeaurora.org
Subject: Re: [PATCH v5] cfg80211: save power spectral density(psd) of
 regulatory rule
In-Reply-To: <cb20427eae96c4551084e4c899618b94@codeaurora.org>
References: <20210928085211.26186-1-wgong@codeaurora.org>
 <bd649a3d2cf2ea9064d427d633055891@codeaurora.org>
 <cb20427eae96c4551084e4c899618b94@codeaurora.org>
Message-ID: <2afb1bf6f06cb53f43fe0d354afa4e7c@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-09-29 09:07, Wen Gong wrote:
> On 2021-09-28 21:12, vnaralas@codeaurora.org wrote:
>> On 2021-09-28 14:22, Wen Gong wrote:
>>> 6 GHz regulatory domains introduces power spectral density(psd).
>>> The power spectral density(psd) of regulatory rule should be take
>>> effect to the channels. Save the values to the channel which has
>>> psd value and add nl80211 attributes for it.
>>> 
>>> Signed-off-by: Wen Gong <wgong@codeaurora.org>
>>> ---
> ...
>>> 
>>> @@ -2540,6 +2554,9 @@ static void handle_channel_custom(struct wiphy 
>>> *wiphy,
>>>  			chan->dfs_cac_ms = IEEE80211_DFS_MIN_CAC_TIME_MS;
>>>  	}
>>> 
>>> +	if (chan->flags & IEEE80211_CHAN_PSD)
>>> +		chan->psd = reg_rule->psd;
>>> +
>>>  	chan->max_power = chan->max_reg_power;
>> 
>> What about the case AP + STA concurrency? are we going to overwrite
>> the PSD power and channel flags?
>> 
> 
> Hi Venkateswara,
> 
> This patch is not relation with AP + STA concurrency.
> For example, it also has other power intersection in
> handle_channel_adjacent_rules().
> 
> 		chan->max_reg_power =
> 			min_t(int, MBM_TO_DBM(power_rule1->max_eirp),
> 			      MBM_TO_DBM(power_rule2->max_eirp));
> 
> For AP + STA concurrency, it should to maintain 2 group of reg rules,
> one is for AP, another is for STA.

Can we maintain two power rules in the same channel one for AP and one 
for STA. In this way, we can update the power rules in the same channel 
for both AP and STA from the reg rules.

Otherwise, we need to maintain multiple channel lists in sband for all 
supported power mode combinations to apply the respective power rules 
and build channel flags from the multiple reg rules.
right?

> This patch is to handle PSD info in the same reg rules.
> It is to process only one reg rule in the reg rules.
> AP + STA concurrency is a higher level things than this patch.
>>>  }