Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org D65BDC4338F
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Exuvo <exuvo@exuvo.se>
Cc:     Stanislaw Gruszka <sgruszka@redhat.com>,
        linux-wireless@vger.kernel.org,
        Helmut Schaa <helmut.schaa@googlemail.com>,
        regressions@lists.linux.dev
Subject: Re: rt2x00 regression
References: <bff7d309-a816-6a75-51b6-5928ef4f7a8c@exuvo.se>
        <20190927080303.GA7667@redhat.com>
        <CA+GwT0B5SyRZnGLqwqOeuJK4CWMVc=dKaWre9VN8KQC6kBzKGw@mail.gmail.com>
        <20191203075736.GA701@redhat.com>
        <d74dab51-3a84-9035-d89e-ea8f63e89198@exuvo.se>
        <a8eeb0bc-95da-291a-7fb9-5d15d1174c27@exuvo.se>
        <c22673af-40e0-3af2-5ab7-69b23fc03598@exuvo.se>
        <f935dc15-08bd-2e28-fc1b-b27634c618be@exuvo.se>
Date:   Fri, 01 Oct 2021 09:56:32 +0300
In-Reply-To: <f935dc15-08bd-2e28-fc1b-b27634c618be@exuvo.se> (Exuvo's message
        of "Wed, 29 Sep 2021 10:22:50 +0200")
Message-ID: <87czop5j33.fsf@tynnyri.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

(adding regressions list for easier tracking)

Exuvo <exuvo@exuvo.se> writes:

> I would like to get this resolved, is there any more information you need=
 from me?
>
> I have been manually patching this all year with:
>
> drivers/net/wireless/ralink/rt2x00/rt2x00usb.c
> - if (rt2x00dev->num_proto_errs > 8)
> -=C2=A0=C2=A0=C2=A0 return true;
>
> It seems to just be some part of rt2800_load_firmware that is not
> supported on my device and generating errors but it has been running
> without problems in AP mode with daily usage.

[...]

>>>>>>> This most likely is the problem introduced by commit:
>>>>>>>
>>>>>>> commit e383c70474db32b9d4a3de6dfbd08784d19e6751
>>>>>>> Author: Stanislaw Gruszka <sgruszka@redhat.com>
>>>>>>> Date:   Tue Mar 12 10:51:42 2019 +0100
>>>>>>>
>>>>>>>      rt2x00: check number of EPROTO errors
>>>>>>>
>>>>>>> Plase check below patch that increase number of EPROTO checks
>>>>>>> before marking device removed. If it does not help, plese
>>>>>>> check if reverting above commits helps.

Should we do a revert? Can someone submit that including an explanation
of the regression.

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes