Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 08EC7C4338F
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Jerome Pouiller <Jerome.Pouiller@silabs.com>
Cc:     linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "David S . Miller" <davem@davemloft.net>,
        devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        linux-mmc@vger.kernel.org,
        Pali =?utf-8?Q?Roh?= =?utf-8?Q?=C3=A1r?= <pali@kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH v7 21/24] wfx: add debug.c/debug.h
References: <20210920161136.2398632-1-Jerome.Pouiller@silabs.com>
        <20210920161136.2398632-22-Jerome.Pouiller@silabs.com>
Date:   Fri, 01 Oct 2021 15:01:20 +0300
In-Reply-To: <20210920161136.2398632-22-Jerome.Pouiller@silabs.com> (Jerome
        Pouiller's message of "Mon, 20 Sep 2021 18:11:33 +0200")
Message-ID: <87o889j6nj.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Jerome Pouiller <Jerome.Pouiller@silabs.com> writes:

> From: J=C3=A9r=C3=B4me Pouiller <jerome.pouiller@silabs.com>
>
> Signed-off-by: J=C3=A9r=C3=B4me Pouiller <jerome.pouiller@silabs.com>

[...]

> +static int wfx_ps_timeout_set(void *data, u64 val)
> +{
> +	struct wfx_dev *wdev =3D (struct wfx_dev *)data;
> +	struct wfx_vif *wvif;
> +
> +	wdev->force_ps_timeout =3D val;
> +	wvif =3D NULL;
> +	while ((wvif =3D wvif_iterate(wdev, wvif)) !=3D NULL)
> +		wfx_update_pm(wvif);
> +	return 0;
> +}
> +
> +static int wfx_ps_timeout_get(void *data, u64 *val)
> +{
> +	struct wfx_dev *wdev =3D (struct wfx_dev *)data;
> +
> +	*val =3D wdev->force_ps_timeout;
> +	return 0;
> +}
> +
> +DEFINE_DEBUGFS_ATTRIBUTE(wfx_ps_timeout_fops, wfx_ps_timeout_get,
> wfx_ps_timeout_set, "%lld\n");
> +
> +int wfx_debug_init(struct wfx_dev *wdev)
> +{
> +	struct dentry *d;
> +
> +	d =3D debugfs_create_dir("wfx", wdev->hw->wiphy->debugfsdir);
> +	debugfs_create_file("counters", 0444, d, wdev, &wfx_counters_fops);
> +	debugfs_create_file("rx_stats", 0444, d, wdev, &wfx_rx_stats_fops);
> +	debugfs_create_file("tx_power_loop", 0444, d, wdev,
> +			    &wfx_tx_power_loop_fops);
> +	debugfs_create_file("send_pds", 0200, d, wdev, &wfx_send_pds_fops);
> +	debugfs_create_file("send_hif_msg", 0600, d, wdev,
> +			    &wfx_send_hif_msg_fops);
> +	debugfs_create_file("ps_timeout", 0600, d, wdev, &wfx_ps_timeout_fops);

ps_timeout sounds like something which should be in nl80211, not in
debugfs. Please remove it until the driver is accepted.

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes