Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 2D8AFC43460
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Ping-Ke Shih <pkshih@realtek.com>
Cc:     <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v6 13/24] rtw89: 8852a: add 8852a specific files
References: <20210820043538.12424-1-pkshih@realtek.com>
        <20210820043538.12424-14-pkshih@realtek.com>
Date:   Fri, 01 Oct 2021 19:20:53 +0300
In-Reply-To: <20210820043538.12424-14-pkshih@realtek.com> (Ping-Ke Shih's
        message of "Fri, 20 Aug 2021 12:35:27 +0800")
Message-ID: <87bl48iumy.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Ping-Ke Shih <pkshih@realtek.com> writes:

> The 8852A specific chip info and ops are written in this file. The chip
> info describes the chip specific capabilities, and chip ops are specific
> efuse parser, FEM setup, set channel, RFK trigger, set TX power, and
> WL/BT grant controlled by coex.
>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

[...]

> +static struct rtw89_hfc_ch_cfg rtw8852a_hfc_chcfg_pcie[] = {
> +	{128, 1896, grp_0}, /* ACH 0 */
> +	{128, 1896, grp_0}, /* ACH 1 */
> +	{128, 1896, grp_0}, /* ACH 2 */
> +	{128, 1896, grp_0}, /* ACH 3 */
> +	{128, 1896, grp_1}, /* ACH 4 */
> +	{128, 1896, grp_1}, /* ACH 5 */
> +	{128, 1896, grp_1}, /* ACH 6 */
> +	{128, 1896, grp_1}, /* ACH 7 */
> +	{32, 1896, grp_0}, /* B0MGQ */
> +	{128, 1896, grp_0}, /* B0HIQ */
> +	{32, 1896, grp_1}, /* B1MGQ */
> +	{128, 1896, grp_1}, /* B1HIQ */
> +	{40, 0, 0} /* FWCMDQ */
> +};
> +
> +static struct rtw89_hfc_pub_cfg rtw8852a_hfc_pubcfg_pcie = {
> +	1896, /* Group 0 */
> +	1896, /* Group 1 */
> +	3792, /* Public Max */
> +	0 /* WP threshold */
> +};
> +
> +static struct rtw89_hfc_param_ini rtw8852a_hfc_param_ini_pcie[] = {
> +	[RTW89_QTA_SCC] = {rtw8852a_hfc_chcfg_pcie, &rtw8852a_hfc_pubcfg_pcie,
> +			   &rtw_hfc_preccfg_pcie, RTW89_HCIFC_POH},
> +	[RTW89_QTA_DLFW] = {NULL, NULL, &rtw_hfc_preccfg_pcie, RTW89_HCIFC_POH},
> +	[RTW89_QTA_INVALID] = {NULL},
> +};
> +
> +static struct rtw89_dle_mem rtw8852a_dle_mem_pcie[] = {
> +	[RTW89_QTA_SCC] = {RTW89_QTA_SCC, &wde_size0, &ple_size0, &wde_qt0,
> +			    &wde_qt0, &ple_qt4, &ple_qt5},
> +	[RTW89_QTA_DLFW] = {RTW89_QTA_DLFW, &wde_size4, &ple_size4,
> +			    &wde_qt4, &wde_qt4, &ple_qt13, &ple_qt13},
> +	[RTW89_QTA_INVALID] = {RTW89_QTA_INVALID, NULL, NULL, NULL, NULL, NULL,
> +			       NULL},
> +};

const? I also see more variables in this file which I suspect to be
const, but running out of time. Please check those as well.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches